From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
To: Andrew Lunn <andrew@lunn.ch>, David Miller <davem@davemloft.net>
Cc: netdev <netdev@vger.kernel.org>, Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH v3 net-next 5/5] dsa: mv88e6xxx: Enable/Disable SERDES on port enable/disable
Date: Thu, 25 May 2017 19:31:44 -0400 [thread overview]
Message-ID: <87o9ugecnz.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me> (raw)
In-Reply-To: <1495753404-29943-6-git-send-email-andrew@lunn.ch>
Hi Andrew,
Andrew Lunn <andrew@lunn.ch> writes:
> static int mv88e6xxx_serdes_power(struct mv88e6xxx_chip *chip, int port,
> bool on)
> {
> - if (chip->info->ops->serdes_power)
> - return chip->info->ops->serdes_power(chip, port, on);
> + int err = 0;
>
> - return 0;
> + if (chip->info->ops->serdes_power) {
> + err = chip->info->ops->serdes_power(chip, port, on);
> + if (err)
> + dev_err(chip->dev,
> + "Failed to change SERDES power: %d\n", err);
> + }
> +
> + return err;
> }
This is not necessary, please keep mv88e6xxx_serdes_power as it is.
> static int mv88e6xxx_setup_port(struct mv88e6xxx_chip *chip, int port)
> @@ -1862,12 +1868,15 @@ static int mv88e6xxx_setup_port(struct mv88e6xxx_chip *chip, int port)
> if (err)
> return err;
>
> - /* If this port is connected to a SerDes, make sure the SerDes is
> - * powered up.
> + /* Enable the SERDES interface for DSA and CPU ports. Normal
> + * ports SERDES are enabled when the port is enabled, thus
> + * saving a bit of power.
> */
> - err = mv88e6xxx_serdes_power(chip, port, true);
> - if (err)
> - return err;
> + if ((dsa_is_cpu_port(ds, port) || dsa_is_dsa_port(ds, port))) {
> + err = mv88e6xxx_serdes_power(chip, port, true);
> + if (err)
> + return err;
> + }
This is OK.
>
> /* Port Control 2: don't force a good FCS, set the maximum frame size to
> * 10240 bytes, disable 802.1q tags checking, don't discard tagged or
> @@ -1969,6 +1978,29 @@ static int mv88e6xxx_setup_port(struct mv88e6xxx_chip *chip, int port)
> return mv88e6xxx_port_write(chip, port, PORT_DEFAULT_VLAN, 0x0000);
> }
>
> +static int mv88e6xxx_port_enable(struct dsa_switch *ds, int port,
> + struct phy_device *phydev)
> +{
> + struct mv88e6xxx_chip *chip = ds->priv;
> + int err = 0;
> +
> + mutex_lock(&chip->reg_lock);
> + mv88e6xxx_serdes_power(chip, port, true);
> + mutex_unlock(&chip->reg_lock);
Please return the error as usual:
int err;
mutex_lock(&chip->reg_lock);
err = mv88e6xxx_serdes_power(chip, port, true);
mutex_unlock(&chip->reg_lock);
return err;
> +
> + return err;
> +}
> +
> +static void mv88e6xxx_port_disable(struct dsa_switch *ds, int port,
> + struct phy_device *phydev)
> +{
> + struct mv88e6xxx_chip *chip = ds->priv;
> +
> + mutex_lock(&chip->reg_lock);
> + mv88e6xxx_serdes_power(chip, port, false);
> + mutex_unlock(&chip->reg_lock);
And add the message here, since this is that specific function returning
void which skips errors:
mutex_lock(&chip->reg_lock);
if (mv88e6xxx_serdes_power(chip, port, false))
dev_err(chip->dev, "Failed to change SERDES power: %d\n", err);
mutex_unlock(&chip->reg_lock);
Thanks,
Vivien
next prev parent reply other threads:[~2017-05-25 23:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-25 23:03 [PATCH v3 net-next 0/5] net: dsa: mv88e6xxx: Add basic SERDES support Andrew Lunn
2017-05-25 23:03 ` [PATCH v3 net-next 1/5] net: dsa: mv88e6xxx: Move phy functions into phy.[ch] Andrew Lunn
2017-05-25 23:19 ` Vivien Didelot
2017-05-25 23:03 ` [PATCH v3 net-next 2/5] net: dsa: mv88e6xxx: Refactor mv88e6352 SERDES code into an op Andrew Lunn
2017-05-25 23:03 ` [PATCH v3 net-next 3/5] net: dsa: mv88e6xxx: Remove SERDES flag Andrew Lunn
2017-05-25 23:03 ` [PATCH v3 net-next 4/5] net: dsa: mv88e6xxx: mv88e6390X SERDES support Andrew Lunn
2017-05-25 23:03 ` [PATCH v3 net-next 5/5] dsa: mv88e6xxx: Enable/Disable SERDES on port enable/disable Andrew Lunn
2017-05-25 23:31 ` Vivien Didelot [this message]
2017-05-26 19:01 ` [PATCH v3 net-next 0/5] net: dsa: mv88e6xxx: Add basic SERDES support David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o9ugecnz.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me \
--to=vivien.didelot@savoirfairelinux.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).