From: Tobias Waldekranz <tobias@waldekranz.com>
To: Florian Fainelli <f.fainelli@gmail.com>,
Andrew Lunn <andrew@lunn.ch>, Vladimir Oltean <olteanv@gmail.com>
Cc: davem@davemloft.net, kuba@kernel.org, vivien.didelot@gmail.com,
j.vosburgh@gmail.com, vfalico@gmail.com, andy@greyhouse.net,
netdev@vger.kernel.org
Subject: Re: [PATCH v3 net-next 2/4] net: dsa: Link aggregation support
Date: Mon, 07 Dec 2020 22:56:57 +0100 [thread overview]
Message-ID: <87pn3l5lg6.fsf@waldekranz.com> (raw)
In-Reply-To: <2e674d7b-0593-1293-ad4b-3f4a30efe4a1@gmail.com>
On Thu, Dec 03, 2020 at 20:18, Florian Fainelli <f.fainelli@gmail.com> wrote:
> On 12/3/2020 5:33 PM, Andrew Lunn wrote:
>>> Of course, neither is fully correct. There is always more to improve on
>>> the communication side of things.
>>
>> I wonder if switchdev needs to gain an enumeration API? A way to ask
>> the underlying driver, what can you offload? The user can then get an
>> idea what is likely to be offloaded, and what not. If that API is fine
>> grain enough, it can list the different LAG algorithms supported.
>
> For stack offloads we can probably easily agree on what constitutes a
> vendor neutral offload and a name for that enumeration. For other
> features this is going to become an unmaintainable list of features and
> then we are no better than we started 6 years ago with submitting
> OpenWrt's swconfig and each switch driver advertising its features and
> configuration API via netlink.
>
> NETIF_F_SWITCHDEV_OFFLOAD would not be fine grained enough, this needs
> to be a per action selection, just like when offloading the bridge, or
> tc, you need to be able to hint the driver whether the offload is being
> requested by the user.
That makes sense. So you are talking about adding something akin to tc's
skip_hw/skip_sw to `ip link`?
> For now, I would just go with implicitly falling back to doing the LAG
> in software if the requested mode is not supported and leveraging extack
> to indicate that was the case.
Ahh, you can use extack for successful operations? I did not know that,
I think that strikes a good balance.
next prev parent reply other threads:[~2020-12-07 21:57 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-02 9:13 [PATCH v3 net-next 0/4] net: dsa: Link aggregation support Tobias Waldekranz
2020-12-02 9:13 ` [PATCH v3 net-next 1/4] net: bonding: Notify ports about their initial state Tobias Waldekranz
2020-12-02 19:09 ` Jay Vosburgh
2020-12-02 21:52 ` Tobias Waldekranz
2020-12-03 0:39 ` Jay Vosburgh
2020-12-03 8:16 ` Tobias Waldekranz
2020-12-02 9:13 ` [PATCH v3 net-next 2/4] net: dsa: Link aggregation support Tobias Waldekranz
2020-12-02 10:07 ` Vladimir Oltean
2020-12-02 10:51 ` Tobias Waldekranz
2020-12-02 18:58 ` Jakub Kicinski
2020-12-02 21:29 ` Tobias Waldekranz
2020-12-02 21:32 ` Vladimir Oltean
2020-12-03 16:24 ` Vladimir Oltean
2020-12-03 20:53 ` Tobias Waldekranz
2020-12-03 21:09 ` Andrew Lunn
2020-12-03 21:35 ` Tobias Waldekranz
2020-12-04 0:35 ` Vladimir Oltean
2020-12-03 21:57 ` Vladimir Oltean
2020-12-03 23:12 ` Tobias Waldekranz
2020-12-04 0:56 ` Vladimir Oltean
2020-12-07 21:49 ` Tobias Waldekranz
2020-12-04 1:33 ` Andrew Lunn
2020-12-04 4:18 ` Florian Fainelli
2020-12-07 21:56 ` Tobias Waldekranz [this message]
2020-12-03 20:48 ` Vladimir Oltean
2020-12-04 2:20 ` Andrew Lunn
2020-12-07 21:19 ` Tobias Waldekranz
2020-12-07 23:26 ` Andrew Lunn
2020-12-09 8:57 ` Tobias Waldekranz
2020-12-09 14:27 ` Andrew Lunn
2020-12-09 15:21 ` Tobias Waldekranz
2020-12-09 23:03 ` Andrew Lunn
2020-12-04 4:04 ` Florian Fainelli
2020-12-08 11:23 ` Vladimir Oltean
2020-12-08 15:33 ` Tobias Waldekranz
2020-12-08 16:37 ` Vladimir Oltean
2020-12-09 8:37 ` Tobias Waldekranz
2020-12-09 10:53 ` Vladimir Oltean
2020-12-09 14:11 ` Tobias Waldekranz
2020-12-09 16:04 ` Vladimir Oltean
2020-12-09 22:01 ` Tobias Waldekranz
2020-12-09 22:21 ` Vladimir Oltean
2020-12-10 10:18 ` Tobias Waldekranz
2020-12-09 22:59 ` Andrew Lunn
2020-12-10 1:05 ` Vladimir Oltean
2020-12-09 14:23 ` Andrew Lunn
2020-12-09 23:17 ` Vladimir Oltean
2020-12-08 17:26 ` Andrew Lunn
2020-12-11 20:50 ` Tobias Waldekranz
2020-12-12 14:26 ` Vladimir Oltean
2020-12-13 21:18 ` Tobias Waldekranz
2020-12-14 0:12 ` Vladimir Oltean
2020-12-14 11:42 ` Ido Schimmel
2020-12-16 15:15 ` Tobias Waldekranz
2020-12-16 18:48 ` Ido Schimmel
2020-12-14 9:41 ` Tobias Waldekranz
2020-12-02 9:13 ` [PATCH v3 net-next 3/4] net: dsa: mv88e6xxx: " Tobias Waldekranz
2020-12-02 9:13 ` [PATCH v3 net-next 4/4] net: dsa: tag_dsa: Support reception of packets from LAG devices Tobias Waldekranz
2020-12-04 3:58 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pn3l5lg6.fsf@waldekranz.com \
--to=tobias@waldekranz.com \
--cc=andrew@lunn.ch \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=j.vosburgh@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=vfalico@gmail.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).