From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98AA0C4332F for ; Sun, 20 Nov 2022 09:53:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229599AbiKTJxL (ORCPT ); Sun, 20 Nov 2022 04:53:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56448 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229622AbiKTJxJ (ORCPT ); Sun, 20 Nov 2022 04:53:09 -0500 X-Greylist: delayed 761 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Sun, 20 Nov 2022 01:53:07 PST Received: from canardo.dyn.mork.no (fwa5cad-106.bb.online.no [88.92.173.106]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B609D14D26 for ; Sun, 20 Nov 2022 01:53:07 -0800 (PST) Received: from miraculix.mork.no ([IPv6:2a01:799:c9c:2c02:34cc:c78d:869d:3d9d]) (authenticated bits=0) by canardo.dyn.mork.no (8.15.2/8.15.2) with ESMTPSA id 2AK9dRTi1652278 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=OK); Sun, 20 Nov 2022 10:39:27 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mork.no; s=b; t=1668937168; bh=PdJ+aYpOmlHpVIzjVD0/OwJIdZrqeCtt7pLRP1OQdA4=; h=From:To:Cc:Subject:References:Date:Message-ID:From; b=FWoAhED8NgfgPwClN+0HaFpV6YXLn98xUYyg+50nl2kC6dO/fc2g5DsYL8gLEHVgv N+vv6AP3S3vcIQ9eXmMLIDWXIyZbqi9/qw+0OqZVFbMvQooX/fqW/HY1S+xUAZ7WwI VRHOHTD5iioqdxm/aHtjzNfOSzJ0JFgxAvrT42CU= Received: (nullmailer pid 155756 invoked by uid 1000); Sun, 20 Nov 2022 09:39:27 -0000 From: =?utf-8?Q?Bj=C3=B8rn_Mork?= To: Daniele Palmas Cc: Alexander Lobakin , David Miller , Jakub Kicinski , Paolo Abeni , Eric Dumazet , Subash Abhinov Kasiviswanathan , Sean Tranchetti , Jonathan Corbet , Greg Kroah-Hartman , netdev@vger.kernel.org Subject: Re: [PATCH net-next 2/3] net: qualcomm: rmnet: add tx packets aggregation Organization: m References: <20221109180249.4721-1-dnlplm@gmail.com> <20221109180249.4721-3-dnlplm@gmail.com> <20221110173222.3536589-1-alexandr.lobakin@intel.com> <20221116162016.3392565-1-alexandr.lobakin@intel.com> Date: Sun, 20 Nov 2022 10:39:27 +0100 In-Reply-To: (Daniele Palmas's message of "Sun, 20 Nov 2022 10:25:53 +0100") Message-ID: <87tu2unewg.fsf@miraculix.mork.no> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Virus-Scanned: clamav-milter 0.103.7 at canardo X-Virus-Status: Clean Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Daniele Palmas writes: > Ok, so rmnet would only take care of qmap rx packets deaggregation and > qmi_wwan of the tx aggregation. > > At a conceptual level, implementing tx aggregation in qmi_wwan for > passthrough mode could make sense, since the tx aggregation parameters > belong to the physical device and are shared among the virtual rmnet > netdevices, which can't have different aggr configurations if they > belong to the same physical device. > > Bj=C3=B8rn, would this approach be ok for you? Sounds good to me, if this can be done within the userspace API restrictions we've been through. I assume it's possible to make this Just Work(tm) in qmi_wwan passthrough mode? I do not think we want any solution where the user will have to configure both qmi_wwan and rmnet to make things work properly. Bj=C3=B8rn