From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9EB0C4338F for ; Fri, 13 Aug 2021 06:25:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 957EE610A7 for ; Fri, 13 Aug 2021 06:25:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238855AbhHMG0E (ORCPT ); Fri, 13 Aug 2021 02:26:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38240 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238830AbhHMG0C (ORCPT ); Fri, 13 Aug 2021 02:26:02 -0400 Received: from canardo.mork.no (canardo.mork.no [IPv6:2001:4641::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3E021C061756 for ; Thu, 12 Aug 2021 23:25:35 -0700 (PDT) Received: from miraculix.mork.no ([IPv6:2a01:799:95f:ef0a:7f0c:624e:2eac:9b4]) (authenticated bits=0) by canardo.mork.no (8.15.2/8.15.2) with ESMTPSA id 17D6PJ5b008235 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Fri, 13 Aug 2021 08:25:19 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mork.no; s=b; t=1628835919; bh=bp7pZnR9reEk1Vxp5PGpzCMFuYVD2oMgInso1w7A9ec=; h=From:To:Cc:Subject:References:Date:Message-ID:From; b=oC6zEaGd/7yWCn+rL+7wUSJ/+E9YfxAXjUE0ElE3Zw6w+2fER/n+z7E9RSCYrGZnP qSaQ69FIoSmGibiBQNlFenwB9f5uce9zkH9GTmQWA/NUNCC0WuM8VZ0QJrRrPMatDE DsHi1lcOnq1GUiEITm5mkbyTQfH+2CtaF/eJ2bls= Received: from bjorn by miraculix.mork.no with local (Exim 4.94.2) (envelope-from ) id 1mEQd0-000OMT-AH; Fri, 13 Aug 2021 08:25:14 +0200 From: =?utf-8?Q?Bj=C3=B8rn_Mork?= To: subashab@codeaurora.org Cc: Daniele Palmas , Aleksander Morgado , Network Development , Sean Tranchetti Subject: Re: RMNET QMAP data aggregation with size greater than 16384 Organization: m References: <77b850933d9af8ddbc21f5908ca0764d@codeaurora.org> <13972ac97ffe7a10fd85fe03dc84dc02@codeaurora.org> <87bl6aqrat.fsf@miraculix.mork.no> <2c2d1204842f457bb0d0b2c4cd58847d@codeaurora.org> <87sfzlplr2.fsf@miraculix.mork.no> <394353d6f31303c64b0d26bc5268aca7@codeaurora.org> <7aac9ee90376e4757e5f2ebc4948ebed@codeaurora.org> Date: Fri, 13 Aug 2021 08:25:14 +0200 In-Reply-To: <7aac9ee90376e4757e5f2ebc4948ebed@codeaurora.org> (subashab@codeaurora.org's message of "Fri, 13 Aug 2021 00:21:21 -0600") Message-ID: <87tujtamk5.fsf@miraculix.mork.no> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Virus-Scanned: clamav-milter 0.103.2 at canardo X-Virus-Status: Clean Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org subashab@codeaurora.org writes: >> Just an heads-up that when I proposed that urb size there were doubts >> about the value (see >> https://patchwork.ozlabs.org/project/netdev/patch/20200909091302.20992-1= -dnlplm@gmail.com/#2523774 >> and >> https://patchwork.ozlabs.org/project/netdev/patch/20200909091302.20992-1= -dnlplm@gmail.com/#2523958): >> it is true that this time you are setting the size just when qmap is >> enabled, but I think that Carl's comment about low-cat chipsets could >> still apply. >> Thanks, >> Daniele >>=20 > > Thanks for bringing this up. > > Looks like a tunable would be needed to satisfy all users. > Perhaps we can use 32k as default in mux and passthrough mode but > allow for changes > there if needed through a sysfs. Sounds reasonable to me. Bj=C3=B8rn