From: Sergey Organov <sorganov@gmail.com>
To: Andy Duan <fugang.duan@nxp.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>
Subject: Re: [EXT] [PATCH 4/5] net: fec: get rid of redundant code in fec_ptp_set()
Date: Tue, 07 Jul 2020 17:43:22 +0300 [thread overview]
Message-ID: <87tuyj8jxx.fsf@osv.gnss.ru> (raw)
In-Reply-To: <AM6PR0402MB3607DE03C3333B9E4C8D3309FF660@AM6PR0402MB3607.eurprd04.prod.outlook.com> (Andy Duan's message of "Tue, 7 Jul 2020 04:08:08 +0000")
Andy Duan <fugang.duan@nxp.com> writes:
> From: Sergey Organov <sorganov@gmail.com> Sent: Monday, July 6, 2020 10:26 PM
>> Code of the form "if(x) x = 0" replaced with "x = 0".
>>
>> Code of the form "if(x == a) x = a" removed.
>>
>> Signed-off-by: Sergey Organov <sorganov@gmail.com>
>> ---
>> drivers/net/ethernet/freescale/fec_ptp.c | 4 +---
>> 1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/freescale/fec_ptp.c
>> b/drivers/net/ethernet/freescale/fec_ptp.c
>> index e455343..4152cae 100644
>> --- a/drivers/net/ethernet/freescale/fec_ptp.c
>> +++ b/drivers/net/ethernet/freescale/fec_ptp.c
>> @@ -485,9 +485,7 @@ int fec_ptp_set(struct net_device *ndev, struct ifreq
>> *ifr)
>>
>> switch (config.rx_filter) {
>> case HWTSTAMP_FILTER_NONE:
>> - if (fep->hwts_rx_en)
>> - fep->hwts_rx_en = 0;
>> - config.rx_filter = HWTSTAMP_FILTER_NONE;
> The line should keep according your commit log.
You mean I should fix commit log like this:
Code of the form "switch(x) case a: x = a; break" removed.
?
I'll do if it's cleaner that way.
Thanks,
-- Sergey
>
>> + fep->hwts_rx_en = 0;
>> break;
>>
>> default:
>> --
>> 2.10.0.1.g57b01a3
next prev parent reply other threads:[~2020-07-07 14:43 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-06 14:26 [PATCH 0/5] net: fec: fix external PTP PHY support Sergey Organov
2020-07-06 14:26 ` [PATCH 1/5] net: fec: properly support external PTP PHY for hardware time stamping Sergey Organov
2020-07-06 15:08 ` Vladimir Oltean
2020-07-06 15:21 ` Sergey Organov
2020-07-06 15:47 ` Vladimir Oltean
2020-07-06 18:33 ` Sergey Organov
2020-07-07 7:04 ` Vladimir Oltean
2020-07-07 15:29 ` Sergey Organov
2020-07-08 11:00 ` Richard Cochran
2020-07-08 10:55 ` Richard Cochran
2020-07-06 14:26 ` [PATCH 2/5] net: fec: enable to use PPS feature without " Sergey Organov
2020-07-07 4:05 ` [EXT] " Andy Duan
2020-07-07 14:29 ` Sergey Organov
2020-07-06 14:26 ` [PATCH 3/5] net: fec: initialize clock with 0 rather than current kernel time Sergey Organov
2020-07-06 15:27 ` Vladimir Oltean
2020-07-06 18:24 ` Sergey Organov
2020-07-07 6:36 ` Vladimir Oltean
2020-07-07 16:07 ` Sergey Organov
2020-07-07 16:43 ` Vladimir Oltean
2020-07-07 17:09 ` Sergey Organov
2020-07-07 17:12 ` Vladimir Oltean
2020-07-07 17:56 ` Sergey Organov
2020-07-08 11:15 ` Richard Cochran
2020-07-08 12:14 ` Sergey Organov
2020-07-08 11:11 ` Richard Cochran
2020-07-08 11:04 ` Richard Cochran
2020-07-08 12:24 ` Sergey Organov
2020-07-08 12:37 ` Sergey Organov
2020-07-08 14:48 ` Richard Cochran
2020-07-08 17:18 ` Sergey Organov
2020-07-06 14:26 ` [PATCH 4/5] net: fec: get rid of redundant code in fec_ptp_set() Sergey Organov
2020-07-07 4:08 ` [EXT] " Andy Duan
2020-07-07 14:43 ` Sergey Organov [this message]
2020-07-08 5:34 ` Andy Duan
2020-07-08 8:48 ` Sergey Organov
2020-07-08 8:57 ` Andy Duan
2020-07-08 12:26 ` Sergey Organov
2020-07-06 14:26 ` [PATCH 5/5] net: fec: replace snprintf() with strlcpy() in fec_ptp_init() Sergey Organov
2020-07-11 12:08 ` [PATCH v2 net] net: fec: fix hardware time stamping by external devices Sergey Organov
2020-07-11 23:19 ` Vladimir Oltean
2020-07-12 14:16 ` Sergey Organov
2020-07-12 14:47 ` Andrew Lunn
2020-07-12 15:01 ` Vladimir Oltean
2020-07-12 17:29 ` Sergey Organov
2020-07-12 19:33 ` Vladimir Oltean
2020-07-12 22:32 ` Sergey Organov
2020-07-12 23:15 ` Vladimir Oltean
2020-07-14 12:39 ` Sergey Organov
2020-07-14 14:23 ` Vladimir Oltean
2020-07-14 14:35 ` Sergey Organov
2020-07-14 14:44 ` Vladimir Oltean
2020-07-14 16:18 ` Sergey Organov
2020-07-14 14:01 ` Richard Cochran
2020-07-14 14:27 ` Sergey Organov
2020-07-14 16:28 ` [PATCH v3 " Sergey Organov
2020-07-16 18:24 ` Jakub Kicinski
2020-07-16 20:38 ` Sergey Organov
2020-07-16 21:06 ` Jakub Kicinski
2020-07-16 21:18 ` Sergey Organov
2020-07-15 15:42 ` [PATCH net-next v2 0/4] net: fec: a few improvements Sergey Organov
2020-07-15 15:42 ` [PATCH net-next v2 1/4] net: fec: enable to use PPS feature without time stamping Sergey Organov
2020-07-15 15:42 ` [PATCH net-next v2 2/4] net: fec: initialize clock with 0 rather than current kernel time Sergey Organov
2020-07-15 15:42 ` [PATCH net-next v2 3/4] net: fec: get rid of redundant code in fec_ptp_set() Sergey Organov
2020-07-15 15:43 ` [PATCH net-next v2 4/4] net: fec: replace snprintf() with strlcpy() in fec_ptp_init() Sergey Organov
2020-07-16 3:00 ` [EXT] [PATCH net-next v2 0/4] net: fec: a few improvements Andy Duan
2020-07-16 18:37 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tuyj8jxx.fsf@osv.gnss.ru \
--to=sorganov@gmail.com \
--cc=davem@davemloft.net \
--cc=fugang.duan@nxp.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).