From: Kalle Valo <kvalo@codeaurora.org>
To: Ramon Fried <rfried@codeaurora.org>
Cc: netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
bjorn.andersson@linaro.org, wcn36xx@lists.infradead.org,
k.eugene.e@gmail.com
Subject: Re: [PATCH v2] wcn36xx: release resources in case of error
Date: Wed, 24 Jan 2018 15:22:46 +0200 [thread overview]
Message-ID: <87tvvbtmqh.fsf@purkki.adurom.net> (raw)
In-Reply-To: <20180123152013.18257-1-rfried@codeaurora.org> (Ramon Fried's message of "Tue, 23 Jan 2018 17:20:13 +0200")
Ramon Fried <rfried@codeaurora.org> writes:
> wcn36xx_dxe_init() doesn't check for the return value
> of wcn36xx_dxe_init_descs().
> This patch releases the resources in case an error ocurred.
>
> Change-Id: I924bd7489b60243c0a0cbaa716caf924f11d7587
> Signed-off-by: Ramon Fried <rfried@codeaurora.org>
This compiled now, thanks. But I did some minor changes in the commit
log and in indentation on the pending branch:
https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=master-pending&id=e5ff4344eab68c86e00036e937847ce89dfaeef6
> @@ -819,11 +847,19 @@ int wcn36xx_dxe_init(struct wcn36xx *wcn)
>
> ret = wcn36xx_dxe_request_irqs(wcn);
> if (ret < 0)
> - goto out_err;
> + goto out_err_irq;
The recommended style is to label the err_ based what the target does,
not from where they are called from. It's easier to manage the labels
that way. But as this is a style issue I didn't change it.
--
Kalle Valo
next prev parent reply other threads:[~2018-01-24 13:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-23 15:20 [PATCH v2] wcn36xx: release resources in case of error Ramon Fried
2018-01-24 13:22 ` Kalle Valo [this message]
2018-01-25 5:36 ` [v2] " Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tvvbtmqh.fsf@purkki.adurom.net \
--to=kvalo@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=k.eugene.e@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rfried@codeaurora.org \
--cc=wcn36xx@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).