From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 646D9C61DB3 for ; Thu, 12 Jan 2023 09:53:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232016AbjALJw7 (ORCPT ); Thu, 12 Jan 2023 04:52:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33274 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235489AbjALJw3 (ORCPT ); Thu, 12 Jan 2023 04:52:29 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F31503E865; Thu, 12 Jan 2023 01:49:05 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 88EAC61F19; Thu, 12 Jan 2023 09:49:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 896A9C433EF; Thu, 12 Jan 2023 09:49:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1673516945; bh=K4sEkNSpKTq3237afOVAYuzESNTvUDb/uVoy4XVOHkM=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=bdyodrY9SMNqvr6mxwhBmrVJtHWDDIF4h9q/E06/zz/PKt1WwbhriFbFOhcD9PMPw OPQmktJS60bKr8GuDnqbRhYLRg6xeTX9bmbzvS9vUTEWDJnLM/RH/6yTha9N2rLJxI fzHIKoiVQ4Fv9OjliJXR6a8BvXa1GFTkLdSv+jW+P0V6A9eOx9zPDgBv938Ths5fht gWwKo/vLlgnVpO+gzihTwYR0oUq4LPe3AYCAm6ul/YQLs0oVK35LXbNyaRpn0cYsS4 UkoQUyfIkmc+5MOpWPVGGbP57gpy0uj8XTV3TUHfOZaA4Fde7BsA9teyD8q+sHOO1B hoB+YKeNls+Pg== From: Kalle Valo To: Robert Marko Cc: Manivannan Sadhasivam , Robert Marko , davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, gregkh@linuxfoundation.org, elder@linaro.org, hemantk@codeaurora.org, quic_jhugo@quicinc.com, quic_qianyu@quicinc.com, bbhatt@codeaurora.org, mhi@lists.linux.dev, linux-arm-msm@vger.kernel.org, ath11k@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, ansuelsmth@gmail.com Subject: Re: [PATCH 2/2] wifi: ath11k: use unique QRTR instance ID References: <20221105194943.826847-1-robimarko@gmail.com> <20221105194943.826847-2-robimarko@gmail.com> <20221107174727.GA7535@thinkpad> <87cz9xcqbd.fsf@kernel.org> <877czn8c2n.fsf@kernel.org> <87k02jzgkz.fsf@kernel.org> <87358hyp3x.fsf@kernel.org> <877cxsdrax.fsf@kernel.org> Date: Thu, 12 Jan 2023 11:48:59 +0200 In-Reply-To: (Robert Marko's message of "Thu, 12 Jan 2023 10:43:37 +0100") Message-ID: <87y1q8ccc4.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Robert Marko writes: > On Thu, Jan 12, 2023 at 10:40 AM Kalle Valo wrote: >> >> Robert Marko writes: >> >> > On Wed, Jan 11, 2023 at 6:10 PM Kalle Valo wrote: >> >> >> >> Robert Marko writes: >> >> >> >> >> Really sorry, I just didn't manage to get this finalised due to other >> >> >> stuff and now I'm leaving for a two week vacation :( >> >> > >> >> > Any news regarding this, I have a PR for ipq807x support in OpenWrt >> >> > and the current workaround for supporting AHB + PCI or multiple PCI >> >> > cards is breaking cards like QCA6390 which are obviously really >> >> > popular. >> >> >> >> Sorry, came back only on Monday and trying to catch up slowly. But I >> >> submitted the RFC now: >> >> >> >> https://patchwork.kernel.org/project/linux-wireless/patch/20230111170033.32454-1-kvalo@kernel.org/ >> > >> > Great, thanks for that. >> > >> > Does it depend on firmware-2 being available? >> >> The final solution for the users will require firmware-2.bin. But for a >> quick test you can omit the feature bit test by replacing >> "test_bit(ATH11K_FW_FEATURE_MULTI_QRTR_ID, ab->fw.fw_features)" with >> "true". Just make sure that the firmware release you are using supports >> this feature, I believe only recent QCN9074 releases do that. > > I was able to test on IPQ8074+QCN9074 yesterday by just bypassing the > test and it worked. > > Sideffect is that until firmware-2.bin is available cards like QCA6390 > wont work like with my hack. Not following here, can you elaborate what won't work with QCA6390? -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches