From: "Bjørn Mork" <bjorn@mork.no>
To: Andrew Bird <ajb@spheresystems.co.uk>
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] USB: qmi_wwan: Add ZTE (Vodafone) K3520-Z
Date: Sun, 20 May 2012 12:53:45 +0200 [thread overview]
Message-ID: <87y5ongm2u.fsf@nemi.mork.no> (raw)
In-Reply-To: <1337502518-1444-3-git-send-email-ajb@spheresystems.co.uk> (Andrew Bird's message of "Sun, 20 May 2012 09:28:38 +0100")
Andrew Bird <ajb@spheresystems.co.uk> writes:
> Signed-off-by: Andrew Bird <ajb@spheresystems.co.uk>
Acked-by: Bjørn Mork <bjorn@mork.no>
> /* ZTE suck at making USB descriptors */
> +static const struct driver_info qmi_wwan_force_int1 = {
> + .description = "Qualcomm WWAN/QMI device",
> + .flags = FLAG_WWAN,
> + .bind = qmi_wwan_bind_shared,
> + .unbind = qmi_wwan_unbind_shared,
> + .manage_power = qmi_wwan_manage_power,
> + .data = BIT(1), /* interface whitelist bitmap */
> +};
> +
> static const struct driver_info qmi_wwan_force_int4 = {
> .description = "Qualcomm WWAN/QMI device",
> .flags = FLAG_WWAN,
> @@ -430,6 +439,15 @@ static const struct usb_device_id products[] = {
> .bInterfaceProtocol = 0xff,
> .driver_info = (unsigned long)&qmi_wwan_force_int4,
> },
> + { /* ZTE (Vodafone) K3520-Z */
> + .match_flags = USB_DEVICE_ID_MATCH_DEVICE | USB_DEVICE_ID_MATCH_INT_INFO,
> + .idVendor = 0x19d2,
> + .idProduct = 0x0055,
> + .bInterfaceClass = 0xff,
> + .bInterfaceSubClass = 0xff,
> + .bInterfaceProtocol = 0xff,
> + .driver_info = (unsigned long)&qmi_wwan_force_int1,
> + },
> { /* ZTE (Vodafone) K3565-Z */
> .match_flags = USB_DEVICE_ID_MATCH_DEVICE | USB_DEVICE_ID_MATCH_INT_INFO,
> .idVendor = 0x19d2,
Looking forward to changing all this to a single line device + interface
number macro in 3.6 :-)
Bjørn
next prev parent reply other threads:[~2012-05-20 10:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-20 8:28 [PATCH 1/3] USB: qmi_wwan: Make forced int 4 whitelist generic Andrew Bird
[not found] ` <1337502518-1444-1-git-send-email-ajb-5+cxppFmGx6/3pe1ocb+s/XRex20P6io@public.gmane.org>
2012-05-20 8:28 ` [PATCH 2/3] USB: qmi_wwan: Add ZTE (Vodafone) K3765-Z Andrew Bird
2012-05-20 10:52 ` Bjørn Mork
2012-05-20 20:59 ` David Miller
2012-05-20 20:59 ` David Miller
2012-05-20 8:28 ` [PATCH 3/3] USB: qmi_wwan: Add ZTE (Vodafone) K3520-Z Andrew Bird
2012-05-20 10:53 ` Bjørn Mork [this message]
2012-05-20 10:50 ` [PATCH 1/3] USB: qmi_wwan: Make forced int 4 whitelist generic Bjørn Mork
2012-05-20 20:59 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y5ongm2u.fsf@nemi.mork.no \
--to=bjorn@mork.no \
--cc=ajb@spheresystems.co.uk \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).