From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 80175C433EF
	for <netdev@archiver.kernel.org>; Wed, 10 Nov 2021 08:53:54 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id 5D793611C0
	for <netdev@archiver.kernel.org>; Wed, 10 Nov 2021 08:53:54 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S230429AbhKJI4k (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Wed, 10 Nov 2021 03:56:40 -0500
Received: from mx3.molgen.mpg.de ([141.14.17.11]:42919 "EHLO mx1.molgen.mpg.de"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S229831AbhKJI4k (ORCPT <rfc822;netdev@vger.kernel.org>);
        Wed, 10 Nov 2021 03:56:40 -0500
Received: from [141.14.13.160] (g415.RadioFreeInternet.molgen.mpg.de [141.14.13.160])
        (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
         key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
        (No client certificate requested)
        (Authenticated sender: pmenzel)
        by mx.molgen.mpg.de (Postfix) with ESMTPSA id EE63561E5FE00;
        Wed, 10 Nov 2021 09:53:50 +0100 (CET)
Message-ID: <89022668-5c63-bf19-a768-6bef2a3be3b0@molgen.mpg.de>
Date:   Wed, 10 Nov 2021 09:53:50 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.0
Subject: Re: [Intel-wired-lan] [PATCH net] iavf: missing unlocks in
 iavf_watchdog_task()
Content-Language: en-US
To:     Dan Carpenter <dan.carpenter@oracle.com>
Cc:     Jakub Pawlak <jakub.pawlak@intel.com>, netdev@vger.kernel.org,
        kernel-janitors@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
        intel-wired-lan@lists.osuosl.org,
        "David S. Miller" <davem@davemloft.net>,
        Jesse Brandeburg <jesse.brandeburg@intel.com>,
        Mateusz Palczewski <mateusz.palczewski@intel.com>
References: <20211110081350.GI5176@kili>
From:   Paul Menzel <pmenzel@molgen.mpg.de>
In-Reply-To: <20211110081350.GI5176@kili>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

Dear Dan,


Thank you for your patch.

For the future, just a nit for the commit message summary. Could you 
make it a statement by adding a verb (in imperative mood) [1].

 > iavf: Add missing unlocks in iavf_watchdog_task()


Kind regards,

Paul


[1]: https://chris.beams.io/posts/git-commit/