From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kumar Gala Subject: Re: [PATCH v11 4/5] powerpc: Add flexcan device support for p1010rdb. Date: Wed, 10 Aug 2011 12:01:51 -0500 Message-ID: <8E5FA886-038D-4DF4-8A54-DD60188A21A2@kernel.crashing.org> References: <1312993670-23999-1-git-send-email-holt@sgi.com> <1312993670-23999-5-git-send-email-holt@sgi.com> Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, U Bhaskar-B22300 , socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org, Marc Kleine-Budde , PPC list , Wolfgang Grandegger To: Robin Holt Return-path: In-Reply-To: <1312993670-23999-5-git-send-email-holt-sJ/iWh9BUns@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: socketcan-core-bounces-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org Errors-To: socketcan-core-bounces-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org List-Id: netdev.vger.kernel.org On Aug 10, 2011, at 11:27 AM, Robin Holt wrote: > I added a simple clock source for the p1010rdb so the flexcan driver > could determine a clock frequency. The p1010 flexcan device only has > an oscillator of system bus frequency divided by 2. > > Signed-off-by: Robin Holt > Acked-by: Marc Kleine-Budde , > Acked-by: Wolfgang Grandegger , > Cc: U Bhaskar-B22300 > Cc: socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org, > Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, > Cc: PPC list > Cc: Kumar Gala > --- > arch/powerpc/platforms/85xx/Kconfig | 2 + > arch/powerpc/platforms/85xx/Makefile | 2 + > arch/powerpc/platforms/85xx/clock.c | 52 ++++++++++++++++++++++++++++++++ > arch/powerpc/platforms/85xx/p1010rdb.c | 8 +++++ > 4 files changed, 64 insertions(+), 0 deletions(-) > create mode 100644 arch/powerpc/platforms/85xx/clock.c I dont understand how mpc85xx_clk_functions() ends up being associated with the frequency the flexcan is running at. This either seems to global or I'm missing something. I still think the clk / freq info should be in the device tree and handled in the driver and NOT arch/powerpc platform code. - k