From: Felix Fietkau <nbd@nbd.name>
To: Alexander 'lynxis' Couzens <lynxis@fe80.eu>
Cc: netdev@vger.kernel.org, John Crispin <john@phrozen.org>,
Sean Wang <sean.wang@mediatek.com>,
Mark Lee <Mark-MC.Lee@mediatek.com>,
Lorenzo Bianconi <lorenzo@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Russell King <linux@armlinux.org.uk>,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 4/6] net: ethernet: mtk_eth_soc: implement multi-queue support for per-port queues
Date: Fri, 18 Nov 2022 17:30:46 +0100 [thread overview]
Message-ID: <8EC28201-A848-4078-812A-AFE08ED12F7B@nbd.name> (raw)
In-Reply-To: <20221118151331.4694574f@javelin>
> On 18. Nov 2022, at 16:13, Alexander 'lynxis' Couzens <lynxis@fe80.eu> wrote:
>
> Hi Felix,
>
>> On Wed, 16 Nov 2022 09:07:32 +0100
>> Felix Fietkau <nbd@nbd.name> wrote:
>>
>> @@ -614,6 +618,75 @@ static void mtk_mac_link_down(struct phylink_config *config, unsigned int mode,
>> mtk_w32(mac->hw, mcr, MTK_MAC_MCR(mac->id));
>> }
>>
>> +static void mtk_set_queue_speed(struct mtk_eth *eth, unsigned int idx,
>> + int speed)
>> +{
>> + const struct mtk_soc_data *soc = eth->soc;
>> + u32 ofs, val;
>> +
>> + if (!MTK_HAS_CAPS(soc->caps, MTK_QDMA))
>> + return;
>> +
>> + val = MTK_QTX_SCH_MIN_RATE_EN |
>> + /* minimum: 10 Mbps */
>> + FIELD_PREP(MTK_QTX_SCH_MIN_RATE_MAN, 1) |
>> + FIELD_PREP(MTK_QTX_SCH_MIN_RATE_EXP, 4) |
>> + MTK_QTX_SCH_LEAKY_BUCKET_SIZE;
>> + if (!MTK_HAS_CAPS(eth->soc->caps, MTK_NETSYS_V2))
>> + val |= MTK_QTX_SCH_LEAKY_BUCKET_EN;
>> +
>> + if (IS_ENABLED(CONFIG_SOC_MT7621)) {
>> + switch (speed) {
>> + case SPEED_10:
>> + val |= MTK_QTX_SCH_MAX_RATE_EN |
>> + FIELD_PREP(MTK_QTX_SCH_MAX_RATE_MAN, 103) |
>> + FIELD_PREP(MTK_QTX_SCH_MAX_RATE_EXP, 2) |
>> + FIELD_PREP(MTK_QTX_SCH_MAX_RATE_WEIGHT, 1);
>> + break;
>> + case SPEED_100:
>> + val |= MTK_QTX_SCH_MAX_RATE_EN |
>> + FIELD_PREP(MTK_QTX_SCH_MAX_RATE_MAN, 103) |
>> + FIELD_PREP(MTK_QTX_SCH_MAX_RATE_EXP, 3);
>> + FIELD_PREP(MTK_QTX_SCH_MAX_RATE_WEIGHT, 1);
>> + break;
>> + case SPEED_1000:
>> + val |= MTK_QTX_SCH_MAX_RATE_EN |
>> + FIELD_PREP(MTK_QTX_SCH_MAX_RATE_MAN, 105) |
>> + FIELD_PREP(MTK_QTX_SCH_MAX_RATE_EXP, 4) |
>> + FIELD_PREP(MTK_QTX_SCH_MAX_RATE_WEIGHT, 10);
>> + break;
>> + default:
>> + break;
>> + }
>> + } else {
>> + switch (speed) {
>> + case SPEED_10:
>> + val |= MTK_QTX_SCH_MAX_RATE_EN |
>> + FIELD_PREP(MTK_QTX_SCH_MAX_RATE_MAN, 1) |
>> + FIELD_PREP(MTK_QTX_SCH_MAX_RATE_EXP, 4) |
>> + FIELD_PREP(MTK_QTX_SCH_MAX_RATE_WEIGHT, 1);
>> + break;
>> + case SPEED_100:
>> + val |= MTK_QTX_SCH_MAX_RATE_EN |
>> + FIELD_PREP(MTK_QTX_SCH_MAX_RATE_MAN, 1) |
>> + FIELD_PREP(MTK_QTX_SCH_MAX_RATE_EXP, 5);
>> + FIELD_PREP(MTK_QTX_SCH_MAX_RATE_WEIGHT, 1);
>> + break;
>> + case SPEED_1000:
>> + val |= MTK_QTX_SCH_MAX_RATE_EN |
>> + FIELD_PREP(MTK_QTX_SCH_MAX_RATE_MAN, 10) |
>> + FIELD_PREP(MTK_QTX_SCH_MAX_RATE_EXP, 5) |
>> + FIELD_PREP(MTK_QTX_SCH_MAX_RATE_WEIGHT, 10);
>> + break;
>> + default:
>> + break;
>> + }
>> + }
>> +
>> + ofs = MTK_QTX_OFFSET * idx;
>> + mtk_w32(eth, val, soc->reg_map->qdma.qtx_sch + ofs);
>> +}
>> +
>> static void mtk_mac_link_up(struct phylink_config *config,
>> struct phy_device *phy,
>> unsigned int mode, phy_interface_t interface,
>> @@ -639,6 +712,8 @@ static void mtk_mac_link_up(struct phylink_config *config,
>
>
> What's happening to 2.5Gbit ports (e.g. on mt7622)? Should be SPEED_2500 also in the switch/case?
> E.g. a direct connected 2.5Gbit phy to GMAC0.
> Or a mt7622 GMAC0 to mt7531 port 6 and a 2.5Gbit phy to port 5.
On 2.5 Gbit/s, the code disables rate limiting, since it’s not needed. That’s why it’s not handled here
- Felix
next prev parent reply other threads:[~2022-11-18 16:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-16 8:07 Multiqueue support for mtk_eth_soc Felix Fietkau
2022-11-16 8:07 ` [PATCH net-next 1/6] net: ethernet: mtk_eth_soc: increase tx ring size for QDMA devices Felix Fietkau
2022-11-19 3:50 ` patchwork-bot+netdevbpf
2022-11-16 8:07 ` [PATCH net-next 2/6] net: ethernet: mtk_eth_soc: drop packets to WDMA if the ring is full Felix Fietkau
2022-11-16 8:07 ` [PATCH net-next 3/6] net: ethernet: mtk_eth_soc: avoid port_mg assignment on MT7622 and newer Felix Fietkau
2022-11-16 8:07 ` [PATCH net-next 4/6] net: ethernet: mtk_eth_soc: implement multi-queue support for per-port queues Felix Fietkau
2022-11-18 15:13 ` Alexander 'lynxis' Couzens
2022-11-18 16:30 ` Felix Fietkau [this message]
2022-11-16 8:07 ` [PATCH net-next 5/6] net: dsa: tag_mtk: assign " Felix Fietkau
2022-11-16 18:26 ` Florian Fainelli
2022-11-16 8:07 ` [PATCH net-next 6/6] net: ethernet: mediatek: ppe: assign per-port queues for offloaded traffic Felix Fietkau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8EC28201-A848-4078-812A-AFE08ED12F7B@nbd.name \
--to=nbd@nbd.name \
--cc=Mark-MC.Lee@mediatek.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=john@phrozen.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=lorenzo@kernel.org \
--cc=lynxis@fe80.eu \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sean.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).