From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A9CDC282CC for ; Sun, 27 Jan 2019 18:22:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2C8242146E for ; Sun, 27 Jan 2019 18:22:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=hartkopp.net header.i=@hartkopp.net header.b="pZuP4i5d" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726878AbfA0SWx (ORCPT ); Sun, 27 Jan 2019 13:22:53 -0500 Received: from mo4-p01-ob.smtp.rzone.de ([85.215.255.50]:14861 "EHLO mo4-p01-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726523AbfA0SWx (ORCPT ); Sun, 27 Jan 2019 13:22:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1548613370; s=strato-dkim-0002; d=hartkopp.net; h=In-Reply-To:Date:Message-ID:From:References:Cc:To:Subject: X-RZG-CLASS-ID:X-RZG-AUTH:From:Subject:Sender; bh=PTBMBLtB22LaxuajRpYrE9VuQJtmmbY6L6qjaDR0+h0=; b=pZuP4i5dUZUvxUVm8tW3t+eCBNS1b5fFr+RiBhiHV60jBSXh4do4kvI4+YKYRl3dDw AmYghJ8kOjWI+n3Fzg3T1/UdtXN6VecOKyI/uWMBxavKj51vTH9HWPMTZzt8N5GHKvPp F4San8A3Klq/gMPDPxIEbN5lOQqV8AtX/ysg0MC7Pfi3PpBfQiV/Z+6eJzoAa0W5vcWn 0YMW6YtoDa8siI3iNPiXBuQkx+/OOVwz5UmWbuM/9g9Bi/qXn4zYt7D79XYczHcK5320 kMKQrUYWTUx/lyW2fKIQQL0EE8UMFfFmwPDl7Y7JWNEa0Ga1gCW2ggXBC9CHRIvxAn1B R/qg== X-RZG-AUTH: ":P2MHfkW8eP4Mre39l357AZT/I7AY/7nT2yrDxb8mjG14FZxedJy6qgO1o3HMbEWKNNeQSb4O" X-RZG-CLASS-ID: mo00 Received: from [192.168.1.200] by smtp.strato.de (RZmta 44.9 DYNA|AUTH) with ESMTPSA id j01e49v0RIMhQ33 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (curve secp521r1 with 521 ECDH bits, eq. 15360 bits RSA)) (Client did not present a certificate); Sun, 27 Jan 2019 19:22:43 +0100 (CET) Subject: Re: [PATCH] [stable pre-4.8] can: bcm: check timer values before ktime conversion To: Sasha Levin Cc: davem@davemloft.net, netdev@vger.kernel.org, stable@vger.kernel.org, linux-can@vger.kernel.org, lifeasageek@gmail.com, threeearcat@gmail.com, syzkaller@googlegroups.com, nautsch2@gmail.com, Kyungtae Kim , Marc Kleine-Budde References: <20190124090842.2938-1-socketcan@hartkopp.net> <20190126181718.GE30183@sasha-vm> From: Oliver Hartkopp Message-ID: <8a72ffa5-dac5-6de8-f01e-dfbb98b1f024@hartkopp.net> Date: Sun, 27 Jan 2019 19:22:38 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190126181718.GE30183@sasha-vm> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi Sasha, On 26.01.19 19:17, Sasha Levin wrote: > On Thu, Jan 24, 2019 at 10:08:42AM +0100, Oliver Hartkopp wrote: >> Kyungtae Kim detected a potential integer overflow in bcm_[rx|tx]_setup() >> when the conversion into ktime multiplies the given value with >> NSEC_PER_USEC >> (1000). >> >> Reference: https://marc.info/?l=linux-can&m=154732118819828&w=2 >> >> Add a check for the given tv_usec, so that the value stays below one >> second. >> Additionally limit the tv_sec value to a reasonable value for CAN related >> use-cases of 400 days and ensure all values to be positive. >> >> This patch is the pre-4.8 version of upstream commit 93171ba6f1deffd8 > > I can't find this commit id upstream, there's nothing with the same > subject name, nor does this code exist upstream. What's going on? Here we are (pulled by Linus some minutes ago): https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=93171ba6f1deffd82f381d36cb13177872d023f6 Can you go with this pre-4.8 version now? Many thanks, Oliver