From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04544C63798 for ; Fri, 20 Nov 2020 04:01:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 964DD222C8 for ; Fri, 20 Nov 2020 04:01:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TQZwP4aS" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726321AbgKTEB2 (ORCPT ); Thu, 19 Nov 2020 23:01:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48004 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725944AbgKTEB1 (ORCPT ); Thu, 19 Nov 2020 23:01:27 -0500 Received: from mail-io1-xd42.google.com (mail-io1-xd42.google.com [IPv6:2607:f8b0:4864:20::d42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 33009C0613CF; Thu, 19 Nov 2020 20:01:27 -0800 (PST) Received: by mail-io1-xd42.google.com with SMTP id m13so8528083ioq.9; Thu, 19 Nov 2020 20:01:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=kRf+0fLjXqPi4tn9lMnjFFTRUejoTSHqOHRd70Pcq7o=; b=TQZwP4aS11yCae/sz1LF5G8I8UOR79JSSsd/hxaTZJoiyDjCHYC7+U6JYRJq+Vo4HS zktQaHnpMta4XwiZ+LfcF9r3qJhFsqPmelYTaBfK/uUw6jMpwFqDap3RjPQZNdb8bwmR s2xZbw92wTDHO2di4yMXXYUnLc0L9J9DZbhTHiXsaP1rKk2aJG/68Hu0brqQ5potAi4n bSrhtsgCAddcMpxQvQthzSOpct0z+Zmgzbd3svVC0BZGZWPwDxdZsUK0i6ycMZy7Lgw3 6HLso8/E27uvWIMZ68kPAObPLJJ4AgTU8Zb2+iGPEhadX4zBTxifrJmFnUGwVIoJ56IG KxFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=kRf+0fLjXqPi4tn9lMnjFFTRUejoTSHqOHRd70Pcq7o=; b=CsVUDYc83cxNbYc2a3TQ0jWTX3mIXCHYKpYaYpWShtaz6t63mEVy0wzoN6JbVXQ2+q byytPqKjrtEZ2VLlj+CiCrxbKQMRLv6Q+Q5eFJlb8953j7JfusCmBOUysTc2HL6IWPH1 vVtEGhXpNSVmZE12NSqykaoAzNZaXEJYp8iQeqoUU1FqqHYHFFjOgdvpTLcuGkoDDW1o wbguHBwosQplm0Oc/2PQ/G2ivkTBN/yxTloyhzcVFkr1+QaXtslTCgl4vvVhnHtA8fUW d3TuLhb9WLfwP/U5V3YtuZK6QwwgUtoWnUcfkq9YM6pkBF64uBY6uFjZxGj10vrPnd5i 9vew== X-Gm-Message-State: AOAM532BsNmlkXpORGS6LibYX+q+THT68alj4ShlF+qf2HLgNg1vbmtp VkvapKpjldNGzcKV5VIUd+IDMhf4Juo= X-Google-Smtp-Source: ABdhPJzVAnaLmKeY3QZv5cyXRFE/TFuXiZSxiGaamS++sLb3IFtvDsgdWXS8NGopOFU8dnWiof9ecA== X-Received: by 2002:a5d:9c87:: with SMTP id p7mr9740236iop.49.1605844886495; Thu, 19 Nov 2020 20:01:26 -0800 (PST) Received: from Davids-MacBook-Pro.local ([2601:282:800:dc80:7c5d:d56d:e694:8d47]) by smtp.googlemail.com with ESMTPSA id z9sm753230iog.3.2020.11.19.20.01.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Nov 2020 20:01:25 -0800 (PST) Subject: Re: [PATCH v4 net-next 0/3] add support for sending RFC8335 PROBE From: David Ahern To: Andreas Roeseler , davem@davemloft.net Cc: kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org, kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: Message-ID: <8ac13fd8-69ac-723d-d84d-c16c4fa0a9ab@gmail.com> Date: Thu, 19 Nov 2020 21:01:25 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.4.3 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 11/19/20 8:51 PM, David Ahern wrote: > On 11/17/20 5:46 PM, Andreas Roeseler wrote: >> The popular utility ping has several severe limitations such as the >> inability to query specific interfaces on a node and requiring >> bidirectional connectivity between the probing and the probed >> interfaces. RFC8335 attempts to solve these limitations by creating the >> new utility PROBE which is a specialized ICMP message that makes use of >> the ICMP Extension Structure outlined in RFC4884. >> >> This patchset adds definitions for the ICMP Extended Echo Request and >> Reply (PROBE) types for both IPv4 and IPv6. It also expands the list of >> supported ICMP messages to accommodate PROBEs. >> > > You are updating the send, but what about the response side? > you also are not setting 'ICMP Extension Structure'. From: https://tools.ietf.org/html/rfc8335 o ICMP Extension Structure: The ICMP Extension Structure identifies the probed interface. Section 7 of [RFC4884] defines the ICMP Extension Structure. As per RFC 4884, the Extension Structure contains exactly one Extension Header followed by one or more objects. When applied to the ICMP Extended Echo Request message, the ICMP Extension Structure MUST contain exactly one instance of the Interface Identification Object (see Section 2.1).