From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1F4CC43381 for ; Mon, 18 Feb 2019 02:20:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 77C3E218D8 for ; Mon, 18 Feb 2019 02:20:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FJEQ9aKd" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728138AbfBRCU1 (ORCPT ); Sun, 17 Feb 2019 21:20:27 -0500 Received: from mail-yb1-f195.google.com ([209.85.219.195]:38677 "EHLO mail-yb1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727266AbfBRCU0 (ORCPT ); Sun, 17 Feb 2019 21:20:26 -0500 Received: by mail-yb1-f195.google.com with SMTP id f196so1322105yba.5 for ; Sun, 17 Feb 2019 18:20:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=QNGvWt3t3AH7kDTmfvNfxWHX88wRsAAY7ltupXq2z3A=; b=FJEQ9aKdnTJ2ZcTaiD83yijoos3JBKoX6WPW1QrgaKuGwTSPDhdQktxSjkTTItVx+w xSR6hwDblcYcFK57LFrWWwxGczqnTyygokQf8+7X8kybLhn/f3LCmsweKfNfbShN7+8w rb1KJ6sO12Q5dBd75lTHGNzMs51Pc250GQSlWYcQi3nevHfbTA6dbI7BqhDTR0u15Cty hbzmoEOThQsuIGsHKg78vAlCNewPappKgMIHmQRgrgeq2rs9Aywb8z4K/4JdJ69zOQvY 0mfQwL4g6t0Ome6IWYVCIVTq6QWDqsu9lcIw29dIXdTMl2O2f2Y5kgTzV6ndw2OKo9dQ fhGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=QNGvWt3t3AH7kDTmfvNfxWHX88wRsAAY7ltupXq2z3A=; b=QZX9rQEjeirQXIeXUc+q56hwzkKbSZeZMIoUB3josLLEzQqMNTTyxaluxkoGHDv21M 1DrJYmDvlxSrLjdW9Gh2coUyozJs1/j07j1GOhYcWnGQjofhtMsBbS6INzjJyhEOUc3h PBC7OXyaElcmCw4dn0xFvXgI/dq6u1Jh56QyW/2cH0RDbwhr4mpdH4MXnqKMOHwHehua vqkQaTCnZovfeDztcE+u1NN9X6syPtVOf+fUg+m5xGOxF5m/atp8rydIHZQUUS5nHXY1 UzNCAQ06I1SG89GEa+YyDbNXPTWx465e5cjagsYvKCyFji2xQ23L3IMGs8nVB3DhxBki RYzg== X-Gm-Message-State: AHQUAuYJALTiG/eRpJG7SDiiv89lGLOW0zdns4pP/Ti+rNFL6lFiRUsW gp4qEL1lEQ5qxauOlv7UvZ9N3MHJ X-Google-Smtp-Source: AHgI3Ib3EMkf+Hwipp9HQv8c9SFpBtnsLdjnG8aXK5dbzoz8r8tWXOsc2QMG5Rrw1xXFrhfv9KM6Sg== X-Received: by 2002:a25:b09:: with SMTP id 9mr17212378ybl.94.1550456426018; Sun, 17 Feb 2019 18:20:26 -0800 (PST) Received: from [192.168.86.235] (c-73-241-150-70.hsd1.ca.comcast.net. [73.241.150.70]) by smtp.gmail.com with ESMTPSA id b188sm6277706ywa.58.2019.02.17.18.20.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 17 Feb 2019 18:20:23 -0800 (PST) Subject: Re: [PATCH net 0/2] tcp: fix possible crash in tcp_v4_err() To: David Miller , edumazet@google.com Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com, ncardwell@google.com, ycheng@google.com, soukjin.bae@samsung.com References: <20190215213621.183537-1-edumazet@google.com> <20190217.154720.1503278506915285087.davem@davemloft.net> From: Eric Dumazet Message-ID: <8e6280f3-ea5b-48bd-4dc0-da134d4125d2@gmail.com> Date: Sun, 17 Feb 2019 18:20:21 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190217.154720.1503278506915285087.davem@davemloft.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 02/17/2019 03:47 PM, David Miller wrote: > From: Eric Dumazet > Date: Fri, 15 Feb 2019 13:36:19 -0800 > >> soukjin bae reported a crash in tcp_v4_err() that we >> root caused to a missing initialization. >> >> Second patch adds a sanity check in tcp_v4_err() to avoid >> future potential problems. Ignoring an ICMP message >> is probably better than crashing a machine. > > Series applied, thanks Eric. > > Want me to queue these up for -stable? > Yes please, I put no Fixes: tag because it seemed to be a day-0 bug. Thanks !