netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net-next] MAINTAINERS: Update XDP and AF_XDP entries
@ 2020-11-19 17:26 Jesper Dangaard Brouer
  2020-11-19 18:02 ` Jakub Kicinski
  0 siblings, 1 reply; 5+ messages in thread
From: Jesper Dangaard Brouer @ 2020-11-19 17:26 UTC (permalink / raw)
  To: bpf, Jakub Kicinski
  Cc: Jesper Dangaard Brouer, netdev, Daniel Borkmann,
	Alexei Starovoitov, John Fastabend, Magnus Karlsson,
	Björn Töpel

Getting too many false positive matches with current use
of the content regex K: and file regex N: patterns.

This patch drops file match N: and makes K: more restricted.
Some more normal F: file wildcards are added.

Notice that AF_XDP forgot to some F: files that is also
updated in this patch.

Suggested-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>
---
 MAINTAINERS |   12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index af9f6a3ab100..230917ee687f 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -19105,12 +19105,17 @@ L:	netdev@vger.kernel.org
 L:	bpf@vger.kernel.org
 S:	Supported
 F:	include/net/xdp.h
+F:	include/net/xdp_priv.h
 F:	include/trace/events/xdp.h
 F:	kernel/bpf/cpumap.c
 F:	kernel/bpf/devmap.c
 F:	net/core/xdp.c
-N:	xdp
-K:	xdp
+F:	samples/bpf/xdp*
+F:	tools/testing/selftests/bpf/*xdp*
+F:	tools/testing/selftests/bpf/*/*xdp*
+F:	drivers/net/ethernet/*/*/*/*/*xdp*
+F:	drivers/net/ethernet/*/*/*xdp*
+K:	[^a-z0-9]xdp[^a-z0-9]
 
 XDP SOCKETS (AF_XDP)
 M:	Björn Töpel <bjorn.topel@intel.com>
@@ -19119,9 +19124,12 @@ R:	Jonathan Lemon <jonathan.lemon@gmail.com>
 L:	netdev@vger.kernel.org
 L:	bpf@vger.kernel.org
 S:	Maintained
+F:	Documentation/networking/af_xdp.rst
 F:	include/net/xdp_sock*
 F:	include/net/xsk_buff_pool.h
 F:	include/uapi/linux/if_xdp.h
+F:	include/uapi/linux/xdp_diag.h
+F:	include/net/netns/xdp.h
 F:	net/xdp/
 F:	samples/bpf/xdpsock*
 F:	tools/lib/bpf/xsk*



^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH net-next] MAINTAINERS: Update XDP and AF_XDP entries
  2020-11-19 17:26 [PATCH net-next] MAINTAINERS: Update XDP and AF_XDP entries Jesper Dangaard Brouer
@ 2020-11-19 18:02 ` Jakub Kicinski
  2020-11-19 20:50   ` Jesper Dangaard Brouer
  0 siblings, 1 reply; 5+ messages in thread
From: Jakub Kicinski @ 2020-11-19 18:02 UTC (permalink / raw)
  To: Jesper Dangaard Brouer
  Cc: bpf, netdev, Daniel Borkmann, Alexei Starovoitov, John Fastabend,
	Magnus Karlsson, Björn Töpel, Joe Perches

On Thu, 19 Nov 2020 18:26:40 +0100 Jesper Dangaard Brouer wrote:
> Getting too many false positive matches with current use
> of the content regex K: and file regex N: patterns.
> 
> This patch drops file match N: and makes K: more restricted.
> Some more normal F: file wildcards are added.
> 
> Notice that AF_XDP forgot to some F: files that is also
> updated in this patch.
> 
> Suggested-by: Jakub Kicinski <kuba@kernel.org>
> Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>

Ah! Sorry, I missed that you sent this before replying to Joe.

Would you mind respining with his regex?

> diff --git a/MAINTAINERS b/MAINTAINERS
> index af9f6a3ab100..230917ee687f 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -19105,12 +19105,17 @@ L:	netdev@vger.kernel.org
>  L:	bpf@vger.kernel.org
>  S:	Supported
>  F:	include/net/xdp.h
> +F:	include/net/xdp_priv.h
>  F:	include/trace/events/xdp.h
>  F:	kernel/bpf/cpumap.c
>  F:	kernel/bpf/devmap.c
>  F:	net/core/xdp.c
> -N:	xdp
> -K:	xdp
> +F:	samples/bpf/xdp*
> +F:	tools/testing/selftests/bpf/*xdp*
> +F:	tools/testing/selftests/bpf/*/*xdp*
> +F:	drivers/net/ethernet/*/*/*/*/*xdp*
> +F:	drivers/net/ethernet/*/*/*xdp*
> +K:	[^a-z0-9]xdp[^a-z0-9]
> 
>  XDP SOCKETS (AF_XDP)
>  M:	Björn Töpel <bjorn.topel@intel.com>
> @@ -19119,9 +19124,12 @@ R:	Jonathan Lemon <jonathan.lemon@gmail.com>
>  L:	netdev@vger.kernel.org
>  L:	bpf@vger.kernel.org
>  S:	Maintained
> +F:	Documentation/networking/af_xdp.rst
>  F:	include/net/xdp_sock*
>  F:	include/net/xsk_buff_pool.h
>  F:	include/uapi/linux/if_xdp.h
> +F:	include/uapi/linux/xdp_diag.h
> +F:	include/net/netns/xdp.h
>  F:	net/xdp/
>  F:	samples/bpf/xdpsock*
>  F:	tools/lib/bpf/xsk*
> 
> 


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH net-next] MAINTAINERS: Update XDP and AF_XDP entries
  2020-11-19 18:02 ` Jakub Kicinski
@ 2020-11-19 20:50   ` Jesper Dangaard Brouer
  2020-11-19 22:16     ` Joe Perches
  0 siblings, 1 reply; 5+ messages in thread
From: Jesper Dangaard Brouer @ 2020-11-19 20:50 UTC (permalink / raw)
  To: Jakub Kicinski
  Cc: bpf, netdev, Daniel Borkmann, Alexei Starovoitov, John Fastabend,
	Magnus Karlsson, Björn Töpel, Joe Perches, brouer

On Thu, 19 Nov 2020 10:02:10 -0800
Jakub Kicinski <kuba@kernel.org> wrote:

> On Thu, 19 Nov 2020 18:26:40 +0100 Jesper Dangaard Brouer wrote:
> > Getting too many false positive matches with current use
> > of the content regex K: and file regex N: patterns.
> > 
> > This patch drops file match N: and makes K: more restricted.
> > Some more normal F: file wildcards are added.
> > 
> > Notice that AF_XDP forgot to some F: files that is also
> > updated in this patch.
> > 
> > Suggested-by: Jakub Kicinski <kuba@kernel.org>
> > Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>  
> 
> Ah! Sorry, I missed that you sent this before replying to Joe.
> 
> Would you mind respining with his regex?

Sure, I just send it... with your adjusted '(\b|_)xdp(\b|_)' regex, as
it seems to do the same thing (and it works with egrep).

-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  LinkedIn: http://www.linkedin.com/in/brouer


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH net-next] MAINTAINERS: Update XDP and AF_XDP entries
  2020-11-19 20:50   ` Jesper Dangaard Brouer
@ 2020-11-19 22:16     ` Joe Perches
  2020-11-20  8:47       ` Jesper Dangaard Brouer
  0 siblings, 1 reply; 5+ messages in thread
From: Joe Perches @ 2020-11-19 22:16 UTC (permalink / raw)
  To: Jesper Dangaard Brouer, Jakub Kicinski
  Cc: bpf, netdev, Daniel Borkmann, Alexei Starovoitov, John Fastabend,
	Magnus Karlsson, Björn Töpel

On Thu, 2020-11-19 at 21:50 +0100, Jesper Dangaard Brouer wrote:
> On Thu, 19 Nov 2020 10:02:10 -0800
> Jakub Kicinski <kuba@kernel.org> wrote:
> 
> > On Thu, 19 Nov 2020 18:26:40 +0100 Jesper Dangaard Brouer wrote:
> > > Getting too many false positive matches with current use
> > > of the content regex K: and file regex N: patterns.
> > > 
> > > This patch drops file match N: and makes K: more restricted.
> > > Some more normal F: file wildcards are added.
> > > 
> > > Notice that AF_XDP forgot to some F: files that is also
> > > updated in this patch.
> > > 
> > > Suggested-by: Jakub Kicinski <kuba@kernel.org>
> > > Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>  
> > 
> > Ah! Sorry, I missed that you sent this before replying to Joe.
> > 
> > Would you mind respining with his regex?
> 
> Sure, I just send it... with your adjusted '(\b|_)xdp(\b|_)' regex, as
> it seems to do the same thing (and it works with egrep).

The regexes in MAINTAINERS are perl not egrep and using (\b|_)
creates unnecessary capture groups.

It _really_ should be (?:\b|_)xdp(?:\b|_)

 



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH net-next] MAINTAINERS: Update XDP and AF_XDP entries
  2020-11-19 22:16     ` Joe Perches
@ 2020-11-20  8:47       ` Jesper Dangaard Brouer
  0 siblings, 0 replies; 5+ messages in thread
From: Jesper Dangaard Brouer @ 2020-11-20  8:47 UTC (permalink / raw)
  To: Joe Perches
  Cc: Jakub Kicinski, bpf, netdev, Daniel Borkmann, Alexei Starovoitov,
	John Fastabend, Magnus Karlsson, Björn Töpel, brouer

On Thu, 19 Nov 2020 14:16:20 -0800
Joe Perches <joe@perches.com> wrote:

> On Thu, 2020-11-19 at 21:50 +0100, Jesper Dangaard Brouer wrote:
> > On Thu, 19 Nov 2020 10:02:10 -0800
> > Jakub Kicinski <kuba@kernel.org> wrote:
> >   
> > > On Thu, 19 Nov 2020 18:26:40 +0100 Jesper Dangaard Brouer wrote:  
> > > > Getting too many false positive matches with current use
> > > > of the content regex K: and file regex N: patterns.
> > > > 
> > > > This patch drops file match N: and makes K: more restricted.
> > > > Some more normal F: file wildcards are added.
> > > > 
> > > > Notice that AF_XDP forgot to some F: files that is also
> > > > updated in this patch.
> > > > 
> > > > Suggested-by: Jakub Kicinski <kuba@kernel.org>
> > > > Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>    
> > > 
> > > Ah! Sorry, I missed that you sent this before replying to Joe.
> > > 
> > > Would you mind respining with his regex?  
> > 
> > Sure, I just send it... with your adjusted '(\b|_)xdp(\b|_)' regex, as
> > it seems to do the same thing (and it works with egrep).  
> 
> The regexes in MAINTAINERS are perl not egrep and using (\b|_)
> creates unnecessary capture groups.
> 
> It _really_ should be (?:\b|_)xdp(?:\b|_)

Okay, I will send a V3 patch.

I was trying to write a perl oneliner to tests this, but I realized
that git-grep supports this directly via --perl-regexp.

$ time git grep --files-with-matches --perl-regexp '(\b|_)xdp(\b|_)' | wc -l
297

real	0m2,225s
user	0m0,832s
sys	0m2,762s

$ time git grep --files-with-matches --perl-regexp '(?:\b|_)xdp(?:\b|_)' | wc -l
297

real	0m2,261s
user	0m0,788s
sys	0m2,714s


-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  LinkedIn: http://www.linkedin.com/in/brouer


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-11-20  8:48 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-19 17:26 [PATCH net-next] MAINTAINERS: Update XDP and AF_XDP entries Jesper Dangaard Brouer
2020-11-19 18:02 ` Jakub Kicinski
2020-11-19 20:50   ` Jesper Dangaard Brouer
2020-11-19 22:16     ` Joe Perches
2020-11-20  8:47       ` Jesper Dangaard Brouer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).