Re: Driver support for Realtek RTL8125 2.5GB Ethernet

From: Heiner Kallweit <hkallweit1@gmail.com>
To: Jian-Hong Pan <jian-hong@endlessm.com>
Cc: Linux Netdev List <netdev@vger.kernel.org>,
	Yan-Hsuan Chuang <yhchuang@realtek.com>,
	Linux Upstreaming Team <linux@endlessm.com>
Subject: Re: Driver support for Realtek RTL8125 2.5GB Ethernet
Date: Wed, 2 Oct 2019 23:03:27 +0200	[thread overview]
Message-ID: <9089b373-da45-c34c-4dbe-5c916edfb419@gmail.com> (raw)
In-Reply-To: <CAPpJ_efajCONc=7LaUdGftEpKpnpSMXn8YBE6=epJ57fF_WekA@mail.gmail.com>

On 02.10.2019 12:22, Jian-Hong Pan wrote:
> Heiner Kallweit <hkallweit1@gmail.com> 於 2019年10月2日 週三 下午1:54寫道：
>>
>> On 26.07.2019 21:05, Heiner Kallweit wrote:
>>> On 24.07.2019 22:02, Heiner Kallweit wrote:
>>>> On 24.07.2019 10:19, Jian-Hong Pan wrote:
>>>>> Hi all,
>>>>>
>>>>> We have got a consumer desktop equipped with Realtek RTL8125 2.5GB
>>>>> Ethernet [1] recently.  But, there is no related driver in mainline
>>>>> kernel yet.  So, we can only use the vendor driver [2] and customize
>>>>> it [3] right now.
>>>>>
>>>>> Is anyone working on an upstream driver for this hardware?
>>>>>
>>>> At least I'm not aware of any such work. Issue with Realtek is that
>>>> they answer individual questions very quickly but company policy is
>>>> to not release any datasheets or errata documentation.
>>>> RTL8169 inherited a lot from RTL8139, so I would expect that the
>>>> r8169 driver could be a good basis for a RTL8125 mainline driver.
>>>>
>>> Meanwhile I had a look at the RTL8125 vendor driver. Most parts are
>>> quite similar to RTL8168. However the PHY handling is quite weird.
>>> 2.5Gbps isn't covered by Clause 22, but instead of switching to
>>> Clause 45 Realtek uses Clause 22 plus a proprietary chip register
>>> (for controlling the 2.5Gbps mode) that doesn't seem to be accessible
>>> via MDIO bus. This may make using phylib tricky.
>>>
>> In case you haven't seen it yet: Meanwhile I added RTL8125 support to
>> phylib and r8169, it's included in 5.4-rc1. I tested it on a
>> RTL8125-based PCIe add-on card, feedback from your system would be
>> appreciated. Note that you also need latest linux-firmware package
>> from Sep 23rd.
> 
> Thank you!!!
> 
> I tried kernel 5.4.0-rc1 on the desktop equipped with Realtek RTL8125
> 2.5GB Ethernet.
> 
> $ sudo lspci -nnvs 04:00.0
> [sudo] password for dev:
> 04:00.0 Ethernet controller [0200]: Realtek Semiconductor Co., Ltd.
> Device [10ec:8125] (rev 01)
>     Subsystem: Acer Incorporated [ALI] Device [1025:1354]
>     Flags: bus master, fast devsel, latency 0, IRQ 17
>     I/O ports at 3000 [size=256]
>     Memory at a4200000 (64-bit, non-prefetchable) [size=64K]
>     Memory at a4210000 (64-bit, non-prefetchable) [size=16K]
>     Capabilities: [40] Power Management version 3
>     Capabilities: [50] MSI: Enable- Count=1/1 Maskable+ 64bit+
>     Capabilities: [70] Express Endpoint, MSI 01
>     Capabilities: [b0] MSI-X: Enable+ Count=4 Masked-
>     Capabilities: [d0] Vital Product Data
>     Capabilities: [100] Advanced Error Reporting
>     Capabilities: [148] Virtual Channel
>     Capabilities: [168] Device Serial Number 01-00-00-00-68-4c-e0-00
>     Capabilities: [178] Alternative Routing-ID Interpretation (ARI)
>     Capabilities: [188] Single Root I/O Virtualization (SR-IOV)
>     Capabilities: [1c8] Transaction Processing Hints
>     Capabilities: [254] Latency Tolerance Reporting
>     Capabilities: [25c] L1 PM Substates
>     Capabilities: [26c] Vendor Specific Information: ID=0002 Rev=4 Len=100 <?>
>     Kernel driver in use: r8169
>     Kernel modules: r8169
> 
> Module r8169 works for it.
> 
Thanks for the prompt test and feedback!

> $ dmesg | grep r8169
> [   19.631623] libphy: r8169: probed
> [   19.631978] r8169 0000:04:00.0 eth0: RTL8125, 94:c6:91:5f:1f:45,
> XID 609, IRQ 127
> [   19.631983] r8169 0000:04:00.0 eth0: jumbo features [frames: 9200
> bytes, tx checksumming: ko]
> [   19.635492] r8169 0000:04:00.0 enp4s0: renamed from eth0
> [   21.778431] RTL8125 2.5Gbps internal r8169-400:00: attached PHY
> driver [RTL8125 2.5Gbps internal] (mii_bus:phy_addr=r8169-400:00,
> irq=IGNORE)
> [   21.871953] r8169 0000:04:00.0 enp4s0: Link is Down
> [   24.668516] r8169 0000:04:00.0 enp4s0: Link is Up - 1Gbps/Full -
> flow control off
> 
> Jian-Hong Pan
> 
>>>>> [1] https://www.realtek.com/en/press-room/news-releases/item/realtek-launches-world-s-first-single-chip-2-5g-ethernet-controller-for-multiple-applications-including-gaming-solution
>>>>> [2] https://www.realtek.com/en/component/zoo/category/network-interface-controllers-10-100-1000m-gigabit-ethernet-pci-express-software
>>>>> [3] https://github.com/endlessm/linux/commit/da1e43f58850d272eb72f571524ed71fd237d32b
>>>>>
>>>>> Jian-Hong Pan
>>>>>
>>>> Heiner
>>>>
>>> Heiner
>>>
>> Heiner
>