From: Mat Martineau <mathew.j.martineau@linux.intel.com>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: Networking <netdev@vger.kernel.org>, bpf <bpf@vger.kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
mptcp@lists.linux.dev
Subject: Re: [PATCH bpf-next v3 0/8] bpf: mptcp: Support for mptcp_sock and is_mptcp
Date: Fri, 6 May 2022 16:06:09 -0700 (PDT) [thread overview]
Message-ID: <90f2f50-493e-8949-ea96-9fb6df9b263@linux.intel.com> (raw)
In-Reply-To: <CAEf4BzY3wtCJa5O-k6e1qmJvu5-WBuq5p6=oBJWdCC5tj17LyA@mail.gmail.com>
On Fri, 6 May 2022, Andrii Nakryiko wrote:
> On Mon, May 2, 2022 at 2:12 PM Mat Martineau
> <mathew.j.martineau@linux.intel.com> wrote:
>>
>> This patch set adds BPF access to the is_mptcp flag in tcp_sock and
>> access to mptcp_sock structures, along with associated self tests. You
>> may recognize some of the code from earlier
>> (https://lore.kernel.org/bpf/20200918121046.190240-6-nicolas.rybowski@tessares.net/)
>> but it has been reworked quite a bit.
>>
>>
>> v1 -> v2: Emit BTF type, add func_id checks in verifier.c and bpf_trace.c,
>> remove build check for CONFIG_BPF_JIT, add selftest check for CONFIG_MPTCP,
>> and add a patch to include CONFIG_IKCONFIG/CONFIG_IKCONFIG_PROC for the
>> BPF self tests.
>>
>> v2 -> v3: Access sysctl through the filesystem to work around CI use of
>> the more limited busybox sysctl command.
>>
>>
>> Geliang Tang (6):
>> bpf: add bpf_skc_to_mptcp_sock_proto
>> selftests: bpf: Enable CONFIG_IKCONFIG_PROC in config
>> selftests: bpf: test bpf_skc_to_mptcp_sock
>> selftests: bpf: verify token of struct mptcp_sock
>> selftests: bpf: verify ca_name of struct mptcp_sock
>> selftests: bpf: verify first of struct mptcp_sock
>>
>
> It would be nice to use more consistent with the majority of other
> commits "selftests/bpf: " prefix. Thank you.
Sure, we'll update those prefixes and address your comments in the
individual patches. Thanks for the review.
- Mat
>
>> Nicolas Rybowski (2):
>> bpf: expose is_mptcp flag to bpf_tcp_sock
>> selftests: bpf: add MPTCP test base
>>
>> MAINTAINERS | 2 +
>> include/linux/bpf.h | 1 +
>> include/linux/btf_ids.h | 3 +-
>> include/net/mptcp.h | 6 +
>> include/uapi/linux/bpf.h | 8 +
>> kernel/bpf/verifier.c | 1 +
>> kernel/trace/bpf_trace.c | 2 +
>> net/core/filter.c | 27 +-
>> net/mptcp/Makefile | 2 +
>> net/mptcp/bpf.c | 22 ++
>> scripts/bpf_doc.py | 2 +
>> tools/include/uapi/linux/bpf.h | 8 +
>> .../testing/selftests/bpf/bpf_mptcp_helpers.h | 17 ++
>> tools/testing/selftests/bpf/bpf_tcp_helpers.h | 4 +
>> tools/testing/selftests/bpf/config | 3 +
>> tools/testing/selftests/bpf/network_helpers.c | 43 ++-
>> tools/testing/selftests/bpf/network_helpers.h | 4 +
>> .../testing/selftests/bpf/prog_tests/mptcp.c | 272 ++++++++++++++++++
>> .../testing/selftests/bpf/progs/mptcp_sock.c | 80 ++++++
>> 19 files changed, 497 insertions(+), 10 deletions(-)
>> create mode 100644 net/mptcp/bpf.c
>> create mode 100644 tools/testing/selftests/bpf/bpf_mptcp_helpers.h
>> create mode 100644 tools/testing/selftests/bpf/prog_tests/mptcp.c
>> create mode 100644 tools/testing/selftests/bpf/progs/mptcp_sock.c
>>
>>
>> base-commit: 20b87e7c29dffcfa3f96f2e99daec84fd46cabdb
>> --
>> 2.36.0
>>
>
--
Mat Martineau
Intel
prev parent reply other threads:[~2022-05-06 23:06 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-02 21:12 [PATCH bpf-next v3 0/8] bpf: mptcp: Support for mptcp_sock and is_mptcp Mat Martineau
2022-05-02 21:12 ` [PATCH bpf-next v3 1/8] bpf: expose is_mptcp flag to bpf_tcp_sock Mat Martineau
2022-05-11 0:48 ` Martin KaFai Lau
2022-05-11 5:02 ` Andrii Nakryiko
2022-05-11 6:10 ` Geliang Tang
2022-05-02 21:12 ` [PATCH bpf-next v3 2/8] bpf: add bpf_skc_to_mptcp_sock_proto Mat Martineau
2022-05-02 21:12 ` [PATCH bpf-next v3 3/8] selftests: bpf: Enable CONFIG_IKCONFIG_PROC in config Mat Martineau
2022-05-06 22:25 ` Andrii Nakryiko
2022-05-02 21:12 ` [PATCH bpf-next v3 4/8] selftests: bpf: add MPTCP test base Mat Martineau
2022-05-06 22:24 ` Andrii Nakryiko
2022-05-02 21:12 ` [PATCH bpf-next v3 5/8] selftests: bpf: test bpf_skc_to_mptcp_sock Mat Martineau
2022-05-06 22:26 ` Andrii Nakryiko
2022-05-09 9:00 ` Matthieu Baerts
2022-05-09 21:00 ` Andrii Nakryiko
2022-05-10 13:48 ` Matthieu Baerts
2022-05-02 21:12 ` [PATCH bpf-next v3 6/8] selftests: bpf: verify token of struct mptcp_sock Mat Martineau
2022-05-02 22:14 ` Mat Martineau
2022-05-06 22:27 ` Andrii Nakryiko
2022-05-10 21:59 ` Mat Martineau
2022-05-10 23:58 ` Andrii Nakryiko
2022-05-02 21:12 ` [PATCH bpf-next v3 7/8] selftests: bpf: verify ca_name " Mat Martineau
2022-05-02 21:12 ` [PATCH bpf-next v3 8/8] selftests: bpf: verify first " Mat Martineau
2022-05-06 22:28 ` [PATCH bpf-next v3 0/8] bpf: mptcp: Support for mptcp_sock and is_mptcp Andrii Nakryiko
2022-05-06 23:06 ` Mat Martineau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90f2f50-493e-8949-ea96-9fb6df9b263@linux.intel.com \
--to=mathew.j.martineau@linux.intel.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=mptcp@lists.linux.dev \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).