From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: "Gustavo A. R. Silva" <gustavoars@kernel.org>,
Vlad Yasevich <vyasevich@gmail.com>,
Neil Horman <nhorman@tuxdriver.com>,
Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>
Cc: linux-sctp@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH RESEND][next] sctp: Fix fall-through warnings for Clang
Date: Tue, 20 Apr 2021 15:09:24 -0500 [thread overview]
Message-ID: <91fcca0d-c986-f88e-4a0d-4590de6a5985@embeddedor.com> (raw)
In-Reply-To: <20210305090717.GA139387@embeddedor>
Hi all,
Friendly ping: who can take this, please?
Thanks
--
Gustavo
On 3/5/21 03:07, Gustavo A. R. Silva wrote:
> In preparation to enable -Wimplicit-fallthrough for Clang, fix a couple
> of warnings by explicitly adding a break statement and replacing a
> comment with a goto statement instead of letting the code fall through
> to the next case.
>
> Link: https://github.com/KSPP/linux/issues/115
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> ---
> net/sctp/input.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/net/sctp/input.c b/net/sctp/input.c
> index d508f6f3dd08..5ceaf75105ba 100644
> --- a/net/sctp/input.c
> +++ b/net/sctp/input.c
> @@ -633,7 +633,7 @@ int sctp_v4_err(struct sk_buff *skb, __u32 info)
> break;
> case ICMP_REDIRECT:
> sctp_icmp_redirect(sk, transport, skb);
> - /* Fall through to out_unlock. */
> + goto out_unlock;
> default:
> goto out_unlock;
> }
> @@ -1236,6 +1236,7 @@ static struct sctp_association *__sctp_rcv_walk_lookup(struct net *net,
> net, ch, laddr,
> sctp_hdr(skb)->source,
> transportp);
> + break;
> default:
> break;
> }
>
next prev parent reply other threads:[~2021-04-20 20:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-05 9:07 [PATCH RESEND][next] sctp: Fix fall-through warnings for Clang Gustavo A. R. Silva
2021-04-20 20:09 ` Gustavo A. R. Silva [this message]
2021-04-20 20:19 ` Marcelo Ricardo Leitner
2021-05-18 1:07 ` Gustavo A. R. Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91fcca0d-c986-f88e-4a0d-4590de6a5985@embeddedor.com \
--to=gustavo@embeddedor.com \
--cc=davem@davemloft.net \
--cc=gustavoars@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sctp@vger.kernel.org \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=vyasevich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).