From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7DF606FC3 for ; Mon, 5 Jun 2023 13:33:17 +0000 (UTC) Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC741E8 for ; Mon, 5 Jun 2023 06:33:14 -0700 (PDT) Received: by mail-ed1-x536.google.com with SMTP id 4fb4d7f45d1cf-51494659d49so7331681a12.3 for ; Mon, 05 Jun 2023 06:33:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1685971993; x=1688563993; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=5td0n1OvHthGT+rYvOKyDnfAlYftJUri63KAdUFjjX4=; b=GpGf+ZAHiKw5CeQROXmI7BXdxSJGNiH6ruouE6v57AAxj+pC7fiI3+8CpMO9kFwcuK iNPforeiEAMnIoXrJb1EZXYUwFVEQsMvAFZkRmdW4c6d7Ip5H2M84h4qjp28RNoKT/uR OMvw3dnaWEEsqky8/DMhbQDm3Dsq7CCeoTGvCohAFJHyuEpp50e4Fo1TnExn+9D1abNt yajUtClSURN7C9lC3mZLhrGfJU0b0OgOLcMpbvA1zwlYAnhP8/WbrPygdy0+2cSUmaEx cT4Bxbl2xDd0SYvFRMnYy68yKURwQTcIzWrbpmgGCdpvma6EImClRdauQWMvOD7TS0q4 JdkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685971993; x=1688563993; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5td0n1OvHthGT+rYvOKyDnfAlYftJUri63KAdUFjjX4=; b=BocKhl9eTr9JcFe0WYLHCmogKHNGBYLBbmBjmK6X/4dwynlsYTVSq3jnOIms8x8Fl7 jKLuXCpYsFXztFpaJ32D4L7opjUq+/mzinFfegOu3TZg9u09lsiaB1cgTuW/Hs2yIK+K iYHXQkoIBqlCew+ZcrXHLEgwVtqeQeDyPcNcm3+Z4zCxMarf1lVjEyNBBhgV4pg6JhEd BS15x2yh7l4WbuMmiTVTbQ6MK2a0DQgy9bGAV2AKxBtl9RXGbrRtWXqUlINktYyT8xEd m6n8uJkRu06Jg2+37HVkIAfqR89ONT0Qp7AXS87wL1r0gZY0MpJUxmFlr7HCHQV14pNR wmJw== X-Gm-Message-State: AC+VfDzLwuGI8PWbqqYjD1O2YrTFVxbZ+nms9sA0orwOpQXjwQ5NwtoO jvGmFJKeNWAloMfeNL5VnbuahA== X-Google-Smtp-Source: ACHHUZ7i0dZuu2ejZXYkgJWGy7Hr2iBDXk7V3bsNPClqMUut+YnNpuZvBzrBR+n5kZfawV9IaK5Sng== X-Received: by 2002:a17:907:7e87:b0:968:1e8:a754 with SMTP id qb7-20020a1709077e8700b0096801e8a754mr6829413ejc.72.1685971993350; Mon, 05 Jun 2023 06:33:13 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id l18-20020a1709067d5200b0096a27dbb5b2sm4196195ejp.209.2023.06.05.06.33.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Jun 2023 06:33:12 -0700 (PDT) Message-ID: <9296f953-62d9-fd77-ffcb-42dbbcdcc77f@linaro.org> Date: Mon, 5 Jun 2023 15:33:09 +0200 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH 17/21] power: reset: at91-poweroff: lookup for proper pmc dt node for sam9x7 Content-Language: en-US To: Nicolas Ferre , Varshini Rajendran , tglx@linutronix.de, maz@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, alexandre.belloni@bootlin.com, claudiu.beznea@microchip.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, gregkh@linuxfoundation.org, linux@armlinux.org.uk, mturquette@baylibre.com, sboyd@kernel.org, sre@kernel.org, broonie@kernel.org, arnd@arndb.de, gregory.clement@bootlin.com, sudeep.holla@arm.com, balamanikandan.gunasundar@microchip.com, mihai.sain@microchip.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-clk@vger.kernel.org, linux-pm@vger.kernel.org Cc: Hari.PrasathGE@microchip.com, cristian.birsan@microchip.com, durai.manickamkr@microchip.com, manikandan.m@microchip.com, dharma.b@microchip.com, nayabbasha.sayed@microchip.com, balakrishnan.s@microchip.com References: <20230603200243.243878-1-varshini.rajendran@microchip.com> <20230603200243.243878-18-varshini.rajendran@microchip.com> <2a538004-351f-487a-361c-df723d186c27@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On 05/06/2023 15:04, Nicolas Ferre wrote: > On 05/06/2023 at 08:43, Krzysztof Kozlowski wrote: >> On 03/06/2023 22:02, Varshini Rajendran wrote: >>> Use sam9x7 pmc's compatible to lookup for in the SHDWC driver >>> >>> Signed-off-by: Varshini Rajendran >>> --- >>> drivers/power/reset/at91-sama5d2_shdwc.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/drivers/power/reset/at91-sama5d2_shdwc.c b/drivers/power/reset/at91-sama5d2_shdwc.c >>> index d8ecffe72f16..d0f29b99f25e 100644 >>> --- a/drivers/power/reset/at91-sama5d2_shdwc.c >>> +++ b/drivers/power/reset/at91-sama5d2_shdwc.c >>> @@ -326,6 +326,7 @@ static const struct of_device_id at91_pmc_ids[] = { >>> { .compatible = "atmel,sama5d2-pmc" }, >>> { .compatible = "microchip,sam9x60-pmc" }, >>> { .compatible = "microchip,sama7g5-pmc" }, >>> + { .compatible = "microchip,sam9x7-pmc" }, >> >> Why do you need new entry if these are compatible? > > Yes, PMC is very specific to a SoC silicon. As we must look for it in > the shutdown controller, I think we need a new entry here. ??? How does it answer to my question at all? What is exactly specific which warrants new entry? Best regards, Krzysztof