From: Daniel Borkmann <daniel@iogearbox.net>
To: Song Liu <song@kernel.org>,
Matthieu Baerts <matthieu.baerts@tessares.net>
Cc: Alexei Starovoitov <alexei.starovoitov@gmail.com>,
Andrii Nakryiko <andriin@fb.com>,
Alexei Starovoitov <ast@kernel.org>, bpf <bpf@vger.kernel.org>,
"David S . Miller" <davem@davemloft.net>,
fejes@inf.elte.hu, John Fastabend <john.fastabend@gmail.com>,
Martin KaFai Lau <kafai@fb.com>, KP Singh <kpsingh@chromium.org>,
Jakub Kicinski <kuba@kernel.org>,
open list <linux-kernel@vger.kernel.org>,
Networking <netdev@vger.kernel.org>,
Song Liu <songliubraving@fb.com>, Yonghong Song <yhs@fb.com>
Subject: Re: [PATCH bpf v2] bpf: fix unused-var without NETDEVICES
Date: Thu, 4 Jun 2020 22:53:37 +0200 [thread overview]
Message-ID: <94837ee2-3dcc-41ef-e932-0c6d1285156d@iogearbox.net> (raw)
In-Reply-To: <CAPhsuW6HtiLQdvyK8tHEH80xeurvQqdaYpFgdhd=yb5hDkB7VA@mail.gmail.com>
On 6/3/20 10:45 PM, Song Liu wrote:
> On Wed, Jun 3, 2020 at 12:05 PM Matthieu Baerts
> <matthieu.baerts@tessares.net> wrote:
>>
>> A recent commit added new variables only used if CONFIG_NETDEVICES is
>> set. A simple fix would be to only declare these variables if the same
>> condition is valid but Alexei suggested an even simpler solution:
>>
>> since CONFIG_NETDEVICES doesn't change anything in .h I think the
>> best is to remove #ifdef CONFIG_NETDEVICES from net/core/filter.c
>> and rely on sock_bindtoindex() returning ENOPROTOOPT in the extreme
>> case of oddly configured kernels.
>>
>> Fixes: 70c58997c1e8 ("bpf: Allow SO_BINDTODEVICE opt in bpf_setsockopt")
>> Suggested-by: Alexei Starovoitov <alexei.starovoitov@gmail.com>
>> Signed-off-by: Matthieu Baerts <matthieu.baerts@tessares.net>
>
> Acked-by: Song Liu <songliubraving@fb.com>
Applied, thanks!
next prev parent reply other threads:[~2020-06-04 20:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-03 8:11 [PATCH bpf] bpf: fix unused-var without NETDEVICES Matthieu Baerts
2020-06-03 8:56 ` Ferenc Fejes
2020-06-03 9:12 ` Matthieu Baerts
2020-06-03 18:14 ` Alexei Starovoitov
2020-06-03 18:41 ` Matthieu Baerts
2020-06-03 18:43 ` Alexei Starovoitov
2020-06-03 19:03 ` [PATCH bpf v2] " Matthieu Baerts
2020-06-03 20:45 ` Song Liu
2020-06-04 20:53 ` Daniel Borkmann [this message]
2020-06-03 18:59 ` [PATCH bpf] " Ferenc Fejes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94837ee2-3dcc-41ef-e932-0c6d1285156d@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=alexei.starovoitov@gmail.com \
--cc=andriin@fb.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=fejes@inf.elte.hu \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kpsingh@chromium.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthieu.baerts@tessares.net \
--cc=netdev@vger.kernel.org \
--cc=song@kernel.org \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).