From: "Eelco Chaudron" <echaudro@redhat.com>
To: "Jakub Kicinski" <kuba@kernel.org>
Cc: netdev@vger.kernel.org, davem@davemloft.net, dev@openvswitch.org,
pabeni@redhat.com, pshelar@ovn.org
Subject: Re: [PATCH net-next 2/2] net: openvswitch: make masks cache size configurable
Date: Wed, 22 Jul 2020 17:31:37 +0200 [thread overview]
Message-ID: <967448E7-939A-4E3F-8D59-DC0F780C8D09@redhat.com> (raw)
In-Reply-To: <20200722082128.53cf22e2@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On 22 Jul 2020, at 17:21, Jakub Kicinski wrote:
> On Wed, 22 Jul 2020 10:27:52 +0200 Eelco Chaudron wrote:
>> This patch makes the masks cache size configurable, or with
>> a size of 0, disable it.
>>
>> Reviewed-by: Paolo Abeni <pabeni@redhat.com>
>> Signed-off-by: Eelco Chaudron <echaudro@redhat.com>
>
> Hi Elco!
>
> This patch adds a bunch of new sparse warnings:
>
> net/openvswitch/flow_table.c:376:23: warning: incorrect type in
> assignment (different address spaces)
> net/openvswitch/flow_table.c:376:23: expected struct
> mask_cache_entry *cache
> net/openvswitch/flow_table.c:376:23: got void [noderef] __percpu *
> net/openvswitch/flow_table.c:386:25: warning: incorrect type in
> assignment (different address spaces)
> net/openvswitch/flow_table.c:386:25: expected struct
> mask_cache_entry [noderef] __percpu *mask_cache
> net/openvswitch/flow_table.c:386:25: got struct mask_cache_entry
> *cache
> net/openvswitch/flow_table.c:411:27: warning: incorrect type in
> assignment (different address spaces)
> net/openvswitch/flow_table.c:411:27: expected struct mask_cache
> [noderef] __rcu *mask_cache
> net/openvswitch/flow_table.c:411:27: got struct mask_cache *
> net/openvswitch/flow_table.c:440:35: warning: incorrect type in
> argument 1 (different address spaces)
> net/openvswitch/flow_table.c:440:35: expected struct mask_cache *mc
> net/openvswitch/flow_table.c:440:35: got struct mask_cache
> [noderef] __rcu *mask_cache
Odd, as I’m sure I ran checkpatch :( Will sent an update fixing those!
next prev parent reply other threads:[~2020-07-22 15:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-22 8:27 [PATCH net-next 0/2] net: openvswitch: masks cache enhancements Eelco Chaudron
2020-07-22 8:27 ` [PATCH net-next 1/2] net: openvswitch: add masks cache hit counter Eelco Chaudron
2020-07-22 8:27 ` [PATCH net-next 2/2] net: openvswitch: make masks cache size configurable Eelco Chaudron
2020-07-22 15:21 ` Jakub Kicinski
2020-07-22 15:31 ` Eelco Chaudron [this message]
2020-07-22 17:40 ` kernel test robot
2020-07-22 19:22 ` Florian Westphal
2020-07-23 9:59 ` Eelco Chaudron
2020-07-23 10:15 ` Florian Westphal
2020-07-22 8:37 ` [PATCH net-next 0/2] net: openvswitch: masks cache enhancements Eelco Chaudron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=967448E7-939A-4E3F-8D59-DC0F780C8D09@redhat.com \
--to=echaudro@redhat.com \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pshelar@ovn.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).