From: Florian Fainelli <f.fainelli@gmail.com>
To: Vladimir Oltean <olteanv@gmail.com>,
andrew@lunn.ch, vivien.didelot@gmail.com
Cc: davem@davemloft.net, kuba@kernel.org, jiri@mellanox.com,
idosch@idosch.org, rmk+kernel@armlinux.org.uk,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 net-next 04/15] net: dsa: sja1105: deny alterations of dsa_8021q VLANs from the bridge
Date: Mon, 11 May 2020 20:28:35 -0700 [thread overview]
Message-ID: <967cf2a8-6f23-b241-bc60-b431091b3a9b@gmail.com> (raw)
In-Reply-To: <20200511135338.20263-5-olteanv@gmail.com>
On 5/11/2020 6:53 AM, Vladimir Oltean wrote:
> From: Vladimir Oltean <vladimir.oltean@nxp.com>
>
> At the moment, this can never happen. The 2 modes that we operate in do
> not permit that:
>
> - SJA1105_VLAN_UNAWARE: we are guarded from bridge VLANs added by the
> user by the DSA core. We will later lift this restriction by setting
> ds->vlan_bridge_vtu = true, and that is where we'll need it.
>
> - SJA1105_VLAN_FILTERING_FULL: in this mode, dsa_8021q configuration is
> disabled. So the user is free to add these VLANs in the 1024-3071
> range.
>
> The reason for the patch is that we'll introduce a third VLAN awareness
> state, where both dsa_8021q as well as the bridge are going to call our
> .port_vlan_add and .port_vlan_del methods.
>
> For that, we need a good way to discriminate between the 2. The easiest
> (and less intrusive way for upper layers) is to recognize the fact that
> dsa_8021q configurations are always driven by our driver - we _know_
> when a .port_vlan_add method will be called from dsa_8021q because _we_
> initiated it.
>
> So introduce an expect_dsa_8021q boolean which is only used, at the
> moment, for blacklisting VLANs in range 1024-3071 in the modes when
> dsa_8021q is active.>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
next prev parent reply other threads:[~2020-05-12 3:28 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-11 13:53 [PATCH v2 net-next 00/15] Traffic support for dsa_8021q in vlan_filtering=1 mode Vladimir Oltean
2020-05-11 13:53 ` [PATCH v2 net-next 01/15] net: dsa: provide an option for drivers to always receive bridge VLANs Vladimir Oltean
2020-05-11 22:58 ` Florian Fainelli
2020-05-11 13:53 ` [PATCH v2 net-next 02/15] net: dsa: tag_8021q: introduce a vid_is_dsa_8021q helper Vladimir Oltean
2020-05-11 22:59 ` Florian Fainelli
2020-05-11 13:53 ` [PATCH v2 net-next 03/15] net: dsa: sja1105: keep the VLAN awareness state in a driver variable Vladimir Oltean
2020-05-11 22:59 ` kbuild test robot
2020-05-11 23:57 ` Vladimir Oltean
2020-05-12 3:26 ` Florian Fainelli
2020-05-11 13:53 ` [PATCH v2 net-next 04/15] net: dsa: sja1105: deny alterations of dsa_8021q VLANs from the bridge Vladimir Oltean
2020-05-12 3:28 ` Florian Fainelli [this message]
2020-05-11 13:53 ` [PATCH v2 net-next 05/15] net: dsa: sja1105: save/restore VLANs using a delta commit method Vladimir Oltean
2020-05-12 3:31 ` Florian Fainelli
2020-05-11 13:53 ` [PATCH v2 net-next 06/15] net: dsa: sja1105: allow VLAN configuration from the bridge in all states Vladimir Oltean
2020-05-12 3:25 ` Florian Fainelli
2020-05-11 13:53 ` [PATCH v2 net-next 07/15] net: dsa: sja1105: exit sja1105_vlan_filtering when called multiple times Vladimir Oltean
2020-05-12 3:32 ` Florian Fainelli
2020-05-11 13:53 ` [PATCH v2 net-next 08/15] net: dsa: sja1105: prepare tagger for handling DSA tags and VLAN simultaneously Vladimir Oltean
2020-05-12 3:34 ` Florian Fainelli
2020-05-11 13:53 ` [PATCH v2 net-next 09/15] net: dsa: tag_8021q: support up to 8 VLANs per port using sub-VLANs Vladimir Oltean
2020-05-12 3:35 ` Florian Fainelli
2020-05-11 13:53 ` [PATCH v2 net-next 10/15] net: dsa: tag_sja1105: implement sub-VLAN decoding Vladimir Oltean
2020-05-12 3:36 ` Florian Fainelli
2020-05-11 13:53 ` [PATCH v2 net-next 11/15] net: dsa: sja1105: add a new best_effort_vlan_filtering devlink parameter Vladimir Oltean
2020-05-12 3:37 ` Florian Fainelli
2020-05-11 13:53 ` [PATCH v2 net-next 12/15] net: dsa: sja1105: add packing ops for the Retagging Table Vladimir Oltean
2020-05-12 3:38 ` Florian Fainelli
2020-05-11 13:53 ` [PATCH v2 net-next 13/15] net: dsa: sja1105: implement a common frame memory partitioning function Vladimir Oltean
2020-05-12 3:39 ` Florian Fainelli
2020-05-11 13:53 ` [PATCH v2 net-next 14/15] net: dsa: sja1105: implement VLAN retagging for dsa_8021q sub-VLANs Vladimir Oltean
2020-05-12 3:41 ` Florian Fainelli
2020-05-11 13:53 ` [PATCH v2 net-next 15/15] docs: net: dsa: sja1105: document the best_effort_vlan_filtering option Vladimir Oltean
2020-05-12 3:43 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=967cf2a8-6f23-b241-bc60-b431091b3a9b@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=idosch@idosch.org \
--cc=jiri@mellanox.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).