From: Duan Fugang-B38611 <B38611@freescale.com>
To: Sean Cross <xobs@kosagi.com>
Cc: Sascha Hauer <s.hauer@pengutronix.de>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
David Miller <davem@davemloft.net>,
"stephen@networkplumber.org" <stephen@networkplumber.org>,
Steven Rostedt <rostedt@goodmis.org>
Subject: RE: [PATCH v3] net/phy: micrel: Add OF configuration support for ksz9021
Date: Mon, 5 Aug 2013 03:03:55 +0000 [thread overview]
Message-ID: <9848F2DB572E5649BA045B288BE08FBE015EE4A2@039-SN2MPN1-023.039d.mgd.msft.net> (raw)
In-Reply-To: <5CE77AC80B4242C98833109D6F1C9F85@kosagi.com>
From: Sean Cross [mailto:xobs@kosagi.com]
Data: Monday, August 05, 2013 10:24 AM
> > > +Example:
> > > + &enet {
> > > + micrel,clk-control-pad-skew = <0xf0f0>; micrel,rx-data-pad-skew =
> > > +<0x0000>; micrel,tx-data-pad-skew = <0xffff>; status = "okay";
> > > +};
> > > +
> >
> >
> >
> > The phy binding must be the phy node, not the ethernet node.
> > Pls refer to:
> > Documentation/devicetree/booting-without-of.txt
> > Documentation/devicetree/bindings/net/phy.txt
>
> This won't necessarily work. In my board, I don't think it's possible to
> manually specify the PHY, as most of the fields required by the OF PHY
> node don't apply to this device (at least according to phy.txt). There
> are no interrupts, no interrupt parent, and it's unclear what the reg or
> linux,phandle fields do. All of these are required fields, none of which
> seem to apply to this particular board. Furthermore, it doesn't seem to
> be possible to specify a particular PHY, such as the ksz9021.
>
> I see the pattern of getting OF settings from a parent's node used
> elsewhere in the kernel. For example, in mmc_of_parse(), or more
> similarly in the chipidea ci_hdrc_probe() driver.
Yes, the patch is only reasonable for your platform, but it is the phy driver for different platforms that you must considerate.
Please add more example cases in binding doc.
prev parent reply other threads:[~2013-08-05 3:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-01 9:19 [PATCH v3] Add OF bindings to Micrel ksz9021 PHY Sean Cross
2013-08-01 9:19 ` [PATCH v3] net/phy: micrel: Add OF configuration support for ksz9021 Sean Cross
2013-08-04 4:56 ` David Miller
2013-08-05 1:58 ` Duan Fugang-B38611
2013-08-05 2:23 ` Sean Cross
2013-08-05 3:03 ` Duan Fugang-B38611 [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9848F2DB572E5649BA045B288BE08FBE015EE4A2@039-SN2MPN1-023.039d.mgd.msft.net \
--to=b38611@freescale.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=s.hauer@pengutronix.de \
--cc=stephen@networkplumber.org \
--cc=xobs@kosagi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).