From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Metcalf Subject: RE: [PATCH 6/6] tilegx network driver: initial support Date: Sun, 15 Apr 2012 23:06:17 +0000 Message-ID: <9D6CA7A63751804FADD8B075304A6858109A5B47@USMAExch1.tad.internal.tilera.com> References: <201204062059.q36KxjEO011317@farm-0027.internal.tilera.com> <201204091349.54484.arnd@arndb.de> <4F835510.4060100@tilera.com>,<201204101042.39877.arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT Cc: "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" To: Arnd Bergmann Return-path: Received: from usmamail.tilera.com ([206.83.70.75]:28416 "EHLO USMAMAIL.TILERA.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752000Ab2DOXJT convert rfc822-to-8bit (ORCPT ); Sun, 15 Apr 2012 19:09:19 -0400 In-Reply-To: <201204101042.39877.arnd@arndb.de> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: Arnd Bergmann wrote: > > We need "tile_net_devs_for_channel" because we share a single hardware > > queue for all devices, and each packet's metadata contains a "channel" > > value which indicates the device. > > Ok, but please remove tile_net_devs then. I spent some time on Friday with the driver author and we made some good changes, switching over to using more of a per-channel model for everything. We also removed the per-cpu per-driver stats structures and just use atomics to update the per-driver stats directly. The upshot is a much cleaner set of data structures, but unfortunately we didn't have time to work all the way through the ramifications before the weekend, and I'm out next week for spring school vacation. Thanks again for the feedback! Chris Metcalf