From: "Sriram Krishnan (srirakr2)" <srirakr2@cisco.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: "K. Y. Srinivasan" <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
Wei Liu <wei.liu@kernel.org>,
"Malcolm Bumgardner (mbumgard)" <mbumgard@cisco.com>,
"Umesha G M (ugm)" <ugm@cisco.com>,
"Niranjan M M (nimm)" <nimm@cisco.com>,
"xe-linux-external(mailer list)" <xe-linux-external@cisco.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4] hv_netvsc: add support for vlans in AF_PACKET mode
Date: Wed, 22 Jul 2020 10:47:32 +0000 [thread overview]
Message-ID: <9D7619F5-821F-4F06-B0EC-BBBAB8450690@cisco.com> (raw)
In-Reply-To: <20200721090528.2c9f104d@hermes.lan>
On 21/07/20, 9:36 PM,
Stephen Hemminger <stephen@networkplumber.org> wrote:
> Printing error messages is good for debugging but bad IRL.
> Users ignore it, or it overflows the log buffer.
> A better alternative would be to add a counter to netvsc_ethtool_stats.
Thanks, the recommended change can be found in patch v5
prev parent reply other threads:[~2020-07-22 10:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-21 7:14 [PATCH v4] hv_netvsc: add support for vlans in AF_PACKET mode Sriram Krishnan
2020-07-21 16:05 ` Stephen Hemminger
2020-07-22 10:47 ` Sriram Krishnan (srirakr2) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9D7619F5-821F-4F06-B0EC-BBBAB8450690@cisco.com \
--to=srirakr2@cisco.com \
--cc=davem@davemloft.net \
--cc=haiyangz@microsoft.com \
--cc=kuba@kernel.org \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mbumgard@cisco.com \
--cc=netdev@vger.kernel.org \
--cc=nimm@cisco.com \
--cc=stephen@networkplumber.org \
--cc=sthemmin@microsoft.com \
--cc=ugm@cisco.com \
--cc=wei.liu@kernel.org \
--cc=xe-linux-external@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).