netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Ahern <dsahern@gmail.com>
To: Roopa Prabhu <roopa@cumulusnetworks.com>,
	David Miller <davem@davemloft.net>
Cc: netdev <netdev@vger.kernel.org>,
	Nikolay Aleksandrov <nikolay@cumulusnetworks.com>,
	bpoirier@cumulusnetworks.com
Subject: Re: [PATCH net-next 0/2] nexthop: sysctl to skip route notifications on nexthop changes
Date: Thu, 23 Apr 2020 09:09:59 -0600	[thread overview]
Message-ID: <9bc6f1cd-7d18-8222-6e09-918488c3f6b5@gmail.com> (raw)
In-Reply-To: <CAJieiUgHMjVozdSE_DM1yDnGuUEXkamDgmKwUfdBbvhTdx3Eqg@mail.gmail.com>

On 4/23/20 8:48 AM, Roopa Prabhu wrote:
> 
> 
> On Wed, Apr 22, 2020, 10:21 PM Roopa Prabhu <roopa@cumulusnetworks.com
> <mailto:roopa@cumulusnetworks.com>> wrote:
> 
>     From: Roopa Prabhu <roopa@cumulusnetworks.com
>     <mailto:roopa@cumulusnetworks.com>>
> 
>     Route notifications on nexthop changes exists for backward
>     compatibility. In systems which have moved to the new
>     nexthop API, these route update notifications cancel
>     the performance benefits provided by the new nexthop API.
>     This patch adds a sysctl to disable these route notifications
> 
>     We have discussed this before. Maybe its time ?
> 
>     Roopa Prabhu (2):
>       ipv4: add sysctl to skip route notify on nexthop changes
>       ipv6: add sysctl to skip route notify on nexthop changes
> 
> 
> 
> Will update the series with some self test results with sysctl on later
> today. Expect v2
> 

and I have some changes for you. :-)

There's a bit more to a "all of the processes know about nexthops; give
me best performance" switch. I will send you a starter patch - the one I
used for the LPC 2019 talk.

  parent reply	other threads:[~2020-04-23 15:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-23  5:21 [PATCH net-next 0/2] nexthop: sysctl to skip route notifications on nexthop changes Roopa Prabhu
2020-04-23  5:21 ` [PATCH net-next 1/2] ipv4: add sysctl to skip route notify " Roopa Prabhu
2020-04-23  5:21 ` [PATCH net-next 2/2] ipv6: " Roopa Prabhu
     [not found] ` <CAJieiUgHMjVozdSE_DM1yDnGuUEXkamDgmKwUfdBbvhTdx3Eqg@mail.gmail.com>
2020-04-23 15:09   ` David Ahern [this message]
2020-04-23 19:46     ` [PATCH net-next 0/2] nexthop: sysctl to skip route notifications " Roopa Prabhu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9bc6f1cd-7d18-8222-6e09-918488c3f6b5@gmail.com \
    --to=dsahern@gmail.com \
    --cc=bpoirier@cumulusnetworks.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=nikolay@cumulusnetworks.com \
    --cc=roopa@cumulusnetworks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).