netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Ahern <dsahern@gmail.com>
To: Paolo Abeni <pabeni@redhat.com>, netdev@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH net v2 1/2] ipv6: route: enforce RCU protection in rt6_update_exception_stamp_rt()
Date: Thu, 21 Feb 2019 09:57:30 -0500	[thread overview]
Message-ID: <9d7a8ee2-3793-b1f0-6647-9eef70ce2dd3@gmail.com> (raw)
In-Reply-To: <fe784e447b956d111d61d8dbc3386d7bb95a8d89.1550684182.git.pabeni@redhat.com>

On 2/21/19 5:19 AM, Paolo Abeni wrote:
> We must access rt6_info->from under RCU read lock: move the
> dereference under such lock, with proper annotation.
> 
> v1 -> v2:
>  - avoid using multiple, racy, fetch operations for rt->from
> 
> Fixes: a68886a69180 ("net/ipv6: Make from in rt6_info rcu protected")
> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
> ---
>  net/ipv6/route.c | 11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)
> 

Reviewed-by: David Ahern <dsahern@gmail.com>

Thanks for fixing.


  reply	other threads:[~2019-02-21 14:57 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-21 10:19 [PATCH net v2 0/2] ipv6: route: enforce RCU protection for fib6_info->from Paolo Abeni
2019-02-21 10:19 ` [PATCH net v2 1/2] ipv6: route: enforce RCU protection in rt6_update_exception_stamp_rt() Paolo Abeni
2019-02-21 14:57   ` David Ahern [this message]
2019-02-21 10:19 ` [PATCH net v2 2/2] ipv6: route: enforce RCU protection in ip6_route_check_nh_onlink() Paolo Abeni
2019-02-21 14:57   ` David Ahern
2019-02-21 17:54 ` [PATCH net v2 0/2] ipv6: route: enforce RCU protection for fib6_info->from David Miller
2019-02-22  2:45   ` David Ahern
2019-02-22  5:32     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9d7a8ee2-3793-b1f0-6647-9eef70ce2dd3@gmail.com \
    --to=dsahern@gmail.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).