netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michael Walle <michael@walle.cc>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: Joakim Zhang <qiangqing.zhang@nxp.com>,
	linux-can@vger.kernel.org, dl-linux-imx <linux-imx@nxp.com>,
	netdev@vger.kernel.org
Subject: Re: [PATCH linux-can-next/flexcan] can: flexcan: fix TDC feature
Date: Mon, 29 Jun 2020 18:23:07 +0200	[thread overview]
Message-ID: <9dc13a697c246a5c7c53bdd89df7d3c7@walle.cc> (raw)
In-Reply-To: <e38cf40b-ead3-81de-0be7-18cca5ca1a0c@pengutronix.de>

Hi Marc,

> I've cleaned up the patches a bit, can you test this branch:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next.git/log/?h=flexcan

This is working, but as Joakim already said, CAN-FD ISO mode is missing.
It defaults to non-ISO mode, which is even worse, IMHO.

But I've also noticed a difference between the original patch and the
one in that branch. When FD mode is enabled the original patch checks
the priv->can.controlmode [1], the patch in the branch looks at
priv->can.ctrlmode_supported instead [2], is that correct?

-michael

[1] 
https://lore.kernel.org/netdev/20190712075926.7357-4-qiangqing.zhang@nxp.com/
[2] 
https://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next.git/tree/drivers/net/can/flexcan.c?h=flexcan&id=5f097cd65cb2b42b88e6e1eb186f6a8f0c90559b#n1341

  parent reply	other threads:[~2020-06-29 18:52 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-16  9:31 [PATCH Resend linux-can-next/testing] can: flexcan: add correctable errors correction when HW supports ECC Joakim Zhang
2020-04-16  9:31 ` [PATCH linux-can-next/flexcan] can: flexcan: fix TDC feature Joakim Zhang
2020-04-16  9:41   ` Joakim Zhang
2020-06-02 10:15     ` Michael Walle
2020-06-25 12:37       ` Michael Walle
2020-06-25 12:56         ` Marc Kleine-Budde
2020-06-29  5:37           ` Joakim Zhang
2020-06-29 16:23           ` Michael Walle [this message]
2020-06-30  2:25             ` Joakim Zhang
2020-09-15 22:16               ` Marc Kleine-Budde
2020-09-16  2:26                 ` Joakim Zhang
2020-09-15 22:15             ` Marc Kleine-Budde
2020-07-23 21:09           ` Michael Walle
2020-09-14 15:16             ` Michael Walle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9dc13a697c246a5c7c53bdd89df7d3c7@walle.cc \
    --to=michael@walle.cc \
    --cc=linux-can@vger.kernel.org \
    --cc=linux-imx@nxp.com \
    --cc=mkl@pengutronix.de \
    --cc=netdev@vger.kernel.org \
    --cc=qiangqing.zhang@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).