From: Markus Elfring <Markus.Elfring@web.de>
To: Denis Efremov <efremov@linux.com>, Joe Perches <joe@perches.com>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
"Anton Altaparmakov" <anton@tuxera.com>,
"Andy Whitcroft" <apw@canonical.com>,
"Boris Ostrovsky" <boris.ostrovsky@oracle.com>,
"Boris Pismenny" <borisp@mellanox.com>,
"Darrick J. Wong" <darrick.wong@oracle.com>,
"David S. Miller" <davem@davemloft.net>,
"Dennis Dalessandro" <dennis.dalessandro@intel.com>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
dri-devel@lists.freedesktop.org,
"Inaky Perez-Gonzalez" <inaky.perez-gonzalez@intel.com>,
"Jürgen Groß" <jgross@suse.com>,
"Leon Romanovsky" <leon@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-ntfs-dev@lists.sourceforge.net, linux-rdma@vger.kernel.org,
linux-wimax@intel.com, linux-xfs@vger.kernel.org,
"Mike Marciniszyn" <mike.marciniszyn@intel.com>,
netdev@vger.kernel.org, "Pali Rohár" <pali.rohar@gmail.com>,
"Rob Clark" <robdclark@gmail.com>,
"Saeed Mahameed" <saeedm@mellanox.com>,
"Sean Paul" <sean@poorly.run>,
"Alexander Viro" <viro@zeniv.linux.org.uk>,
xen-devel@lists.xenproject.org, "Enrico Weigelt" <lkml@metux.net>
Subject: Re: [PATCH v3 01/11] checkpatch: check for nested (un)?likely() calls
Date: Sat, 31 Aug 2019 19:26:41 +0200 [thread overview]
Message-ID: <9de9fb8f-f13f-e9bb-c68d-0ba81010ae8b@web.de> (raw)
In-Reply-To: <c5e4479d-2fb3-b5a5-00c3-b06e5177d869@linux.com>
>>>>> +# nested likely/unlikely calls
>>>>> + if ($line =~ /\b(?:(?:un)?likely)\s*\(\s*!?\s*(IS_ERR(?:_OR_NULL|_VALUE)?|WARN)/) {
>>>>> + WARN("LIKELY_MISUSE",
…
>> \b(?:un)?likely\s*
>
> This pair of brackets is required to match "unlikely"
> and it's optional in order to match "likely".
I agree also to this view if you refer to the shortened regular expression here.
But I got an other development opinion for an extra pair of non-capturing parentheses
at the front (from the version which you suggested).
Regards,
Markus
prev parent reply other threads:[~2019-08-31 17:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-29 16:50 [PATCH v3 01/11] checkpatch: check for nested (un)?likely() calls Denis Efremov
2019-08-29 16:50 ` [PATCH v3 03/11] net/mlx5e: Remove unlikely() from WARN*() condition Denis Efremov
2019-08-29 21:23 ` Saeed Mahameed
2019-08-31 2:50 ` David Miller
2019-08-29 16:50 ` [PATCH v3 10/11] udp: Remove unlikely() from IS_ERR*() condition Denis Efremov
2019-08-31 9:15 ` [PATCH v3 01/11] checkpatch: check for nested (un)?likely() calls Markus Elfring
2019-08-31 15:54 ` Denis Efremov
2019-08-31 16:45 ` Markus Elfring
2019-08-31 17:07 ` Denis Efremov
2019-08-31 17:26 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9de9fb8f-f13f-e9bb-c68d-0ba81010ae8b@web.de \
--to=markus.elfring@web.de \
--cc=akpm@linux-foundation.org \
--cc=anton@tuxera.com \
--cc=apw@canonical.com \
--cc=boris.ostrovsky@oracle.com \
--cc=borisp@mellanox.com \
--cc=darrick.wong@oracle.com \
--cc=davem@davemloft.net \
--cc=dennis.dalessandro@intel.com \
--cc=dmitry.torokhov@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=efremov@linux.com \
--cc=inaky.perez-gonzalez@intel.com \
--cc=jgross@suse.com \
--cc=joe@perches.com \
--cc=leon@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ntfs-dev@lists.sourceforge.net \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-wimax@intel.com \
--cc=linux-xfs@vger.kernel.org \
--cc=lkml@metux.net \
--cc=mike.marciniszyn@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pali.rohar@gmail.com \
--cc=robdclark@gmail.com \
--cc=saeedm@mellanox.com \
--cc=sean@poorly.run \
--cc=viro@zeniv.linux.org.uk \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).