From: Michael Walle <michael@walle.cc>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
cphealy@gmail.com, davem@davemloft.net, hkallweit1@gmail.com,
mkubecek@suse.cz, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v1 4/9] net: ethtool: Add attributes for cable test reports
Date: Wed, 29 Apr 2020 21:32:51 +0200 [thread overview]
Message-ID: <9e8fa21bd1b51104038dbdc54fb61674@walle.cc> (raw)
In-Reply-To: <743b2495-eab1-01af-1c1c-269f992b802a@gmail.com>
Am 2020-04-29 20:58, schrieb Florian Fainelli:
> On 4/29/20 11:57 AM, Andrew Lunn wrote:
>> On Wed, Apr 29, 2020 at 06:16:05PM +0200, Michael Walle wrote:
>>> Hi,
>>>
>>>>>>> +enum {
>>>>>>> + ETHTOOL_A_CABLE_PAIR_0,
>>>>>>> + ETHTOOL_A_CABLE_PAIR_1,
>>>>>>> + ETHTOOL_A_CABLE_PAIR_2,
>>>>>>> + ETHTOOL_A_CABLE_PAIR_3,
>>>>>>> +};
>>>>>>
>>>>>> Do we really need this enum, couldn't we simply use a number
>>>>>> (possibly
>>>>>> with a sanity check of maximum value)?
>>>>>
>>>>> They are not strictly required. But it helps with consistence. Are
>>>>> the
>>>>> pairs numbered 0, 1, 2, 3, or 1, 2, 3, 4?
>>>>
>>>> OK, I'm not strictly opposed to it, it just felt a bit weird.
>>>
>>> Speaking of the pairs. What is PAIR_0 and what is PAIR_3? Maybe
>>> it is specified somewhere in a standard, but IMHO an example for
>>> a normal TP cable would help to prevent wild growth amongst the
>>> PHY drivers and would help to provide consistent reporting towards
>>> the user space.
>>
>> Hi Michael
>>
>> Good question
>>
>> Section 25.4.3 gives the pin out for 100BaseT. There is no pair
>> numbering, just transmit+, transmit- and receive+, receive- signals.
>>
>> 1000BaseT calls the signals BI_DA+, BI_DA-, BI_DB+, BI_DB-, BI_DC+,
>> BI_DC-, BI_DDA+, BI_DD-. Comparing the pinout 100BaseT would use
>> BI_DA+, BI_DA-, BI_DB+, BI_DB. But 1000BaseT does not really have
>> transmit and receive pairs due to Auto MDI-X.
>>
>> BroadReach calls the one pair it has BI_DA+/BI_DA-.
>>
>> Maybe it would be better to have:
>>
>> enum {
>> ETHTOOL_A_CABLE_PAIR_A,
>> ETHTOOL_A_CABLE_PAIR_B,
>> ETHTOOL_A_CABLE_PAIR_C,
>> ETHTOOL_A_CABLE_PAIR_D,
>> };
>
> Yes, that would be clearer IMHO. Broadcom PHYs tend to refer to pairs
> A,
> B, C and D in their datasheets.
Qualcomm Atheros calls them MDI[0], MDI[1], etc.. maybe mention
the corresponding pin on an RJ45 connector for reference?
-michael
next prev parent reply other threads:[~2020-04-29 19:32 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-25 18:06 [PATCH net-next v1 0/9] Ethernet Cable test support Andrew Lunn
2020-04-25 18:06 ` [PATCH net-next v1 1/9] net: phy: Add cable test support to state machine Andrew Lunn
2020-04-26 19:46 ` Michal Kubecek
2020-04-26 20:31 ` Andrew Lunn
2020-04-26 21:22 ` Florian Fainelli
2020-04-25 18:06 ` [PATCH net-next v1 2/9] net: phy: Add support for polling cable test Andrew Lunn
2020-04-25 19:49 ` Florian Fainelli
2020-04-25 20:10 ` Andrew Lunn
2020-04-26 21:19 ` Florian Fainelli
2020-04-26 22:07 ` Andrew Lunn
2020-04-25 18:06 ` [PATCH net-next v1 3/9] net: ethtool: netlink: Add support for triggering a " Andrew Lunn
2020-04-26 19:36 ` Michal Kubecek
2020-04-26 20:38 ` Andrew Lunn
2020-04-26 20:50 ` Michal Kubecek
2020-04-25 18:06 ` [PATCH net-next v1 4/9] net: ethtool: Add attributes for cable test reports Andrew Lunn
2020-04-25 20:00 ` Randy Dunlap
2020-04-26 20:25 ` Michal Kubecek
2020-04-26 21:12 ` Andrew Lunn
2020-04-27 7:13 ` Michal Kubecek
2020-04-29 16:16 ` Michael Walle
2020-04-29 18:57 ` Andrew Lunn
2020-04-29 18:58 ` Florian Fainelli
2020-04-29 19:32 ` Michael Walle [this message]
2020-04-25 18:06 ` [PATCH net-next v1 5/9] net: ethtool: Make helpers public Andrew Lunn
2020-04-25 18:06 ` [PATCH net-next v1 6/9] net: ethtool: Add infrastructure for reporting cable test results Andrew Lunn
2020-04-25 18:06 ` [PATCH net-next v1 7/9] net: ethtool: Add helpers for reporting " Andrew Lunn
2020-04-25 18:06 ` [PATCH net-next v1 8/9] net: phy: marvell: Add cable test support Andrew Lunn
2020-04-25 18:06 ` [PATCH net-next v1 9/9] net: phy: Put interface into oper testing during cable test Andrew Lunn
2020-04-29 16:02 ` [PATCH net-next v1 0/9] Ethernet Cable test support Michael Walle
2020-04-29 16:32 ` Andrew Lunn
2020-04-30 17:48 ` Michael Walle
2020-04-30 18:23 ` Andrew Lunn
2020-04-30 19:44 ` Michael Walle
2020-04-30 20:51 ` Andrew Lunn
2020-04-30 18:34 ` Florian Fainelli
2020-04-30 19:31 ` Michael Walle
2020-04-30 19:38 ` Florian Fainelli
2020-04-30 19:52 ` Michael Walle
2020-04-30 19:41 ` Andrew Lunn
2020-04-30 20:01 ` Michael Walle
2020-04-30 20:56 ` Andrew Lunn
2020-04-30 20:04 ` Florian Fainelli
2020-04-30 20:13 ` Michael Walle
2020-04-30 20:19 ` Florian Fainelli
2020-04-30 21:16 ` Michael Walle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e8fa21bd1b51104038dbdc54fb61674@walle.cc \
--to=michael@walle.cc \
--cc=andrew@lunn.ch \
--cc=cphealy@gmail.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).