netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arcnet: fix macro name when DEBUG is defined
@ 2021-01-17 18:15 trix
  2021-01-17 18:27 ` Joe Perches
  2021-01-19  5:50 ` patchwork-bot+netdevbpf
  0 siblings, 2 replies; 3+ messages in thread
From: trix @ 2021-01-17 18:15 UTC (permalink / raw)
  To: m.grzeschik, davem, kuba, joe; +Cc: netdev, linux-kernel, Tom Rix

From: Tom Rix <trix@redhat.com>

When DEBUG is defined this error occurs

drivers/net/arcnet/com20020_cs.c:70:15: error: ‘com20020_REG_W_ADDR_HI’
  undeclared (first use in this function);
  did you mean ‘COM20020_REG_W_ADDR_HI’?
       ioaddr, com20020_REG_W_ADDR_HI);
               ^~~~~~~~~~~~~~~~~~~~~~

From reviewing the context, the suggestion is what is meant.

Fixes: 0fec65130b9f ("arcnet: com20020: Use arcnet_<I/O> routines")
Signed-off-by: Tom Rix <trix@redhat.com>
---
 drivers/net/arcnet/com20020_cs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/arcnet/com20020_cs.c b/drivers/net/arcnet/com20020_cs.c
index cf607ffcf358..81223f6bebcc 100644
--- a/drivers/net/arcnet/com20020_cs.c
+++ b/drivers/net/arcnet/com20020_cs.c
@@ -67,7 +67,7 @@ static void regdump(struct net_device *dev)
 	/* set up the address register */
 	count = 0;
 	arcnet_outb((count >> 8) | RDDATAflag | AUTOINCflag,
-		    ioaddr, com20020_REG_W_ADDR_HI);
+		    ioaddr, COM20020_REG_W_ADDR_HI);
 	arcnet_outb(count & 0xff, ioaddr, COM20020_REG_W_ADDR_LO);
 
 	for (count = 0; count < 256 + 32; count++) {
-- 
2.27.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] arcnet: fix macro name when DEBUG is defined
  2021-01-17 18:15 [PATCH] arcnet: fix macro name when DEBUG is defined trix
@ 2021-01-17 18:27 ` Joe Perches
  2021-01-19  5:50 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: Joe Perches @ 2021-01-17 18:27 UTC (permalink / raw)
  To: trix, m.grzeschik, davem, kuba; +Cc: netdev, linux-kernel

On Sun, 2021-01-17 at 10:15 -0800, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
> 
> When DEBUG is defined this error occurs
> 
> drivers/net/arcnet/com20020_cs.c:70:15: error: ‘com20020_REG_W_ADDR_HI’
>   undeclared (first use in this function);
>   did you mean ‘COM20020_REG_W_ADDR_HI’?
>        ioaddr, com20020_REG_W_ADDR_HI);
>                ^~~~~~~~~~~~~~~~~~~~~~
> 
> From reviewing the context, the suggestion is what is meant.
> 
> Fixes: 0fec65130b9f ("arcnet: com20020: Use arcnet_<I/O> routines")

Nice find thanks, especially seeing as how this hasn't been tested or
compiled in 5+ years...

	commit 0fec65130b9f11a73d74f47025491f97f82ba070
	Author: Joe Perches <joe@perches.com>
	Date:   Tue May 5 10:06:06 2015 -0700

Acked-by: Joe Perches <joe@perches.com>

> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
>  drivers/net/arcnet/com20020_cs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/arcnet/com20020_cs.c b/drivers/net/arcnet/com20020_cs.c
> index cf607ffcf358..81223f6bebcc 100644
> --- a/drivers/net/arcnet/com20020_cs.c
> +++ b/drivers/net/arcnet/com20020_cs.c
> @@ -67,7 +67,7 @@ static void regdump(struct net_device *dev)
>  	/* set up the address register */
>  	count = 0;
>  	arcnet_outb((count >> 8) | RDDATAflag | AUTOINCflag,
> -		    ioaddr, com20020_REG_W_ADDR_HI);
> +		    ioaddr, COM20020_REG_W_ADDR_HI);
>  	arcnet_outb(count & 0xff, ioaddr, COM20020_REG_W_ADDR_LO);
>  
> 
>  	for (count = 0; count < 256 + 32; count++) {



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] arcnet: fix macro name when DEBUG is defined
  2021-01-17 18:15 [PATCH] arcnet: fix macro name when DEBUG is defined trix
  2021-01-17 18:27 ` Joe Perches
@ 2021-01-19  5:50 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-01-19  5:50 UTC (permalink / raw)
  To: Tom Rix; +Cc: m.grzeschik, davem, kuba, joe, netdev, linux-kernel

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Sun, 17 Jan 2021 10:15:19 -0800 you wrote:
> From: Tom Rix <trix@redhat.com>
> 
> When DEBUG is defined this error occurs
> 
> drivers/net/arcnet/com20020_cs.c:70:15: error: ‘com20020_REG_W_ADDR_HI’
>   undeclared (first use in this function);
>   did you mean ‘COM20020_REG_W_ADDR_HI’?
>        ioaddr, com20020_REG_W_ADDR_HI);
>                ^~~~~~~~~~~~~~~~~~~~~~
> 
> [...]

Here is the summary with links:
  - arcnet: fix macro name when DEBUG is defined
    https://git.kernel.org/netdev/net-next/c/7cfabe4f85a5

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-01-19  6:39 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-17 18:15 [PATCH] arcnet: fix macro name when DEBUG is defined trix
2021-01-17 18:27 ` Joe Perches
2021-01-19  5:50 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).