From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE43FC433E6 for ; Sun, 17 Jan 2021 18:27:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9F58522226 for ; Sun, 17 Jan 2021 18:27:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729165AbhAQS1s (ORCPT ); Sun, 17 Jan 2021 13:27:48 -0500 Received: from smtprelay0251.hostedemail.com ([216.40.44.251]:33818 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726295AbhAQS1p (ORCPT ); Sun, 17 Jan 2021 13:27:45 -0500 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay06.hostedemail.com (Postfix) with ESMTP id 595F81800CA7D; Sun, 17 Jan 2021 18:27:03 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: goat17_180d3b827542 X-Filterd-Recvd-Size: 2401 Received: from [192.168.1.159] (unknown [47.151.137.21]) (Authenticated sender: joe@perches.com) by omf07.hostedemail.com (Postfix) with ESMTPA; Sun, 17 Jan 2021 18:27:02 +0000 (UTC) Message-ID: <9fd72be8e628dba40fa83aeef65d80877ede86ca.camel@perches.com> Subject: Re: [PATCH] arcnet: fix macro name when DEBUG is defined From: Joe Perches To: trix@redhat.com, m.grzeschik@pengutronix.de, davem@davemloft.net, kuba@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Sun, 17 Jan 2021 10:27:01 -0800 In-Reply-To: <20210117181519.527625-1-trix@redhat.com> References: <20210117181519.527625-1-trix@redhat.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.1-1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sun, 2021-01-17 at 10:15 -0800, trix@redhat.com wrote: > From: Tom Rix > > When DEBUG is defined this error occurs > > drivers/net/arcnet/com20020_cs.c:70:15: error: ‘com20020_REG_W_ADDR_HI’ >   undeclared (first use in this function); >   did you mean ‘COM20020_REG_W_ADDR_HI’? >        ioaddr, com20020_REG_W_ADDR_HI); >                ^~~~~~~~~~~~~~~~~~~~~~ > > From reviewing the context, the suggestion is what is meant. > > Fixes: 0fec65130b9f ("arcnet: com20020: Use arcnet_ routines") Nice find thanks, especially seeing as how this hasn't been tested or compiled in 5+ years... commit 0fec65130b9f11a73d74f47025491f97f82ba070 Author: Joe Perches Date: Tue May 5 10:06:06 2015 -0700 Acked-by: Joe Perches > Signed-off-by: Tom Rix > --- >  drivers/net/arcnet/com20020_cs.c | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/arcnet/com20020_cs.c b/drivers/net/arcnet/com20020_cs.c > index cf607ffcf358..81223f6bebcc 100644 > --- a/drivers/net/arcnet/com20020_cs.c > +++ b/drivers/net/arcnet/com20020_cs.c > @@ -67,7 +67,7 @@ static void regdump(struct net_device *dev) >   /* set up the address register */ >   count = 0; >   arcnet_outb((count >> 8) | RDDATAflag | AUTOINCflag, > - ioaddr, com20020_REG_W_ADDR_HI); > + ioaddr, COM20020_REG_W_ADDR_HI); >   arcnet_outb(count & 0xff, ioaddr, COM20020_REG_W_ADDR_LO); >   > >   for (count = 0; count < 256 + 32; count++) {