From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?utf-8?Q?H=C3=A5kon_Bugge?= Subject: Re: [v2,0/2] net: if_arp: use define instead of hard-coded value Date: Tue, 23 Oct 2018 14:30:57 +0200 Message-ID: References: <20181009142724.2213012-1-Haakon.Bugge@oracle.com> Mime-Version: 1.0 (Mac OS X Mail 12.0 \(3445.100.39\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: Stephen Hemminger , "David S . Miller" , Kate Stewart , Thomas Gleixner , Greg Kroah-Hartman , Philippe Ombredanne , linux-kernel@vger.kernel.org To: netdev@vger.kernel.org Return-path: In-Reply-To: <20181009142724.2213012-1-Haakon.Bugge@oracle.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org > On 9 Oct 2018, at 16:27, H=C3=A5kon Bugge = wrote: >=20 > Struct arpreq contains the name of the device. All other places in the > kernel, the define IFNAMSIZ is used to designate its size. But in > if_arp.h, a literal constant is used. >=20 > Fixed by explicitly including uapi/linu/if.h, where IFNAMSIZ is = defined. >=20 > The series also fixes some incorrect indents. >=20 >=20 > v1 -> v2: > * Include uapi/linux/if.h from if_arp.h > * Added Stephen's t-b >=20 > H=C3=A5kon Bugge (2): > net: if_arp: Fix incorrect indents > net: if_arp: use define instead of hard-coded value >=20 > include/uapi/linux/if_arp.h | 19 ++++++++++--------- > 1 file changed, 10 insertions(+), 9 deletions(-) > --- > 2.14.3 Just a friendly reminder. Thxs, H=C3=A5kon >=20 >=20 > =46rom a36b99413ea5beca1539f4faf065f33c7c19e6a5 Mon Sep 17 00:00:00 = 2001 > From: =3D?UTF-8?q?H=3DC3=3DA5kon=3D20Bugge?=3D = > Date: Fri, 21 Sep 2018 11:28:36 +0200 > Subject: [PATCH 0/2] > MIME-Version: 1.0 > Content-Type: text/plain; charset=3DUTF-8 > Content-Transfer-Encoding: 8bit >=20 > Struct arpreq contains the name of the device. All other places in the > kernel, the define IFNAMSIZ is used to designate its size. But in > if_arp.h, a literal constant is used. >=20 > As it could be good reasons to use constants instead of the defines in > include files under uapi, it seems to be OK to use the define here, > without opening a can of worms in user-land. >=20 > This because if_arp.h includes netdevice.h, which also uses > IFNAMSIZ. For the distros I have checked, this also holds true for the > use-land side. >=20 > The series also fixes some incorrect indents. >=20 > H=C3=A5kon Bugge (2): > net: if_arp: Fix incorrect indents > net: if_arp: use define instead of hard-coded value >=20 > include/uapi/linux/if_arp.h | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) >=20 > -- > 2.14.3