From: Parav Pandit <parav@mellanox.com>
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: Greg KH <gregkh@linuxfoundation.org>,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
"davem@davemloft.net" <davem@davemloft.net>,
Dave Ertman <david.m.ertman@intel.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"nhorman@redhat.com" <nhorman@redhat.com>,
"sassmann@redhat.com" <sassmann@redhat.com>,
Kiran Patil <kiran.patil@intel.com>
Subject: RE: [net-next 1/1] virtual-bus: Implementation of Virtual Bus
Date: Wed, 13 Nov 2019 06:44:49 +0000 [thread overview]
Message-ID: <AM0PR05MB48665001B54D3F29A9D4127FD1760@AM0PR05MB4866.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <20191113011038.GC19615@ziepe.ca>
> From: Jason Gunthorpe <jgg@ziepe.ca>
> Sent: Tuesday, November 12, 2019 7:11 PM
>
> > A small improvement below, because get_drvdata() and set_drvdata()
>
> Here it was called 'devdata' not the existing drvdata - so something different, I
> was confused for a bit too..
>
Oh ok. but looks buggy in the patch as virtbus_dev doesn't have devdata field.
Anyways, container_of() is better type checked anyway as below.
+#define virtbus_get_devdata(dev) ((dev)->devdata)
> > is supposed to be called by the bus driver, not its creator. And
> > below data structure achieve strong type checks, no void* casts, and
> > exactly achieves the foo_device example. Isn't it better?
>
> > mlx5_virtbus_device {
> > struct virtbus_device dev;
> > struct mlx5_core_dev *dev;
> > };
>
> This does seem a bit cleaner than using the void * trick (more, OOPy at least)
>
Ok. thanks.
next prev parent reply other threads:[~2019-11-13 6:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-11 19:22 [net-next 1/1] virtual-bus: Implementation of Virtual Bus Jeff Kirsher
2019-11-12 20:59 ` Jason Gunthorpe
2019-11-12 21:18 ` Ertman, David M
2019-11-12 21:28 ` Greg KH
2019-11-13 0:08 ` Jason Gunthorpe
2019-11-13 1:03 ` Parav Pandit
2019-11-13 1:10 ` Jason Gunthorpe
2019-11-13 6:44 ` Parav Pandit [this message]
2019-11-13 1:09 ` Ertman, David M
2019-11-13 7:03 ` Parav Pandit
2019-11-15 21:17 ` Ertman, David M
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM0PR05MB48665001B54D3F29A9D4127FD1760@AM0PR05MB4866.eurprd05.prod.outlook.com \
--to=parav@mellanox.com \
--cc=davem@davemloft.net \
--cc=david.m.ertman@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jgg@ziepe.ca \
--cc=kiran.patil@intel.com \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nhorman@redhat.com \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).