From: Raed Salem <raeds@mellanox.com>
To: David Miller <davem@davemloft.net>
Cc: "john.fastabend@gmail.com" <john.fastabend@gmail.com>,
"daniel@iogearbox.net" <daniel@iogearbox.net>,
"kuba@kernel.org" <kuba@kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: RE: [PATCH net] tls: handle NETDEV_UNREGISTER for tls device
Date: Tue, 4 Feb 2020 13:07:47 +0000 [thread overview]
Message-ID: <AM0PR05MB52507339607E5BF60372A878C4030@AM0PR05MB5250.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <20200204.123041.1506575968362096923.davem@davemloft.net>
Thanks David/Jakubs for the review,
I had problems with the setup, once I have results I resubmit on need.
> -----Original Message-----
> From: David Miller [mailto:davem@davemloft.net]
> Sent: Tuesday, February 04, 2020 1:31 PM
> To: Raed Salem <raeds@mellanox.com>
> Cc: john.fastabend@gmail.com; daniel@iogearbox.net; kuba@kernel.org;
> netdev@vger.kernel.org
> Subject: Re: [PATCH net] tls: handle NETDEV_UNREGISTER for tls device
>
> From: Raed Salem <raeds@mellanox.com>
> Date: Sun, 2 Feb 2020 13:22:52 +0200
>
> > This patch to handle the asynchronous unregister device event so the
> > device tls offload resources could be cleanly released.
> >
> > Fixes: e8f69799810c ("net/tls: Add generic NIC offload
> > infrastructure")
> > Signed-off-by: Raed Salem <raeds@mellanox.com>
> > Reviewed-by: Tariq Toukan <tariqt@mellanox.com>
> > Reviewed-by: Saeed Mahameed <saeedm@mellanox.com>
>
> As per Jakub's feedback, only devices which are UP can have TLS rules
> installed to them.
>
> Therefore we will always get the NETDEV_DOWN event first, to release the
> TLS resources.
>
> So I am tossing this patch. If there is a real problem, you must describe it in
> detail in the commit message.
prev parent reply other threads:[~2020-02-04 13:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-02 11:22 [PATCH net] tls: handle NETDEV_UNREGISTER for tls device Raed Salem
2020-02-02 19:48 ` Jakub Kicinski
2020-02-04 11:30 ` David Miller
2020-02-04 13:07 ` Raed Salem [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM0PR05MB52507339607E5BF60372A878C4030@AM0PR05MB5250.eurprd05.prod.outlook.com \
--to=raeds@mellanox.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).