From: Andy Duan <fugang.duan@nxp.com>
To: "Fuzzey, Martin" <martin.fuzzey@flowbird.group>
Cc: "David S. Miller" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: RE: [EXT] Re: [PATCH net 1/4] net: ethernet: fec: move GPR register offset and bit into DT
Date: Mon, 25 May 2020 02:36:29 +0000 [thread overview]
Message-ID: <AM6PR0402MB36074B1C1417EBBE0B58FBC7FFB30@AM6PR0402MB3607.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <CANh8QzxuHAu+L0swPC5V4Oca21Z5zpiULTm22VPShX_T-JVznQ@mail.gmail.com>
From: Fuzzey, Martin <martin.fuzzey@flowbird.group> Sent: Saturday, May 23, 2020 5:56 PM
> Hi Andy,
>
> > Fixes: da722186f654(net: fec: set GPR bit on suspend by DT
> > configuration)
>
> Just a nitpick maybe but I don't really think this need as Fixes: tag.
> That commit didn't actually *break* anything AFAIK.
> It added WoL support for *some* SoCs that didn't have any in mainline and
> didn't hurt the others.
> Of course it turned out to be insufficient for the multiple FEC case so this
> patch series is a welcome improvement.
Sorry, not to hurt you intentionally, I think the commit da722186f654 break multiple instances.
Totally I accept your suggestion, it should be improvement !
>
>
> > struct fec_devinfo {
> > u32 quirks;
> > - u8 stop_gpr_reg;
> > - u8 stop_gpr_bit;
> > };
>
> This structure has become redundant now that it only contains a single
> u32 quirks field.
> So we *could* go back to storing the quirks bitmask directly in .driver_data as
> was done before.
>
> It's a slight wastage to keep the, now unnecessary, indirection, though the
> size impact is small and it's only used at probe() time not on a hot path.
>
> But switching back could be seen as code churn too...
>
> I don't have a strong opinion on this, so just noting it to see what others think.
>
> Martin
To make code clean, we should switch back. I will change it in V2.
Thanks again for your review.
next prev parent reply other threads:[~2020-05-25 2:36 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 8:31 [PATCH net 0/4] net: ethernet: fec: move GPR reigster offset and bit into DT fugang.duan
2020-05-20 8:31 ` [PATCH net 1/4] net: ethernet: fec: move GPR register " fugang.duan
2020-05-20 16:54 ` Jakub Kicinski
2020-05-21 2:40 ` [EXT] " Andy Duan
2020-05-23 9:55 ` Fuzzey, Martin
2020-05-25 2:36 ` Andy Duan [this message]
2020-05-20 8:31 ` [PATCH net 2/4] dt-bindings: fec: update the gpr property fugang.duan
2020-05-23 10:15 ` Fuzzey, Martin
2020-05-25 3:16 ` [EXT] " Andy Duan
2020-05-20 8:31 ` [PATCH net 3/4] ARM: dts: imx6: update fec gpr property to match new format fugang.duan
2020-05-20 17:03 ` Andrew Lunn
2020-05-21 3:15 ` [EXT] " Andy Duan
2020-05-21 13:07 ` Andrew Lunn
2020-05-22 1:01 ` Andy Duan
2020-05-22 18:02 ` Fuzzey, Martin
2020-05-22 23:50 ` Andrew Lunn
2020-05-25 2:32 ` Andy Duan
2020-05-25 2:29 ` Andy Duan
2020-05-20 8:31 ` [PATCH net 4/4] ARM: dts: imx6qdl-sabresd: enable fec wake-on-lan fugang.duan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM6PR0402MB36074B1C1417EBBE0B58FBC7FFB30@AM6PR0402MB3607.eurprd04.prod.outlook.com \
--to=fugang.duan@nxp.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=martin.fuzzey@flowbird.group \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).