From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2AB9C169C4 for ; Mon, 11 Feb 2019 20:43:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A6B422084D for ; Mon, 11 Feb 2019 20:43:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b="NsjA7JrI" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727254AbfBKUne (ORCPT ); Mon, 11 Feb 2019 15:43:34 -0500 Received: from mail-eopbgr30046.outbound.protection.outlook.com ([40.107.3.46]:32288 "EHLO EUR03-AM5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726212AbfBKUnd (ORCPT ); Mon, 11 Feb 2019 15:43:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qyC51DTLcS6X14SSKIkvmYiHEttQ46/F1RZTLQ3y/tc=; b=NsjA7JrIhy06HjHBTP/7kDWmIazchClIcpdDwUM/kSNCdXXjKWxL/YKUvhzsQDAwGArjvTk4zBDouUS064QErtvQV6nh7hFtCLxLDTgUES2oXlYKXGchzpBbiZhVbQaHQzCKeDiQv+5TeVfTg7+Cg6zUSYu5WWUlzYM/u8Q3CnY= Received: from AM6PR04MB5863.eurprd04.prod.outlook.com (20.179.1.11) by AM6PR04MB5765.eurprd04.prod.outlook.com (20.179.2.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1601.19; Mon, 11 Feb 2019 20:43:30 +0000 Received: from AM6PR04MB5863.eurprd04.prod.outlook.com ([fe80::6c22:d122:2edf:d948]) by AM6PR04MB5863.eurprd04.prod.outlook.com ([fe80::6c22:d122:2edf:d948%5]) with mapi id 15.20.1601.023; Mon, 11 Feb 2019 20:43:30 +0000 From: Leo Li To: Shawn Guo , Pankaj Bansal CC: Andrew Lunn , Florian Fainelli , "netdev@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: RE: [PATCH v3] arm64: dts: lx2160aqds: Add mdio mux nodes Thread-Topic: [PATCH v3] arm64: dts: lx2160aqds: Add mdio mux nodes Thread-Index: AQHUvgABt0FSxwLfGkq2pK/QIZ0c6qXZ788AgAEnJsA= Date: Mon, 11 Feb 2019 20:43:30 +0000 Message-ID: References: <20190206150520.9683-1-pankaj.bansal@nxp.com> <20190211030010.GI22487@dragon> In-Reply-To: <20190211030010.GI22487@dragon> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=leoyang.li@nxp.com; x-originating-ip: [64.157.242.222] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;AM6PR04MB5765;6:slX+dpNrDUzwhJenUiQau4Q/90GgEdG4DviYvXaGTp4iTzQILqIdp2Yv0DCIhuRodA+iCTtwwfjqK4tYhCbMwgFyJXX/xb0mxWI8q2J6i3YcOptyquy6QPDI1qs8Bgr3ec88+FDe6oLCNngdMFZ0gtntYVb4hZXxBdE9bvb54pCfetbx6Wx21HFM2H05MW6//c3zgXU5Rw0maYvaA63zyeu+xlHzsy79gzx2zk3T5mAsMd5geiXWkAFug4UwsegJ+bwFdu0wktwF+FpF17KMtsdWVPQ3g6vPNcUSpY37HG3WSKbCwGlBwYMG/cpIOvVzj4rBkgr9uA9kiN5JfXmcTNqnjgNqISUqe8+vwUSiV5RgELsNrBqVKLcXindEUSbiu75VG8COCpuehHfW5epDwnjV+jOU9x8QYJ+MdoIahMZAkkngI4XgkcJGam5n6dF28ZEnioWVcjIpvn5hF1WN4w==;5:oC7fJAWHLe9zWj9HygQHLSwlj99Z7QHKEO6qpGR2D580KZylY0on4Hl+EM9JYVvp9MhxGCSQ47r4jSvtJL+oUXuGIomK/2Q2jyq3KmGpTKsX4DTTjaEEnrB17ZwZyMmmG66J8sfNOh1oimsN5onc6hDwxhQLoikq4OaBp0gAw64dMm/xOGb3hQxuZijZHUwnsWSIDwRu9VoM3Q2c2Cwgsg==;7:un7LXa3g567Q3DdmhrMPVPozVV55U4CHjR9wRbOLLSBvf2ZC4uWKqZ2cSwCwZs+t1yVEAH0xS4a05A8oZB6rA4juflG9pxuK3fXp8u5qPybxdccWJBlZsHn3uQBu/Z0xlvxe7YSvXTbx9u4vaXx03g== x-ms-office365-filtering-correlation-id: 7a45e2c3-e03b-4f0a-e032-08d6906194cc x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600110)(711020)(4605077)(4618075)(2017052603328)(7153060)(7193020);SRVR:AM6PR04MB5765; x-ms-traffictypediagnostic: AM6PR04MB5765: x-microsoft-antispam-prvs: x-forefront-prvs: 0945B0CC72 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(396003)(136003)(376002)(346002)(366004)(39860400002)(199004)(189003)(13464003)(7696005)(478600001)(9686003)(102836004)(6506007)(106356001)(53546011)(26005)(256004)(55016002)(186003)(110136005)(86362001)(54906003)(316002)(6436002)(6636002)(8936002)(14444005)(105586002)(446003)(7736002)(76176011)(305945005)(11346002)(6116002)(476003)(14454004)(229853002)(68736007)(66066001)(74316002)(53936002)(486006)(25786009)(2906002)(81156014)(99286004)(33656002)(4326008)(8676002)(81166006)(71200400001)(6246003)(71190400001)(3846002)(97736004);DIR:OUT;SFP:1101;SCL:1;SRVR:AM6PR04MB5765;H:AM6PR04MB5863.eurprd04.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: MgWJCxUVcKIBtMMeqdbtwqhsA4jPZiKazdxzUcuT2XmJk8sFWtGTNmqW6W9M/N+bb6vLoER5FFHHR+kPZN1nUeY3nTUXlme/pw47bf1Vgzd788OTjg6TTVZzho/rYPR9C0oHtW4IChDunT+cHTovHVR9OP8Hx2jvtd2sDZ403+oI1OUSwspnwtHl61RxYD/DEgjs1G21RWgncBlnU8rGimCTyR6dCJcAHojpEAtKFVGWi9Ni3s2N1HLkLweMsEVvbSO+GGOGmcgBg4ZGyd6TtKnsmYpxLn8xQadwaQ/4CkASBCUfp1bkTfOVl2ptImWnTlGIwuQw7KcdX74F+We6+8osdN+dZg5v+6BedCcjzM9h8ToeFIATK9iDAiEOlGxWib54ubhN9Y+oJmQidhs+qziXQQOec3zr3AO3mzPqtzY= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7a45e2c3-e03b-4f0a-e032-08d6906194cc X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Feb 2019 20:43:30.1415 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB5765 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > -----Original Message----- > From: Shawn Guo > Sent: Sunday, February 10, 2019 9:00 PM > To: Pankaj Bansal > Cc: Leo Li ; Andrew Lunn ; Florian > Fainelli ; netdev@vger.kernel.org; linux-arm- > kernel@lists.infradead.org > Subject: Re: [PATCH v3] arm64: dts: lx2160aqds: Add mdio mux nodes >=20 > On Wed, Feb 06, 2019 at 09:40:33AM +0000, Pankaj Bansal wrote: > > The two external MDIO buses used to communicate with phy devices that > > are external to SOC are muxed in LX2160AQDS board. > > > > These buses can be routed to any one of the eight IO slots on > > LX2160AQDS board depending on value in fpga register 0x54. > > > > Additionally the external MDIO1 is used to communicate to the onboard > > RGMII phy devices. > > > > The mdio1 is controlled by bits 4-7 of fpga register and mdio2 is > > controlled by bits 0-3 of fpga register. > > > > Signed-off-by: Pankaj Bansal > > --- > > > > Notes: > > V3: > > - Add status =3D disabled in soc file and status =3D okay in board = file > > for external MDIO nodes > > - Add interrupts property in external mdio nodes in soc file > > V2: > > - removed unnecassary TODO statements > > - removed device_type from mdio nodes > > - change the case of hex number to lowercase > > - removed board specific comments from soc file > > > > .../boot/dts/freescale/fsl-lx2160a-qds.dts | 123 +++++++++++++++++ > > .../boot/dts/freescale/fsl-lx2160a.dtsi | 22 +++ > > 2 files changed, 145 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts > > b/arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts > > index 99a22abbe725..079264b391a2 100644 > > --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts > > +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts > > @@ -35,6 +35,14 @@ > > status =3D "okay"; > > }; > > > > +&emdio1 { > > + status =3D "okay"; > > +}; > > + > > +&emdio2 { > > + status =3D "okay"; > > +}; > > + > > &esdhc0 { > > status =3D "okay"; > > }; > > @@ -46,6 +54,121 @@ > > &i2c0 { > > status =3D "okay"; > > > > + fpga@66 { > > + compatible =3D "fsl,lx2160aqds-fpga", "fsl,fpga-qixis-i2c"; > > + reg =3D <0x66>; > > + #address-cells =3D <1>; > > + #size-cells =3D <0>; > > + > > + mdio-mux-1@54 { > > + mdio-parent-bus =3D <&emdio1>; > > + reg =3D <0x54>; /* BRDCFG4 */ > > + mux-mask =3D <0xf8>; /* EMI1_MDIO */ > > + #address-cells=3D<1>; > > + #size-cells =3D <0>; > > + > > + mdio@0 { > > + reg =3D <0x00>; > > + #address-cells =3D <1>; > > + #size-cells =3D <0>; > > + }; >=20 > Please have a newline between nodes. It doesn't deserve a respin though.= I > can fix them up when applying if Leo is fine with this version. I think there should be a compatible string defined for the binding of pare= nt node mdio-mux, probably "mdio-mux-regmap", and be used here in the devic= e tree. >=20 > Shawn >=20 > > + mdio@40 { > > + reg =3D <0x40>; > > + #address-cells =3D <1>; > > + #size-cells =3D <0>; > > + }; > > + mdio@c0 { > > + reg =3D <0xc0>; > > + #address-cells =3D <1>; > > + #size-cells =3D <0>; > > + }; > > + mdio@c8 { > > + reg =3D <0xc8>; > > + #address-cells =3D <1>; > > + #size-cells =3D <0>; > > + }; > > + mdio@d0 { > > + reg =3D <0xd0>; > > + #address-cells =3D <1>; > > + #size-cells =3D <0>; > > + }; > > + mdio@d8 { > > + reg =3D <0xd8>; > > + #address-cells =3D <1>; > > + #size-cells =3D <0>; > > + }; > > + mdio@e0 { > > + reg =3D <0xe0>; > > + #address-cells =3D <1>; > > + #size-cells =3D <0>; > > + }; > > + mdio@e8 { > > + reg =3D <0xe8>; > > + #address-cells =3D <1>; > > + #size-cells =3D <0>; > > + }; > > + mdio@f0 { > > + reg =3D <0xf0>; > > + #address-cells =3D <1>; > > + #size-cells =3D <0>; > > + }; > > + mdio@f8 { > > + reg =3D <0xf8>; > > + #address-cells =3D <1>; > > + #size-cells =3D <0>; > > + }; > > + }; > > + > > + mdio-mux-2@54 { > > + mdio-parent-bus =3D <&emdio2>; > > + reg =3D <0x54>; /* BRDCFG4 */ > > + mux-mask =3D <0x07>; /* EMI2_MDIO */ > > + #address-cells=3D<1>; > > + #size-cells =3D <0>; > > + > > + mdio@0 { > > + reg =3D <0x00>; > > + #address-cells =3D <1>; > > + #size-cells =3D <0>; > > + }; > > + mdio@1 { > > + reg =3D <0x01>; > > + #address-cells =3D <1>; > > + #size-cells =3D <0>; > > + }; > > + mdio@2 { > > + reg =3D <0x02>; > > + #address-cells =3D <1>; > > + #size-cells =3D <0>; > > + }; > > + mdio@3 { > > + reg =3D <0x03>; > > + #address-cells =3D <1>; > > + #size-cells =3D <0>; > > + }; > > + mdio@4 { > > + reg =3D <0x04>; > > + #address-cells =3D <1>; > > + #size-cells =3D <0>; > > + }; > > + mdio@5 { > > + reg =3D <0x05>; > > + #address-cells =3D <1>; > > + #size-cells =3D <0>; > > + }; > > + mdio@6 { > > + reg =3D <0x06>; > > + #address-cells =3D <1>; > > + #size-cells =3D <0>; > > + }; > > + mdio@7 { > > + reg =3D <0x07>; > > + #address-cells =3D <1>; > > + #size-cells =3D <0>; > > + }; > > + }; > > + }; > > + > > i2c-mux@77 { > > compatible =3D "nxp,pca9547"; > > reg =3D <0x77>; > > diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi > > b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi > > index a79f5c1ea56d..7def5252ac1a 100644 > > --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi > > +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi > > @@ -762,5 +762,27 @@ > > ; > > dma-coherent; > > }; > > + > > + /* WRIOP0: 0x8b8_0000, E-MDIO1: 0x1_6000 */ > > + emdio1: mdio@8b96000 { > > + compatible =3D "fsl,fman-memac-mdio"; > > + reg =3D <0x0 0x8b96000 0x0 0x1000>; > > + interrupts =3D ; > > + #address-cells =3D <1>; > > + #size-cells =3D <0>; > > + little-endian; /* force the driver in LE mode */ > > + status =3D "disabled"; > > + }; > > + > > + /* WRIOP0: 0x8b8_0000, E-MDIO2: 0x1_7000 */ > > + emdio2: mdio@8b97000 { > > + compatible =3D "fsl,fman-memac-mdio"; > > + reg =3D <0x0 0x8b97000 0x0 0x1000>; > > + interrupts =3D ; > > + #address-cells =3D <1>; > > + #size-cells =3D <0>; > > + little-endian; /* force the driver in LE mode */ > > + status =3D "disabled"; > > + }; > > }; > > }; > > -- > > 2.17.1 > >