RE: [EXT] [PATCH 2/3] net: stmmac: Add NXP S32 SoC family support

From: "Jan Petrous (OSS)" <jan.petrous@oss.nxp.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	"Jan Petrous (OSS)" <jan.petrous@oss.nxp.com>,
	Wadim Mueller <wafgo01@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Paolo Abeni" <pabeni@redhat.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Shawn Guo" <shawnguo@kernel.org>,
	"Sascha Hauer" <s.hauer@pengutronix.de>,
	"Pengutronix Kernel Team" <kernel@pengutronix.de>,
	"Fabio Estevam" <festevam@gmail.com>,
	dl-linux-imx <linux-imx@nxp.com>,
	"Chester Lin" <chester62515@gmail.com>,
	"Andreas Färber" <afaerber@suse.de>,
	"Matthias Brugger" <mbrugger@suse.com>, dl-S32 <S32@nxp.com>,
	"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
	"Jose Abreu" <joabreu@synopsys.com>,
	"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
	"Michael Turquette" <mturquette@baylibre.com>,
	"Stephen Boyd" <sboyd@kernel.org>,
	"Richard Cochran" <richardcochran@gmail.com>,
	"Andrew Halaney" <ahalaney@redhat.com>,
	"Simon Horman" <horms@kernel.org>,
	"Bartosz Golaszewski" <bartosz.golaszewski@linaro.org>,
	"Johannes Zink" <j.zink@pengutronix.de>,
	"Shenwei Wang" <shenwei.wang@nxp.com>,
	"Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>,
	"Swee Leong Ching" <leong.ching.swee@intel.com>,
	"Giuseppe Cavallaro" <peppe.cavallaro@st.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-stm32@st-md-mailman.stormreply.com"
	<linux-stm32@st-md-mailman.stormreply.com>,
	"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>
Subject: RE: [EXT] [PATCH 2/3] net: stmmac: Add NXP S32 SoC family support
Date: Mon, 18 Mar 2024 07:54:56 +0000	[thread overview]
Message-ID: <AM9PR04MB85061D806B61A9C299E4E026E22D2@AM9PR04MB8506.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <3ce9cf8e-f8d0-4de5-b5b7-1060f77321eb@linaro.org>

> On 17/03/2024 19:26, Jan Petrous (OSS) wrote:
> >> Add support for NXP S32 SoC family's GMAC to the stmmac network driver.
> >> This driver implementation is based on the patchset originally contributed
> by
> >> Chester Lin [1], which itself draws heavily from NXP's downstream
> >> implementation [2]. The patchset was never merged.
> >>
> >
> > Hi Wadim,
> >
> > Thank you for your upstreaming activities, but I would like to note that
> > the old NXP S32CC  stmmac glue was rewritten lately and will be part of next
> > NXP BSP Linux release planned for April.
> >
> > The rework was done mainly to allow simpler upstreaming process, so I
> would recommend
> > to postpone your current work.
> 
> I suggest you working with upstream first instead of claiming that
> upstream contributions should align with your downstream work. To be
> clear: your downstream NXP BSP does not matter.

Thanks for the suggestion. My intention was not to offend somebody
or break any upstreaming work, sorry if it could sound like this. 

> 
> If you think this submission needs any particular changes, then please
> comment on specifics, but such broad statement that community should
> wait till NXP will be so kind to allow upstream work is just not acceptable.
> 

Ok, I will contact Wadim directly.

BR.
/Jan