From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9ADAC2BA19 for ; Tue, 21 Apr 2020 04:50:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AEE032084D for ; Tue, 21 Apr 2020 04:50:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726370AbgDUEuW convert rfc822-to-8bit (ORCPT ); Tue, 21 Apr 2020 00:50:22 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:36596 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725881AbgDUEuV (ORCPT ); Tue, 21 Apr 2020 00:50:21 -0400 Received: from mail-pf1-f197.google.com ([209.85.210.197]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1jQkrS-0005jS-FN for netdev@vger.kernel.org; Tue, 21 Apr 2020 04:50:18 +0000 Received: by mail-pf1-f197.google.com with SMTP id o5so12181243pfp.0 for ; Mon, 20 Apr 2020 21:50:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=iS1UqusYi3xL6rontdMWpTi7+P7gRt1tPUDk5laBrGI=; b=tKFAq8ySAi/toud6K1GxWhaszEYRtZQ0mLgd5Fcz3BAUyWo3RsVR+1FFPn4PHrwMUb /6gjgG1n/NuCEYMoqCI+yVs/nHxM4zjprwS2tQdAwR0Zi4fF6YTjMGZKyQmvCtPry/wK 0N8Xj4r6RHFp23Z6lML7pfKz8XvA28WUJo9khlmApZGhbc7PnGxvwIbxltlDCChQfT5R h6b53DHxh77x7+fDaFGnbWTPwfrHYPgdLPSTyDuDsyxNT/RIJjlOoSyDgPG614O7iJPl q53ev6dXNZp5REI0Yk1ZoqpaVAgG20i4brJjHETghFhFHjPMQ0/0vmgpt48b5kNX4V/i lp9g== X-Gm-Message-State: AGi0PuYh0FyfeACPoq0/P0AYEDmZq9EOb+GH/Ii8zUYUSdbHp9+i6/8O Y9kDBhgdtiTs6boPbNxcQeQw131Kzm11uPRSD0Zg9Ui+nCzn4VNJ/ARMfQ6YdgAQYcwutOXSc4+ SgTcK6WTRE82iskeorxSmBYvCJhlO81QCfw== X-Received: by 2002:a17:90a:f0d0:: with SMTP id fa16mr3510959pjb.33.1587444616958; Mon, 20 Apr 2020 21:50:16 -0700 (PDT) X-Google-Smtp-Source: APiQypKfsgLW5biYAE7aJIxYYYswHrd1wjHYn1DgSe813w7otCrIz5NawzqPd2rFsLGlvqqwbtuFfg== X-Received: by 2002:a17:90a:f0d0:: with SMTP id fa16mr3510934pjb.33.1587444616480; Mon, 20 Apr 2020 21:50:16 -0700 (PDT) Received: from [192.168.1.208] (220-133-187-190.HINET-IP.hinet.net. [220.133.187.190]) by smtp.gmail.com with ESMTPSA id o1sm1007174pjs.39.2020.04.20.21.50.14 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 20 Apr 2020 21:50:15 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.80.23.2.2\)) Subject: Re: [Intel-wired-lan] [PATCH 1/1] e1000e: Disable s0ix flow for X1 Carbon 7th From: Kai-Heng Feng In-Reply-To: Date: Tue, 21 Apr 2020 12:50:12 +0800 Cc: "Kirsher, Jeffrey T" , "open list:NETWORKING DRIVERS" , "moderated list:INTEL ETHERNET DRIVERS" , "David S. Miller" , open list Content-Transfer-Encoding: 8BIT Message-Id: References: <20200319052629.7282-1-kai.heng.feng@canonical.com> To: "Brown, Aaron F" X-Mailer: Apple Mail (2.3608.80.23.2.2) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi, > On Apr 21, 2020, at 04:27, Brown, Aaron F wrote: > >> From: Intel-wired-lan On Behalf Of Kai- >> Heng Feng >> Sent: Wednesday, March 18, 2020 10:26 PM >> To: Kirsher, Jeffrey T >> Cc: open list:NETWORKING DRIVERS ; Kai-Heng Feng >> ; moderated list:INTEL ETHERNET DRIVERS >> ; David S. Miller ; >> open list >> Subject: [Intel-wired-lan] [PATCH 1/1] e1000e: Disable s0ix flow for X1 Carbon >> 7th >> >> The s0ix flow makes X1 Carbon 7th can only run S2Idle for only once. >> >> Temporarily disable it until Intel found a solution. >> >> Link: https://lists.osuosl.org/pipermail/intel-wired-lan/Week-of-Mon- >> 20200316/019222.html >> BugLink: https://bugs.launchpad.net/bugs/1865570 >> Signed-off-by: Kai-Heng Feng >> --- >> drivers/net/ethernet/intel/e1000e/netdev.c | 16 ++++++++++++++-- >> 1 file changed, 14 insertions(+), 2 deletions(-) > > I do not have access to the "X1 Carbon 7th" this patch targets, but from a regression perspective against a number of other e1000e based parts: This patch can be superseded by "e1000e: bump up timeout to wait when ME un-configure ULP mode". So it's better to drop this patch in favor of a more generic solution. Kai-Heng > Tested-by: Aaron Brown