From: <Yuiko.Oshino@microchip.com>
To: <davem@davemloft.net>
Cc: <davem@devemloft.net>, <UNGLinuxDriver@microchip.com>,
<netdev@vger.kernel.org>
Subject: RE: [PATCH net] net: phy: microchip_t1: add lan87xx_phy_init to initialize the lan87xx phy.
Date: Mon, 30 Mar 2020 13:55:09 +0000 [thread overview]
Message-ID: <BL0PR11MB28976D2B5BB9A7CCCE5C99608ECB0@BL0PR11MB2897.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200321.201223.902296361952119725.davem@davemloft.net>
>From: David Miller <davem@davemloft.net>
>Sent: Saturday, March 21, 2020 11:12 PM
>
>From: Yuiko Oshino <yuiko.oshino@microchip.com>
>Date: Tue, 17 Mar 2020 15:08:38 -0400
>
>> lan87xx_phy_init() initializes the lan87xx phy.
>>
>> fixes: 3e50d2da5850 ("Add driver for Microchip LAN87XX T1 PHYs")
>> Signed-off-by: Yuiko Oshino <yuiko.oshino@microchip.com>
>
>"Fixes: " should be capitalized.
>
>You commit message is way too terse.
>
>> + static const struct access_ereg_val init[] = {
>> + {PHYACC_ATTR_MODE_WRITE, PHYACC_ATTR_BANK_AFE, 0x0B,
>0x000A},
>> + {PHYACC_ATTR_MODE_READ, PHYACC_ATTR_BANK_MISC, 0x8, 0},
>> + {PHYACC_ATTR_MODE_WRITE, PHYACC_ATTR_BANK_MISC, 0x8, 0},
>> + {PHYACC_ATTR_MODE_WRITE, PHYACC_ATTR_BANK_MISC, 0x10,
>0x0009},
>> + {PHYACC_ATTR_MODE_WRITE, PHYACC_ATTR_BANK_SMI, 0x17, 0},
>> + /* TC10 Config */
>> + {PHYACC_ATTR_MODE_WRITE, PHYACC_ATTR_BANK_MISC, 0x20,
>0x0023},
>> + {PHYACC_ATTR_MODE_WRITE, PHYACC_ATTR_BANK_PCS, 0x20,
>0x3C3C},
>> + {PHYACC_ATTR_MODE_WRITE, PHYACC_ATTR_BANK_MISC, 0x21,
>0x274F},
>> + {PHYACC_ATTR_MODE_WRITE, PHYACC_ATTR_BANK_MISC, 0x20,
>0x80A7},
>> + {PHYACC_ATTR_MODE_WRITE, PHYACC_ATTR_BANK_MISC, 0x24,
>0x9110},
>> + {PHYACC_ATTR_MODE_WRITE, PHYACC_ATTR_BANK_MISC, 0x20,
>0x0087},
>> + /* HW Init */
>> + {PHYACC_ATTR_MODE_WRITE, PHYACC_ATTR_BANK_SMI, 0x1A,
>0x0300},
>> + };
>
>What do these registers do, and what do the values programmed into them do?
>
>If you don't know, how can you know if this code is correct?
>
>You must document this as much as possible.
>
>Thank you.
Hi David,
Thank you for your comments.
I will improve and submit v1.
The initialization scripts also will be changed as our hardware engineers updated them.
Thank you.
Yuiko
prev parent reply other threads:[~2020-03-30 13:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-17 19:08 [PATCH net] net: phy: microchip_t1: add lan87xx_phy_init to initialize the lan87xx phy Yuiko Oshino
2020-03-22 3:12 ` David Miller
2020-03-30 13:55 ` Yuiko.Oshino [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BL0PR11MB28976D2B5BB9A7CCCE5C99608ECB0@BL0PR11MB2897.namprd11.prod.outlook.com \
--to=yuiko.oshino@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=davem@davemloft.net \
--cc=davem@devemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).