From: Jose Abreu <Jose.Abreu@synopsys.com>
To: David Miller <davem@davemloft.net>,
"jakub.kicinski@netronome.com" <jakub.kicinski@netronome.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Joao.Pinto@synopsys.com" <Joao.Pinto@synopsys.com>,
"peppe.cavallaro@st.com" <peppe.cavallaro@st.com>,
"alexandre.torgue@st.com" <alexandre.torgue@st.com>,
"mcoquelin.stm32@gmail.com" <mcoquelin.stm32@gmail.com>,
"linux-stm32@st-md-mailman.stormreply.com"
<linux-stm32@st-md-mailman.stormreply.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH net-next v2 04/12] net: stmmac: Add Split Header support and enable it in XGMAC cores
Date: Tue, 13 Aug 2019 08:30:47 +0000 [thread overview]
Message-ID: <BN8PR12MB3266B9314CF13A9140A72354D3D20@BN8PR12MB3266.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20190812.140618.1288127671943783439.davem@davemloft.net>
++ Jakub
From: David Miller <davem@davemloft.net>
Date: Aug/12/2019, 22:06:18 (UTC+00:00)
> From: Jose Abreu <Jose.Abreu@synopsys.com>
> Date: Mon, 12 Aug 2019 11:44:03 +0200
>
> > - Add performance info (David)
>
> Ummm...
>
> Whilst cpu utilization is interesting, I might be mainly interested in
> how this effects "networking" performance. I find it very surprising
> that it isn't obvious that this is what I wanted.
>
> Do you not do performance testing on the networking level when you
> make fundamental changes to how packets are processed by the
> hardware/driver?
I do.
In my HW this feature does not impact performance neither improves it as
I'm already on max of theoretical bandwidth.
I do expect it to reduce CPU usage and memory footprint because we no
longer have to memcpy the entire buffer to SKB and instead we just copy
the header and then append payload as page which is passed directly to
net layer.
This feature is already used in some drivers and is part of GRO
offloading I think.
Jakub, as David is off can you please comment on how can we proceed with
this series ? I can add more information in commit log for this patch
...
---
Thanks,
Jose Miguel Abreu
next prev parent reply other threads:[~2019-08-13 8:30 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-12 9:43 [PATCH net-next v2 00/12] net: stmmac: Improvements for -next Jose Abreu
2019-08-12 9:44 ` [PATCH net-next v2 01/12] net: stmmac: Get correct timestamp values from XGMAC Jose Abreu
2019-08-13 20:57 ` Jakub Kicinski
2019-08-12 9:44 ` [PATCH net-next v2 02/12] net: stmmac: Prepare to add Split Header support Jose Abreu
2019-08-13 21:11 ` Jakub Kicinski
2019-08-12 9:44 ` [PATCH net-next v2 03/12] net: stmmac: xgmac: Correctly return that RX descriptor is not last one Jose Abreu
2019-08-12 9:44 ` [PATCH net-next v2 04/12] net: stmmac: Add Split Header support and enable it in XGMAC cores Jose Abreu
2019-08-12 21:06 ` David Miller
2019-08-13 8:30 ` Jose Abreu [this message]
2019-08-12 9:44 ` [PATCH net-next v2 05/12] net: stmmac: Add a counter for Split Header packets Jose Abreu
2019-08-12 9:44 ` [PATCH net-next v2 06/12] net: stmmac: dwxgmac: Add Flexible PPS support Jose Abreu
2019-08-12 9:44 ` [PATCH net-next v2 07/12] net: stmmac: Add ethtool register dump for XGMAC cores Jose Abreu
2019-08-13 21:19 ` Jakub Kicinski
2019-08-12 9:44 ` [PATCH net-next v2 08/12] net: stmmac: Add support for SA Insertion/Replacement in " Jose Abreu
2019-08-12 9:44 ` [PATCH net-next v2 09/12] net: stmmac: selftests: Add tests for SA Insertion/Replacement Jose Abreu
2019-08-12 9:44 ` [PATCH net-next v2 10/12] net: stmmac: xgmac: Add EEE support Jose Abreu
2019-08-12 9:44 ` [PATCH net-next v2 11/12] net: stmmac: Add support for VLAN Insertion Offload Jose Abreu
2019-08-12 9:44 ` [PATCH net-next v2 12/12] net: stmmac: selftests: Add selftest for VLAN TX Offload Jose Abreu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN8PR12MB3266B9314CF13A9140A72354D3D20@BN8PR12MB3266.namprd12.prod.outlook.com \
--to=jose.abreu@synopsys.com \
--cc=Joao.Pinto@synopsys.com \
--cc=alexandre.torgue@st.com \
--cc=davem@davemloft.net \
--cc=jakub.kicinski@netronome.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).