From: Jose Abreu <Jose.Abreu@synopsys.com>
To: "Chng, Jack Ping" <jack.ping.chng@linux.intel.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Joao Pinto <Joao.Pinto@synopsys.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: Re:[RFC net-next] net: phy: Add basic support for Synopsys XPCS using a PHY driver
Date: Mon, 9 Mar 2020 09:22:12 +0000 [thread overview]
Message-ID: <BN8PR12MB3266C896974574439AFEA0D6D3FE0@BN8PR12MB3266.namprd12.prod.outlook.com> (raw)
In-Reply-To: <99652f12-c7b4-756d-d169-4770cf1f0d96@linux.intel.com>
From: Chng, Jack Ping <jack.ping.chng@linux.intel.com>
Date: Feb/04/2020, 09:41:35 (UTC+00:00)
> Currently our network SoC has something like this:
> XGMAC-> XPCS -> Combo PHY -> PHY
>
> In the xpcs driver probe(), get and calibrate the phy:
>
> priv->phy = devm_phy_get(&pdev->dev, "phy");
> if (IS_ERR(priv->phy)) {
> dev_warn(dev, "No phy\n");
> return PTR_ERR(priv->phy);
> }
>
> ret = phy_init(priv->phy);
> if (ret)
> return ret;
>
> ret = phy_power_on(priv->phy);
> if (ret) {
> phy_exit(priv->phy);
> return ret;
> }
> ret = phy_calibrate(priv->phy);
> if (ret) {
> phy_exit(priv->phy);
> return ret;
> }
>
> xpcs driver needs to handle phy or phy_device depending on the phy?
Apologies for the delayed answer.
I think XPCS should be agnostic of PHY so this should be handled by stmmac
core and
PHYLINK.
I submitted a new series: https://patchwork.ozlabs.org/project/netdev/list/?series=163171
Can you please test it ?
---
Thanks,
Jose Miguel Abreu
next prev parent reply other threads:[~2020-03-09 9:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-13 13:11 [RFC net-next] net: phy: Add basic support for Synopsys XPCS using a PHY driver Jose Abreu
2020-01-13 13:38 ` Andrew Lunn
2020-01-13 13:54 ` Jose Abreu
2020-01-13 14:18 ` Russell King - ARM Linux admin
2020-01-13 14:27 ` Jose Abreu
2020-01-13 14:55 ` Vladimir Oltean
2020-01-13 15:05 ` Jose Abreu
2020-01-13 14:50 ` Vladimir Oltean
2020-01-13 15:09 ` Russell King - ARM Linux admin
2020-01-20 10:31 ` Jose Abreu
2020-01-20 10:50 ` Russell King - ARM Linux admin
2020-01-20 11:07 ` Jose Abreu
2020-01-20 11:39 ` Russell King - ARM Linux admin
[not found] ` <e942b414-08bd-0305-9128-26666a7a5d5a@linux.intel.com>
2020-02-04 9:41 ` Chng, Jack Ping
2020-03-09 9:22 ` Jose Abreu [this message]
2020-01-13 13:42 ` [RFC " Andy Shevchenko
2020-01-13 14:07 ` Jose Abreu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN8PR12MB3266C896974574439AFEA0D6D3FE0@BN8PR12MB3266.namprd12.prod.outlook.com \
--to=jose.abreu@synopsys.com \
--cc=Joao.Pinto@synopsys.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=jack.ping.chng@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).