From: Parav Pandit <parav@nvidia.com>
To: David Ahern <dsahern@gmail.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"kuba@kernel.org" <kuba@kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Cc: Jiri Pirko <jiri@nvidia.com>
Subject: RE: [PATCH net-next v2 4/8] devlink: Support get and set state of port function
Date: Fri, 18 Sep 2020 03:30:45 +0000 [thread overview]
Message-ID: <BY5PR12MB4322ACBFC1F5C2C0CF694BFCDC3F0@BY5PR12MB4322.namprd12.prod.outlook.com> (raw)
In-Reply-To: <88de7791-2a50-64b1-6e3d-5c1a8235eb96@gmail.com>
> From: David Ahern <dsahern@gmail.com>
> Sent: Friday, September 18, 2020 1:54 AM
>
> On 9/17/20 11:20 AM, Parav Pandit wrote:
> > diff --git a/net/core/devlink.c b/net/core/devlink.c index
> > d152489e48da..c82098cb75da 100644
> > --- a/net/core/devlink.c
> > +++ b/net/core/devlink.c
> > @@ -595,6 +598,40 @@ devlink_port_function_hw_addr_fill(struct devlink
> *devlink, const struct devlink
> > return 0;
> > }
> >
> > +static bool devlink_port_function_state_valid(u8 state)
>
> you have a named enum so why not 'enum devlink_port_function_state state'?
>
Right. I should. I missed it.
Will do.
>
> > +{
> > + return state == DEVLINK_PORT_FUNCTION_STATE_INACTIVE ||
> > + state == DEVLINK_PORT_FUNCTION_STATE_ACTIVE;
> > +}
> > +
> > +static int devlink_port_function_state_fill(struct devlink *devlink, const struct
> devlink_ops *ops,
> > + struct devlink_port *port, struct
> sk_buff *msg,
> > + struct netlink_ext_ack *extack, bool
> *msg_updated) {
> > + enum devlink_port_function_state state;
> > + int err;
> > +
> > + if (!ops->port_function_state_get)
> > + return 0;
> > +
> > + err = ops->port_function_state_get(devlink, port, &state, extack);
> > + if (err) {
> > + if (err == -EOPNOTSUPP)
> > + return 0;
> > + return err;
> > + }
> > + if (!devlink_port_function_state_valid(state)) {
> > + WARN_ON(1);
>
> WARN_ON_ONCE at most.
>
Yep. I will change to WARN_ON_ONCE.
next prev parent reply other threads:[~2020-09-18 3:30 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-17 8:17 [PATCH net-next 0/8] devlink: Add SF add/delete devlink ops Parav Pandit
2020-09-17 8:17 ` [PATCH net-next 1/8] devlink: Introduce PCI SF port flavour and port attribute Parav Pandit
2020-09-17 8:17 ` [PATCH net-next 2/8] devlink: Support add and delete devlink port Parav Pandit
2020-09-17 8:17 ` [PATCH net-next 3/8] devlink: Prepare code to fill multiple port function attributes Parav Pandit
2020-09-17 8:17 ` [PATCH net-next 4/8] devlink: Support get and set state of port function Parav Pandit
2020-09-17 8:17 ` [PATCH net-next 5/8] netdevsim: Add support for add and delete of a PCI PF port Parav Pandit
2020-09-17 11:16 ` [PATCH] netdevsim: fix semicolon.cocci warnings kernel test robot
[not found] ` <202009171937.JRIyGgCc%lkp@intel.com>
2020-09-17 13:57 ` [PATCH net-next 5/8] netdevsim: Add support for add and delete of a PCI PF port Parav Pandit
2020-09-17 8:17 ` [PATCH net-next 6/8] netdevsim: Simulate get/set hardware address of a PCI port Parav Pandit
2020-09-17 8:17 ` [PATCH net-next 7/8] netdevsim: Simulate port function state for " Parav Pandit
2020-09-17 17:20 ` [PATCH net-next v2 0/8] devlink: Add SF add/delete devlink ops Parav Pandit
2020-09-17 17:20 ` [PATCH net-next v2 1/8] devlink: Introduce PCI SF port flavour and port attribute Parav Pandit
2020-09-17 20:01 ` David Ahern
2020-09-18 4:18 ` Parav Pandit
2020-09-18 15:15 ` David Ahern
2020-09-18 16:13 ` Parav Pandit
2020-09-19 4:49 ` David Ahern
2020-09-19 5:35 ` Parav Pandit
[not found] ` <fcb55cc1-3be3-3eaa-68d5-28b4d112e291@intel.com>
2020-09-18 3:54 ` Parav Pandit
2020-09-18 23:04 ` Jacob Keller
2020-09-17 17:20 ` [PATCH net-next v2 2/8] devlink: Support add and delete devlink port Parav Pandit
[not found] ` <28cbe5b9-a39e-9299-8c9b-6cce63328f0f@intel.com>
2020-09-18 4:25 ` Parav Pandit
2020-09-18 23:06 ` Jacob Keller
2020-09-19 5:39 ` Parav Pandit
2020-09-17 17:20 ` [PATCH net-next v2 3/8] devlink: Prepare code to fill multiple port function attributes Parav Pandit
[not found] ` <0dc57740-48fb-d77f-dcdf-2607ef2dc545@intel.com>
2020-09-18 3:35 ` Parav Pandit
2020-09-18 22:53 ` Jacob Keller
2020-09-19 5:41 ` Parav Pandit
2020-09-17 17:20 ` [PATCH net-next v2 4/8] devlink: Support get and set state of port function Parav Pandit
2020-09-17 20:23 ` David Ahern
2020-09-18 3:30 ` Parav Pandit [this message]
2020-09-17 17:20 ` [PATCH net-next v2 5/8] netdevsim: Add support for add and delete of a PCI PF port Parav Pandit
2020-09-17 17:20 ` [PATCH net-next v2 6/8] netdevsim: Simulate get/set hardware address of a PCI port Parav Pandit
2020-09-17 17:20 ` [PATCH net-next v2 7/8] netdevsim: Simulate port function state for " Parav Pandit
2020-09-17 17:20 ` [PATCH net-next v2 8/8] netdevsim: Add support for add and delete PCI SF port Parav Pandit
2020-09-17 20:31 ` David Ahern
2020-09-18 3:29 ` Parav Pandit
2020-09-18 3:38 ` David Ahern
2020-09-18 4:41 ` Parav Pandit
2020-09-18 4:53 ` Samudrala, Sridhar
2020-09-18 5:10 ` Parav Pandit
2020-09-18 15:23 ` David Ahern
2020-09-18 15:51 ` Parav Pandit
2020-09-18 16:52 ` [PATCH net-next v2 0/8] devlink: Add SF add/delete devlink ops Jakub Kicinski
2020-09-18 17:08 ` Parav Pandit
2020-09-18 17:37 ` Jakub Kicinski
2020-09-18 17:47 ` Parav Pandit
2020-09-18 18:28 ` Jakub Kicinski
2020-09-18 20:09 ` Parav Pandit
2020-09-21 22:02 ` Jakub Kicinski
2020-09-22 4:37 ` Parav Pandit
2020-09-17 8:17 ` [PATCH net-next 8/8] netdevsim: Add support for add and delete PCI SF port Parav Pandit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BY5PR12MB4322ACBFC1F5C2C0CF694BFCDC3F0@BY5PR12MB4322.namprd12.prod.outlook.com \
--to=parav@nvidia.com \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=jiri@nvidia.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).