From: Parav Pandit <parav@nvidia.com>
To: "Samudrala, Sridhar" <sridhar.samudrala@intel.com>,
Saeed Mahameed <saeed@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Jason Gunthorpe <jgg@nvidia.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"alexander.duyck@gmail.com" <alexander.duyck@gmail.com>,
"edwin.peer@broadcom.com" <edwin.peer@broadcom.com>,
"dsahern@kernel.org" <dsahern@kernel.org>,
"kiran.patil@intel.com" <kiran.patil@intel.com>,
"jacob.e.keller@intel.com" <jacob.e.keller@intel.com>,
"david.m.ertman@intel.com" <david.m.ertman@intel.com>,
"dan.j.williams@intel.com" <dan.j.williams@intel.com>,
Vu Pham <vuhuong@nvidia.com>, Saeed Mahameed <saeedm@nvidia.com>
Subject: RE: [net-next V9 03/14] devlink: Support add and delete devlink port
Date: Fri, 22 Jan 2021 03:31:01 +0000 [thread overview]
Message-ID: <BY5PR12MB4322C9132AFAF14E00E7B447DCA09@BY5PR12MB4322.namprd12.prod.outlook.com> (raw)
In-Reply-To: <0a51e4e2-97f2-a5bc-c9b4-7589882d69d6@intel.com>
> From: Samudrala, Sridhar <sridhar.samudrala@intel.com>
> Sent: Friday, January 22, 2021 2:21 AM
>
> > $ devlink port show
> > pci/0000:06:00.0/65535: type eth netdev ens2f0np0 flavour physical
> > port 0 splittable false
> >
> > $ devlink port add pci/0000:06:00.0 flavour pcisf pfnum 0 sfnum 88
>
> Do we need to specify pfnum when adding a SF port? Isn't this redundant?
> Isn't there a 1:1 mapping between the pci device and a pfnum?
>
No. it's not entirely redundant.
Currently in most cases today it is same function number as that of PCI device.
Netronome has one devlink instance that represents multiple PCI devices.
Someday mlx5 driver might have it too for the single eswitch instance among multiple PCI devices of one physical card.
So it is needed to specify.
next prev parent reply other threads:[~2021-01-22 3:32 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-21 8:52 [pull request][net-next V9 00/14] Add mlx5 subfunction support Saeed Mahameed
2021-01-21 8:52 ` [net-next V9 01/14] devlink: Prepare code to fill multiple port function attributes Saeed Mahameed
2021-01-21 8:52 ` [net-next V9 02/14] devlink: Introduce PCI SF port flavour and port attribute Saeed Mahameed
2021-01-21 8:52 ` [net-next V9 03/14] devlink: Support add and delete devlink port Saeed Mahameed
2021-01-21 20:50 ` Samudrala, Sridhar
2021-01-22 3:31 ` Parav Pandit [this message]
2021-01-22 21:23 ` Jacob Keller
2021-01-21 8:52 ` [net-next V9 04/14] devlink: Support get and set state of port function Saeed Mahameed
2021-01-21 20:52 ` Samudrala, Sridhar
2021-01-22 3:34 ` Parav Pandit
2021-01-21 8:52 ` [net-next V9 05/14] net/mlx5: Introduce vhca state event notifier Saeed Mahameed
2021-01-21 8:52 ` [net-next V9 06/14] net/mlx5: SF, Add auxiliary device support Saeed Mahameed
2021-01-21 8:52 ` [net-next V9 07/14] net/mlx5: SF, Add auxiliary device driver Saeed Mahameed
2021-01-21 8:52 ` [net-next V9 08/14] net/mlx5: E-switch, Prepare eswitch to handle SF vport Saeed Mahameed
2021-01-21 8:52 ` [net-next V9 09/14] net/mlx5: E-switch, Add eswitch helpers for " Saeed Mahameed
2021-01-21 8:52 ` [net-next V9 10/14] net/mlx5: SF, Add port add delete functionality Saeed Mahameed
2021-01-21 8:52 ` [net-next V9 11/14] net/mlx5: SF, Port function state change support Saeed Mahameed
2021-01-21 8:52 ` [net-next V9 12/14] devlink: Add devlink port documentation Saeed Mahameed
2021-01-21 8:52 ` [net-next V9 13/14] devlink: Extend devlink port documentation for subfunctions Saeed Mahameed
2021-01-21 8:52 ` [net-next V9 14/14] net/mlx5: Add devlink subfunction port documentation Saeed Mahameed
2021-01-21 20:59 ` Samudrala, Sridhar
2021-01-22 0:11 ` Jason Gunthorpe
2021-01-23 20:09 ` Samudrala, Sridhar
2021-01-25 13:06 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BY5PR12MB4322C9132AFAF14E00E7B447DCA09@BY5PR12MB4322.namprd12.prod.outlook.com \
--to=parav@nvidia.com \
--cc=alexander.duyck@gmail.com \
--cc=dan.j.williams@intel.com \
--cc=davem@davemloft.net \
--cc=david.m.ertman@intel.com \
--cc=dsahern@kernel.org \
--cc=edwin.peer@broadcom.com \
--cc=jacob.e.keller@intel.com \
--cc=jgg@nvidia.com \
--cc=kiran.patil@intel.com \
--cc=kuba@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=saeed@kernel.org \
--cc=saeedm@nvidia.com \
--cc=sridhar.samudrala@intel.com \
--cc=vuhuong@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).