From: Srujana Challa <schalla@marvell.com>
To: Andrew Lunn <andrew@lunn.ch>,
Sunil Kovvuri Goutham <sgoutham@marvell.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
"davem@davemloft.net" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
"Suheil Chandran" <schandran@marvell.com>,
Narayana Prasad Raju Athreya <pathreya@marvell.com>,
Linu Cherian <lcherian@marvell.com>,
"Geethasowjanya Akula" <gakula@marvell.com>,
Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
Ard Biesheuvel <ardb@kernel.org>
Subject: RE: [EXT] Re: [PATCH v2 2/3] drivers: crypto: add support for OCTEONTX2 CPT engine
Date: Tue, 8 Sep 2020 14:20:52 +0000 [thread overview]
Message-ID: <BYAPR18MB2791E9E6B435E27E8143836BA0290@BYAPR18MB2791.namprd18.prod.outlook.com> (raw)
In-Reply-To: <20200904183834.GS3112546@lunn.ch>
> Subject: Re: [EXT] Re: [PATCH v2 2/3] drivers: crypto: add support for
> OCTEONTX2 CPT engine
>
> On Fri, Sep 04, 2020 at 04:36:29PM +0000, Sunil Kovvuri Goutham wrote:
> >
> >
> > > -----Original Message-----
> > > From: Herbert Xu <herbert@gondor.apana.org.au>
> > > Sent: Friday, September 4, 2020 7:48 PM
> > > To: Srujana Challa <schalla@marvell.com>
> > > Cc: davem@davemloft.net; netdev@vger.kernel.org; linux-
> > > crypto@vger.kernel.org; Suheil Chandran <schandran@marvell.com>;
> > > Narayana Prasad Raju Athreya <pathreya@marvell.com>; Sunil Kovvuri
> > > Goutham <sgoutham@marvell.com>; Linu Cherian <lcherian@marvell.com>;
> > > Geethasowjanya Akula <gakula@marvell.com>; Jerin Jacob Kollanukkaran
> > > <jerinj@marvell.com>; Ard Biesheuvel <ardb@kernel.org>
> > > Subject: Re: [EXT] Re: [PATCH v2 2/3] drivers: crypto: add support for
> > > OCTEONTX2 CPT engine
> > >
> > > On Fri, Sep 04, 2020 at 02:14:34PM +0000, Srujana Challa wrote:
> > > >
> > > > Since LMT store is our platform specific, it cannot be generalized to all
> > > ARM64.
> > >
> > > I'm not asking you to generalise it to all of ARM64. I'm asking you to move
> > > this into a header file under arch/arm64 that can then be shared by both your
> > > crypto driver and your network driver so you don't duplicate this
> > > everywhere.
> > >
> >
> > For ARM64 , except erratas other platform or machine dependent stuff are not
> allowed inside arch/arm64.
> > Also an earlier attempt by us to add few APIs addressing 128bit operations were
> not allowed by ARM folks
> > as they don't work in a generic way and are SOC specific.
> > https://urldefense.proofpoint.com/v2/url?u=http-
> 3A__lkml.iu.edu_hypermail_linux_kernel_1801.3_02211.html&d=DwIBAg&c=nKj
> Wec2b6R0mOyPaz7xtfQ&r=Fj4OoD5hcKFpANhTWdwQzjT1Jpf7veC5263T47JVpnc
> &m=_Crtymahn2yLpOWm4M2GAuzClE9EQVX2165DSnCx79E&s=FfyU3YaCxgJRXa
> 2EzyZrTvnWFYh8K2KmifpZAQN0gJk&e=
>
> Maybe put it in include/linux/soc/ ?
>
Okay, I will move this block of code into a header file under include/linux/soc.
Thanks.
> Andrew
next prev parent reply other threads:[~2020-09-08 19:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-07 14:09 [PATCH v2 0/3] Add Support for Marvell OcteonTX2 Cryptographic Srujana Challa
2020-08-07 14:09 ` [PATCH v2 1/3] octeontx2-af: add support to manage the CPT unit Srujana Challa
2020-08-07 14:09 ` [PATCH v2 2/3] drivers: crypto: add support for OCTEONTX2 CPT engine Srujana Challa
2020-08-07 15:24 ` Jakub Kicinski
2020-08-13 0:51 ` Herbert Xu
2020-08-13 0:54 ` Herbert Xu
2020-09-04 13:45 ` Srujana Challa
2020-09-04 13:50 ` Herbert Xu
2020-09-04 14:14 ` [EXT] " Srujana Challa
2020-09-04 14:17 ` Herbert Xu
2020-09-04 16:36 ` Sunil Kovvuri Goutham
2020-09-04 18:38 ` Andrew Lunn
2020-09-08 14:20 ` Srujana Challa [this message]
2020-08-07 14:09 ` [PATCH v2 3/3] drivers: crypto: add the Virtual Function driver for OcteonTX2 CPT Srujana Challa
2020-08-13 0:58 ` Herbert Xu
2020-08-08 0:17 ` [PATCH v2 0/3] Add Support for Marvell OcteonTX2 Cryptographic David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR18MB2791E9E6B435E27E8143836BA0290@BYAPR18MB2791.namprd18.prod.outlook.com \
--to=schalla@marvell.com \
--cc=andrew@lunn.ch \
--cc=ardb@kernel.org \
--cc=davem@davemloft.net \
--cc=gakula@marvell.com \
--cc=herbert@gondor.apana.org.au \
--cc=jerinj@marvell.com \
--cc=lcherian@marvell.com \
--cc=linux-crypto@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pathreya@marvell.com \
--cc=schandran@marvell.com \
--cc=sgoutham@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).