From: "Patel, Vedang" <vedang.patel@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Cong Wang <xiyou.wangcong@gmail.com>,
Jiri Pirko <jiri@resnulli.us>,
"Gomes, Vinicius" <vinicius.gomes@intel.com>,
"Dorileo, Leandro" <leandro.maciel.dorileo@intel.com>,
"jakub.kicinski@netronome.com" <jakub.kicinski@netronome.com>,
"m-karicheri2@ti.com" <m-karicheri2@ti.com>,
"dsahern@gmail.com" <dsahern@gmail.com>
Subject: Re: [PATCH iproute2 net-next v5 1/5] etf: Add skip_sock_check
Date: Fri, 19 Jul 2019 21:39:33 +0000 [thread overview]
Message-ID: <C21E09F7-D035-46A5-A924-95AF9FB07D97@intel.com> (raw)
In-Reply-To: <20190718221227.46631096@hermes.lan>
> On Jul 18, 2019, at 10:12 PM, Stephen Hemminger <stephen@networkplumber.org> wrote:
>
> On Thu, 18 Jul 2019 12:55:39 -0700
> Vedang Patel <vedang.patel@intel.com> wrote:
>
>> - print_string(PRINT_ANY, "deadline_mode", "deadline_mode %s",
>> + print_string(PRINT_ANY, "deadline_mode", "deadline_mode %s ",
>> (qopt->flags & TC_ETF_DEADLINE_MODE_ON) ? "on" : "off");
>> + print_string(PRINT_ANY, "skip_sock_check", "skip_sock_check %s",
>> + (qopt->flags & TC_ETF_SKIP_SOCK_CHECK) ? "on" : "off");
>
> These should really be boolean options in JSON, not string values.
Ok. Sending out a patch to fix this.
Thanks,
Vedang
prev parent reply other threads:[~2019-07-19 21:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-18 19:55 [PATCH iproute2 net-next v5 1/5] etf: Add skip_sock_check Vedang Patel
2019-07-18 19:55 ` [PATCH iproute2 net-next v5 2/5] taprio: Add support for setting flags Vedang Patel
2019-07-18 19:55 ` [PATCH iproute2 net-next v5 3/5] taprio: add support for setting txtime_delay Vedang Patel
2019-07-18 19:55 ` [PATCH iproute2 net-next v5 4/5] tc: etf: Add documentation for skip_sock_check Vedang Patel
2019-07-18 19:55 ` [PATCH iproute2 net-next v5 5/5] tc: taprio: Update documentation Vedang Patel
2019-07-18 22:48 ` [PATCH iproute2 net-next v5 1/5] etf: Add skip_sock_check David Ahern
2019-07-19 5:12 ` Stephen Hemminger
2019-07-19 21:39 ` Patel, Vedang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C21E09F7-D035-46A5-A924-95AF9FB07D97@intel.com \
--to=vedang.patel@intel.com \
--cc=dsahern@gmail.com \
--cc=jakub.kicinski@netronome.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=leandro.maciel.dorileo@intel.com \
--cc=m-karicheri2@ti.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=vinicius.gomes@intel.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).