From: "Tobias Waldekranz" <tobias@waldekranz.com>
To: "Vladimir Oltean" <olteanv@gmail.com>
Cc: <andrew@lunn.ch>, <vivien.didelot@gmail.com>,
<f.fainelli@gmail.com>, <netdev@vger.kernel.org>
Subject: Re: [RFC PATCH 2/4] net: dsa: link aggregation support
Date: Wed, 28 Oct 2020 15:03:15 +0100 [thread overview]
Message-ID: <C6OKWDSV75FQ.1YBMNPWQ63810@wkz-x280> (raw)
In-Reply-To: <20201028005855.2xgvheizr5cz6s3a@skbuf>
On Wed Oct 28, 2020 at 3:58 AM CET, Vladimir Oltean wrote:
> When you use dsa_broadcast, it is reachable from _all_ switch trees, not
> from "the" switch tree. This was added to support "islands" of
> inter-compatible DSA switches separated by other DSA switches with
> incompatible taggers. Not sure if it was a voluntary decision to use
> that as opposed to plain dsa_port_notify. Not a problem either way.
You're right, I want dsa_port_notify. I will change it and also remove
the tree_index from the notifier info struct.
> > + /* For multichip systems, we must ensure that each hash bucket
> > + * is only enabled on a single egress port throughout the
> > + * whole tree.
>
> Or else?
> I don't really understand this statement.
Or else we will send the same packet through multiple ports. I.e. if
we have swp0..2 in a LAG with bucket config like this:
Bucket# swp0 swp1 swp2
0 Y n n
1 Y n n
2 Y n n
3 Y Y n
4 n Y n
5 n Y n
6 n n Y
7 n n Y
Packets that hash to bucket 3 would be sent out through both swp0 and
swp1, which the receiver would interpret as two distinct packets with
the same contents.
I will reword it to make it more clear.
> > + struct dsa_lag *lag;
> > + unsigned long busy = 0;
>
> Reverse Christmas notation please?
I have no excuses. :)
> > - if (obj->orig_dev != dev)
> > + if (!(obj->orig_dev == dev ||
> > + (dp->lag && obj->orig_dev == dp->lag->dev)))
>
> A small comment here maybe?
Yep, will do.
Thanks,
Tobias
next prev parent reply other threads:[~2020-10-28 23:31 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-27 10:51 [RFC PATCH 0/4] net: dsa: link aggregation support Tobias Waldekranz
2020-10-27 10:51 ` [RFC PATCH 1/4] net: dsa: mv88e6xxx: use ethertyped dsa for 6390/6390X Tobias Waldekranz
2020-10-27 14:52 ` Marek Behun
2020-10-27 14:54 ` Marek Behun
2020-10-27 14:58 ` Marek Behun
2020-10-27 10:51 ` [RFC PATCH 2/4] net: dsa: link aggregation support Tobias Waldekranz
2020-10-28 0:58 ` Vladimir Oltean
2020-10-28 14:03 ` Tobias Waldekranz [this message]
2020-10-27 10:51 ` [RFC PATCH 3/4] net: dsa: mv88e6xxx: " Tobias Waldekranz
2020-10-27 10:51 ` [RFC PATCH 4/4] net: dsa: tag_edsa: support reception of packets from lag devices Tobias Waldekranz
2020-10-28 12:05 ` Vladimir Oltean
2020-10-28 15:28 ` Tobias Waldekranz
2020-10-28 18:18 ` Vladimir Oltean
2020-10-28 22:31 ` Tobias Waldekranz
2020-10-28 23:08 ` Vladimir Oltean
2020-10-29 7:47 ` Tobias Waldekranz
2020-10-30 9:21 ` Vladimir Oltean
2020-11-01 11:31 ` Ido Schimmel
2020-10-27 12:27 ` [RFC PATCH 0/4] net: dsa: link aggregation support Vladimir Oltean
2020-10-27 14:29 ` Andrew Lunn
2020-10-27 14:59 ` Tobias Waldekranz
2020-10-27 14:00 ` Andrew Lunn
2020-10-27 15:09 ` Tobias Waldekranz
2020-10-27 15:05 ` Marek Behun
2020-10-27 15:23 ` Andrew Lunn
2020-10-27 18:25 ` Tobias Waldekranz
2020-10-27 18:33 ` Marek Behun
2020-10-27 19:04 ` Vladimir Oltean
2020-10-27 19:21 ` Tobias Waldekranz
2020-10-27 19:00 ` Vladimir Oltean
2020-10-27 19:37 ` Tobias Waldekranz
2020-10-27 20:02 ` Vladimir Oltean
2020-10-27 20:53 ` Tobias Waldekranz
2020-10-27 22:32 ` Vladimir Oltean
2020-10-28 0:27 ` Tobias Waldekranz
2020-10-28 22:35 ` Marek Behun
2020-10-27 22:36 ` Andrew Lunn
2020-10-28 0:45 ` Tobias Waldekranz
2020-10-28 1:03 ` Andrew Lunn
2020-11-11 4:28 ` Florian Fainelli
2020-11-19 10:51 ` Vladimir Oltean
2020-11-19 11:52 ` Tobias Waldekranz
2020-11-19 18:12 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C6OKWDSV75FQ.1YBMNPWQ63810@wkz-x280 \
--to=tobias@waldekranz.com \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).