From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Torvalds Subject: Re: [GIT] Networking Date: Thu, 3 Sep 2015 12:48:15 -0700 Message-ID: References: <20150902.223522.1792493140210966693.davem@davemloft.net> <20150903.104032.767889134756094076.davem@davemloft.net> <1441305296.9666.14.camel@perches.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: Joe Perches , David Miller , Lorenzo Bianconi , Johannes Berg , Andrew Morton , Network Development , Linux Kernel Mailing List To: Julia Lawall Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Thu, Sep 3, 2015 at 12:32 PM, Julia Lawall wrote: > > I find 518 occurrences of a function parameter declaration that contains > an explicit size. But only the sizeof(mcs_mask) where there is a sizeof > on such a parameter. I also checked for ARRAY_SIZE on such parameters, > and didn't find any occurrences of that either. Are there any cases of multi-dimensional arrays? Because those actually have semantic meaning outside of sizeof(), just in things like adding offsets. Eg something like int fn(int a[][10]) ends up being equivalent to something like int fn(int (*a)[10]) and "a+1" is actually 40 bytes ahead of "a", so it does *not* act like an "int *". (And I might have screwed that up mightily - C multidimensional arrays and the conversions to pointers are really easy to get confused about. Which is why I hope we don't have them) Linus