From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Torvalds Subject: Re: [GIT] Networking Date: Tue, 10 Feb 2015 13:50:16 -0800 Message-ID: References: <20150209.191601.1373941323785500419.davem@davemloft.net> <20150209.205209.1524645061817000265.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: Al Viro , Andrew Morton , Network Development , Linux Kernel Mailing List To: David Miller Return-path: Received: from mail-ie0-f179.google.com ([209.85.223.179]:33009 "EHLO mail-ie0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754153AbbBJVuQ (ORCPT ); Tue, 10 Feb 2015 16:50:16 -0500 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Tue, Feb 10, 2015 at 1:26 PM, Linus Torvalds wrote: > > Just to confirm that yes, it's that particular commit 1d10eb2f156f. > > I reverted it and things work again. So it's not the miscalculation of > "used" , but it's certainly *something* in that commit. How about this? - npages = (off + len + PAGE_SIZE - 1) >> PAGE_SHIFT; + npages = PAGE_ALIGN(off + n); The two are not even *remotely* the same thing. It's in af_alg_make_sg(), and it would seem to cause sg_init_table() and the loop that does sg_set_page() do insane things. Possibly including random memory scribbles etc. Which could explain anything. Anyway, I'm now working on the other pulls I have, so I'll leave this for now, but I think that might be it. Linus