From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Valentin Vidic <vvidic@valentin-vidic.from.hr>
Cc: "David S. Miller" <davem@davemloft.net>,
Philip Rischel <rischelp@idt.com>,
Felix Fietkau <nbd@openwrt.org>,
Florian Fainelli <florian@openwrt.org>,
Roman Yeryomin <roman@advem.lv>, Jakub Kicinski <kuba@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Mike Rapoport <rppt@kernel.org>,
Martin Habets <mhabets@solarflare.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Network Development <netdev@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net: korina: free array used for rx/tx descriptors
Date: Sun, 11 Oct 2020 14:37:33 -0400 [thread overview]
Message-ID: <CA+FuTScdX+kN_XHJiY9YCst6JTQHZ0g28XYakhcK92Oo2Kp5vw@mail.gmail.com> (raw)
In-Reply-To: <20201011113955.19511-1-vvidic@valentin-vidic.from.hr>
On Sun, Oct 11, 2020 at 7:46 AM Valentin Vidic
<vvidic@valentin-vidic.from.hr> wrote:
>
> Memory was not freed when driver is unloaded from the kernel.
>
> Signed-off-by: Valentin Vidic <vvidic@valentin-vidic.from.hr>
Makes sense.
Fixes: ef11291bcd5f ("Add support the Korina (IDT RC32434) Ethernet MAC")
Slightly off-topic, but I don't fully fathom what goes on with this
pointer straight after the initial kmalloc.
lp->td_ring = (struct dma_desc *)KSEG1ADDR(lp->td_ring);
> ---
> drivers/net/ethernet/korina.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/korina.c b/drivers/net/ethernet/korina.c
> index 03e034918d14..99146145f020 100644
> --- a/drivers/net/ethernet/korina.c
> +++ b/drivers/net/ethernet/korina.c
> @@ -1133,6 +1133,7 @@ static int korina_remove(struct platform_device *pdev)
> iounmap(lp->eth_regs);
> iounmap(lp->rx_dma_regs);
> iounmap(lp->tx_dma_regs);
> + kfree(lp->td_ring);
>
> unregister_netdev(bif->dev);
> free_netdev(bif->dev);
In general it is nice to release in reverse of acquire. But the driver
already does not follow this practice.
next prev parent reply other threads:[~2020-10-11 18:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-11 11:39 [PATCH] net: korina: free array used for rx/tx descriptors Valentin Vidic
2020-10-11 18:37 ` Willem de Bruijn [this message]
2020-10-11 21:21 ` Valentin Vidić
2020-10-11 22:03 ` [PATCH v2] net: korina: fix kfree of rx/tx descriptor array Valentin Vidic
2020-10-11 22:53 ` Willem de Bruijn
2020-10-12 17:07 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+FuTScdX+kN_XHJiY9YCst6JTQHZ0g28XYakhcK92Oo2Kp5vw@mail.gmail.com \
--to=willemdebruijn.kernel@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=florian@openwrt.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhabets@solarflare.com \
--cc=mst@redhat.com \
--cc=nbd@openwrt.org \
--cc=netdev@vger.kernel.org \
--cc=rischelp@idt.com \
--cc=roman@advem.lv \
--cc=rppt@kernel.org \
--cc=vvidic@valentin-vidic.from.hr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).